Leader board problem

[hienlong_phan (Mels)]

game.Players.PlayerAdded:connect(function(p)
local stats = Instance.new("IntValue", p)
stats.Name = "leaderstats"
local Time = Instance.new("IntValue", stats)
Time.Name = "Time Played"
local money = Instance.new("IntValue", stats)
money.Name = "Cash"
money.Value = 0

while true do
local MoneyDebounce = 0
wait(1)
		Time.Value = Time.Value + 1
		MoneyDebounce = MoneyDebounce + 1
		print(MoneyDebounce)
		if MoneyDebounce == 60 then
			money.Value = 10
		end
			
end
end)

output keep printing “moneydebounce” as 1 even when i tried to fix it

[VitalWinter]

You define MoneyDebounce locally inside the of the while loop. That value doesn’t exist outside the scope of the while loop. If you move the local MoneyDebounce = 0 to be outside of the while loop, it should continue to increment.

[hienlong_phan (Mels)]

thx u so much
i don’t think 'bout that

[Forummer]

local Players = game:GetService("Players")

Players.PlayerAdded:Connect(function(Player)
	local leaderstats = Instance.new("IntValue")
	leaderstats.Parent = Player
	leaderstats.Name = "leaderstats"
	
	local Time = Instance.new("IntValue")
	Time.Parent = leaderstats
	Time.Name = "Time Played"
	
	local Money = Instance.new("IntValue")
	Money.Parent = leaderstats
	Money.Name = "Cash"
	Money.Value = 0
	
	local Timer = 0
	task.spawn(function()
		while task.wait(1) do
			Time.Value += 1
			Timer += 1
			print(Timer)
			if Timer == 60 then
				Money.Value += 10
			end
		end
	end)
end)

A few issues, you’re using the deprecated connection method “:connect()” instead of the current version “:Connect()” which should be used for any new work, you’re setting the parent parameter when calling Instance.new() which is strongly advised against, more info regarding that here.

PSA: Don't use Instance.new() with parent argument

I’ve discovered a pretty bad performance issue in one of top games that has to do with Instance.new and wanted to write about this, since this is not obvious unless you know the system inside out. Tthere are several ways to create a ROBLOX object in Lua: local obj = Instance.new(‘type’); fill obj fields local obj = Instance.new(‘type’, parent); fill obj fields local obj = util.Create(‘type’, { field1 = value1, … }) If you care at all about performance, please only use the first option - I wi…

You’re using “stats” as a variable name (I’ve opted to use “leaderstats” instead) which conflicts with a reserved global in Roblox Lua (this is why it appears as red text), its purpose is to get the stats service.

Create on Roblox

Stats stats ( )
Returns the Stats service.
It is preferred that developers use ServiceProvider:GetService to retrieve it instead.

and as previously mentioned you’re declaring “MoneyDebounce” locally inside the while loop and assigning to it a value of 0 everytime the cycle performs a single loop/pass/round which means that when its value is incremented by 1 it’ll just get set to 1 before being reset back to 0.

I also believe you made an issue with the cash giving part, I assume you’re trying to give 10 cash per 60 seconds of in-game time which elapse but in your script the cash value is just set to 10 instead of being incremented by 10, so I’ve fixed this too.

Finally, instead of doing x = x + n to increase the value stored inside some variable (example named x) by some value (example named n) you can just use x += n to perform the same arithmetic calculation, this will work with the other arithmetic operators too like /, +, * etc.