Local scripts not working

Help and Feedback Scripting Support
#1

i scripted a local script that if my “move dlc” value is true, then my gui should be destoryed and my control should be enabled with “warn” message

but even if my value is true, my gui comes out
if i tested with value’s false, nothing happens…

(they are in starergui)

gui show up code

local plr = game.Players.LocalPlayer

plr.CharacterAdded:Wait()

if plr:FindFirstChild("move_dlc").Value == true then
	
	plr.PlayerGui:FindFirstChild("dcl for move"):Destroy()
	script:Destroy()
	
else
	
	local userinputservice = game:GetService("UserInputService")
	userinputservice.InputBegan:Connect(function(input, gameProcessedEvent)
		if gameProcessedEvent then return end
		
		local frame = plr.PlayerGui:FindFirstChild("dcl for move"):FindFirstChild("Frame")

		if input.UserInputType == Enum.UserInputType.Keyboard and plr:FindFirstChild("move_dlc").Value == false then
			
			if frame.Position == UDim2.new(0.499, 0, -0.7, 0) and input.KeyCode == Enum.KeyCode.W then
				frame.Visible = true
				script.show:Play()
				frame:TweenPosition(UDim2.new(0.499, 0, 0.447, 0),
				 "Out",
				 "Bounce",
				 0.6,
				true)
			
			end
			
			if frame.Position == UDim2.new(0.499, 0, -0.7, 0) and input.KeyCode == Enum.KeyCode.W then
				frame.Visible = true
				script.show:Play()
				frame:TweenPosition(UDim2.new(0.499, 0, 0.447, 0),
					"Out",
					"Bounce",
					0.6,
					true)
			end
			
			if frame.Position == UDim2.new(0.499, 0, -0.7, 0) and input.KeyCode == Enum.KeyCode.W then
				frame.Visible = true
				script.show:Play()
				frame:TweenPosition(UDim2.new(0.499, 0, 0.447, 0),
					"Out",
					"Bounce",
					0.6,
					true)
			end
			
			if frame.Position == UDim2.new(0.499, 0, -0.7, 0) and input.KeyCode == Enum.KeyCode.W then
				frame.Visible = true
				script.show:Play()
				frame:TweenPosition(UDim2.new(0.499, 0, 0.447, 0),
					"Out",
					"Bounce",
					0.6,
					true)
			end
			
		end
		

		
	end)
end

enable/disable move code

local plr = game.Players.LocalPlayer

plr.CharacterAdded:Wait()


local controls = require(plr.PlayerScripts:WaitForChild("PlayerModule")):GetControls()

if plr:FindFirstChild("move_dlc").Value == true then
	warn(plr.Name.." has a move dlc")
	controls:Enable()
	script:Destroy()
else
	warn("unable to move, "..game.Players.LocalPlayer.Name)
	controls:Disable()
end

if i put those on starterplayerscripts, they worked but not perfectly
always show up gui even if my value is true

3 Likes
#2

You misunderstand how if-statements work. An if-statement is a control structure that allows you to check against a certain condition. If the condition is true, then the body of the control structure is executed. You mistake if statements to execute their bodies when the condition is true.

To sum it up, if-statements are only evaluated once at runtime. You need to design your script to continuously check the condition, or use events to run code when a change in the “Value” property of your BoolValue is detected. The latter is more appropriate, so I’ll demonstrate the “Changed” event as a solution:

local moveDlc = player:WaitForChild("move_dlc")

local function checkDisableMovementControls()
    if moveDlc.Value then
        controls:Disable()
    end
end

checkDisableMovementControls()

moveDlc.Changed:Connect(checkDisableMovementControls)
#3

i changed script like this

local plr = game.Players.LocalPlayer

local moveDlc = plr:WaitForChild("move_dlc")

local controls = require(plr.PlayerScripts:WaitForChild("PlayerModule")):GetControls()

local function checkDisableMovementControls()
	if moveDlc.Value then
		warn(plr.Name.." has a move dlc")
		controls:Enable()
		script:Destroy()
	else
		warn("unable to move, "..game.Players.LocalPlayer.Name)
		controls:Disable()
	end
end

plr.CharacterAdded:Wait()

checkDisableMovementControls()

moveDlc.Changed:Connect(checkDisableMovementControls)

but script still dont work on startergui
and in starterplayerscript, it printed “unable to move” first, then printed “has a move dlc” after secs
but i cant move even if my value is true :smiling_face_with_tear:

ive never experience this problem before :smiling_face_with_tear:…

#4

Remove the following code. It is not relevant to your script and is only harmful:

plr.CharacterAdded:Wait()

Your script has no reason to be in StarterGui either. It should remain in StarterPlayerScripts. Make sure you’re not setting the parent of your BoolValue until its “Value” property has been set

1 Like
#5

removed that code, and not setting anything but still not working…

#6

i solved it this issue is because of the datastore.
while getting datas from datastore, my script was getting data from player so early
so i added a remote event and solved

#7

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.