Marketplace not checking

Help and Feedback Scripting Support
#1

I’m trying to do a catalog item finder, where it checks if you have an item from the catalog. It goes in a for loop inside the catalog array and checks through the MarketPlaceService:PlayerOwnsAsset() every item if player owns it. The first item ín the list that I have bought it recognises it well, but after it doesn’t recognise anymore items.

for i, v in pairs(catalog) do
print(v, game:GetService("MarketplaceService"):PlayerOwnsAsset(game.Players.LocalPlayer, v))
if game:GetService("MarketplaceService"):PlayerOwnsAsset(game.Players.LocalPlayer, v) then
	print(v)
end
wait(1)
end
#2

There isn’t enough information to provide assistance. Could you please provide any errors which are outputted and the array it’s iterating through?

Cheers.

#3

The game shows no errors. Thats the problem, I cant know what’s happening.

#4

Its just that after the game has confirmed that I own an item, the following item that I have is game:GetService("MarketplaceService"):PlayerOwnsAsset(game.Players.LocalPlayer) = false

#5

Please provide the array of assets it’s iterating through (catalog).

#6

Its an array of 300 characters.

catalog = {2854837694
,2854815725
,2854835543
,2949314638...}
#7

What type of assets does the catalog array contain? :PlayerOwnsAsset() will return whether you own a catalog asset such as an accessory, face or shirt.

As an example, providing the function with the assetid of this badge I own will return false, since I the assetid is a corresponding catalog item.

#8

Its all types of shirts, pants…

#9

To clarify, how many times is true/false outputted? I’d like to attempt to reproduce this in my own local environment, so please send the catalog array containing all 300 assets. If you don’t want to do so here, please send it via PM to me here.

#10

After the 90th item it also shows me this error:
MarketPlaceService::PlayerOwnsAsset failed because HTTP 0 (HTTP 429)

#11

HTTP response code 429 means you’ve submitted too many requests. It’s only natural given you’re attempting to call :PlayerOwnsAssets() 300 times.

Disregarding that, it’d still take over 300 seconds to get the results for all 300 items (given your wait(1)).

What are you trying to ultimately achieve? This is the result of an XY problem.

1 Like
#12

PlayerOwnsAsset is internally a web call, so good practice for using this event would be wrapping it in a pcall in case the endpoint is down or the code throws an error. You can catch that error and handle blocks as they come.

In addition, you should have absolutely no reason to be calling web APIs so many times in quick succession. If you do find yourself needing that many calls, you need to rethink your code’s structure or purpose, or how to achieve the same functionality without excessive calls.

local success, result = pcall(MarketplaceService.PlayerOwnsAsset, MarketplaceService, Player, AssetId)

if success then
    -- Handle success
else
    warn(result) --> Print the error message to the console in yellow
end
2 Likes
#13

I will try this now, thank you

#14

Don’t just try it. You aren’t going to experience a different result just by changing the way you handle the function call. The issue is fundamentally the way you’re handling your tasks in general, which is excessively calling a web API in quick succession.

#15

yes, but the thing is that it has to ckeck as quickly as possible

#16

Why? That’s one of the few questions that was asked to you some time ago. Why do you have the need to do that?

#17

Because I have to do a global leaderboard and it has to know how much items you bought to position u in the leaderboard

#18

…yeah, you’re really not going to find any solution for this problem unless you either remove that leaderboard, change how it operates or deal with the server spending several minutes trying to queue leaderboards. With the current implementation, the data between the code’s projected finish time and when it started queueing will most likely be heavily out of synchronisation.

There’s nothing further I can really comment about this problem.