Money wont save

Help and Feedback Scripting Support
#60

yeah the numbers are increasing

#61

ill give it a go now :smiley: :+1: .

#62

That’s not a good data store but I believe your code will also work fine but I do not recommend to use it since it can lead to a lot of data loss (mine as well lol)

#63

ok so i should have 69 coins image image 0

#64

Do you have any other data-storing script that may be interfering with the values?

#65

I will put this basic Instance based data store that I’m currently using, if someone wants to learn from it.

-- DataStore.lua
-- @author Nanamin
-- January 2021

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local DataStoreService = game:GetService("DataStoreService")
local RunService = game:GetService("RunService")
local Players = game:GetService("Players")

local DataTemplate = require(script.DataTemplate) -- a table with default data

local DataStore = DataStoreService:GetDataStore("PlayerData")

local function createData(folder, data)
	for name,value in pairs(data) do
		if type(value) == "table" then
			local subFolder = Instance.new("Folder")
			subFolder.Name = name
			subFolder.Parent = folder
			createData(subFolder, value) -- this is a recursive call
		elseif type(value) == "number" then
			local NumberValue = Instance.new("NumberValue")
			NumberValue.Name = name
			NumberValue.Value = value
			NumberValue.Parent = folder
		elseif type(value) == "string" then
			local StringValue = Instance.new("StringValue")
			StringValue.Name = name
			StringValue.Value = value
			StringValue.Parent = folder
		elseif type(value) == "boolean" then
			local BoolValue = Instance.new("BoolValue")
			BoolValue.Name = name
			BoolValue.Value = value
			BoolValue.Parent = folder
		end
	end
end

local function load(player)
	local userId = player.UserId
	local attempts = 0
	local ok, result
	
	while not ok and attempts < 6 do
		ok, result = pcall(DataStore.GetAsync, DataStore, userId)
		if not ok then
			attempts += 1
			warn(result)
			wait(1)
		end
	end
	
	if ok then
		local folder = Instance.new("Folder")
		folder.Name = player.Name
		folder.Parent = ReplicatedStorage
		
		if result then
			createData(folder, result)
		else
			createData(folder, DataTemplate)
		end
	else
		player:Kick("unable to load data")
	end
end

local function save(player)
	if RunService:IsStudio() then
		return
	end
	
	local folder = ReplicatedStorage:WaitForChild(player.Name)
	
	local userId = player.UserId
	local attempts = 0
	local ok, result
	
	local saveTable = {}
	
	for _,item in ipairs(folder:GetChildren()) do
		if item:IsA("Folder") then
			for _,child in ipairs(item:GetChildren()) do
				saveTable[item.Name][child.Name] = child.Value
			end
		else
			saveTable[item.Name] = item.Value
		end
	end
	
	while not ok and attempts < 6 do
		ok, result = pcall(DataStore.SetAsync, DataStore, userId, saveTable)
		if not ok then
			attempts += 1
			warn(result)
			wait(7)
		end
	end
	
	if not ok then
		warn(result)
	end
end

Players.PlayerAdded:Connect(load)
Players.PlayerRemoving:Connect(save)

for _,player in ipairs(Players:GetPlayers()) do -- sometimes PlayerAdded event won't be called if there's too much information to process above
	coroutine.wrap(load)(player)
end

game:BindToClose(function()
	if not RunService:IsStudio() then
		for _,player in ipairs(Players:GetPlayers()) do
			coroutine.wrap(save)(player)
		end
	end
end)
#66

i made a brand new game image

#67

should i use that?:thinking: .

#68

It’s up to you but I do recommend to use it since it provides data-store retries however this Instance based DataStore does not have session locking which means if you want to save tools you may get item duplication issues, that’s why I recommend using ProfileService.

#69

ah right do i have to put the script on a local script?

#70

Data-Store calls will only work in ServerScripts.

#71

ok so thats right hmmm if you want i can show you the whole script

#72

like the problems im haveing ingame

#73

Which data store code are you currently using? the first code I provided should work fine when loading and saving data.

#74

At the BindToClose function, save the user’s data. That might be why.

#75

game.Players.PlayerRemoving:Connect(function(player)
local Coins = player.leaderstats.Coins
local ok, result = pcall(DataStore.SetAsync, DataStore, player.UserId, Coins.Value)

if ok then -- if we successfully saved the data
	warn("data has been saved")
#76

Yes as MrAz19485 said it is necessary to use BindToClose to save data in studio because the PlayerRemoving event often fails but you can also destroy the player object through server perspective and it will instantly save.

#77

this one?
game:BindToClose(function()
for _,player in ipairs(game.Players:GetPlayers()) do
coroutine.wrap(function()
local Coins = player.leaderstats.Coins
pcall(DataStore.SetAsync, DataStore, player.UserId, Coins.Value) – we don’t need to check there because its pointless (not in studio).
end)
end
end)

1 Like
#78

I pretty sure this code should load and save: Money wont save - #36 by LiamKyd

#79

i have that in the game and it is not functioning watch image image