My first creator store models! (Feedback!)

Help and Feedback Creations Feedback
,
#1

Hello devs,

I’ve made my first models on the creator store. Well, it isn’t models just scripts. But I think it would be very helpful for someone who wants to learn the gist of scripting. You can get the first one here. The second one here. I would like some feedback and just overall how helpful this could be to someone who is learning scripting and wants something like this in their game.

Thanks in advance! You can use these in your games!

P.S. - If you could give it a like and favorite as well as a positive review, that would be helpful as well!!! :slight_smile:

3 Likes
#2

Very strange… I see link clicks but no feedback? :frowning:

#3

I like it I think it would be helpful to anyone new who wants to learn the gist of scripting. But I think you should be more specific about where to place the local script. Because I think for someone new who wants to learn scripting it may be a little confusing where to actually place the script.

1 Like
#4

I already have the instructions inside the script, but I changed the script name to include where it should be placed! Thanks for the feedback! :slight_smile:

1 Like
#5

Anybody else?

characters

#6

The first script is okay, except you kinda have a memory leak. When the tool is deleted, the screen gui isn’t destroyed, so it just takes up memory for no reason.

Add this to fix it:

tool.Destroying:Connect(function()
   screenGui:Destroy()
end)

The second one is okay too. I think it is a little weird that it displays the first item in your backpack aswell, I feel like it should just display the item you have equipped. You can also just use the child parameter of .ChildAdded:

character.ChildAdded:Connect(function(child: Instance)
  if not child:IsA "Tool" then return end
  toolName.Value = child.Name
end)

character.ChildRemoved:Connect(function(child: Instance)
  if not child:IsA "Tool" then return end
  toolName.Value = "None"
end)

and then you can remove the function entirely. Also, ContextActionService.LocalToolEquipped and ContextActionService.LocalToolUnequipped exist. (but only run on the client)

You also don’t need to use :WaitForChild and :FindFirstChild on the backpack and playergui because they will always exist.

Overall a nice first resource. Keep scripting.

1 Like
#7

d