My player won't level up when my xp has reached the requirement to level up

sandermath · December 8, 2022, 5:45pm

Hello Developers!, I have a problem in my level up script!

So the problem is that when I gain xp and reach the requirement my xp just keeps going and my player just wont level up, I’ve tried everything but just can’t seem to fix it.

wait(2)
game:GetService("Players").PlayerAdded:Connect(function(plr)
	local LevelStats = plr:WaitForChild("LevelStats")
	local stats = plr:WaitForChild("Stats")
	local level = LevelStats:FindFirstChild("Level")
	local xp = LevelStats:FindFirstChild("XP")
	local req = LevelStats:FindFirstChild("Req")
	local g = stats:FindFirstChild("Gems")
	local o = stats:FindFirstChild("UPo")
	local x = require(game.ReplicatedStorage.Data.EternityNum)
	local ui = game.StarterGui
	local mod = require(game.ReplicatedStorage.Functions.ButtonBoost)
	
	local function levelUp()
		level.Value += 1
		xp.Value = 0
		req.Value *= 2.31
	end
	
	xp.Changed:Connect(function()
		if xp.Value >= req.Value then
			levelUp()
		end
	end)
	
	while wait(60) do
		local mul = stats:FindFirstChild("Gs").Value
		mul = x.bnumtostr(x.add(1, o.Value))
		local GemsPerMinute = stats:FindFirstChild("GemsPM").Value
		GemsPerMinute = x.bnumtostr(x.mul(25, mul))
		
		print(mul .. "x")
		print(GemsPerMinute .. "/m")
		
		g.Value = x.bnumtostr(x.add(g.Value, GemsPerMinute))
	end
end)

Please help me with this. don’t be afraid to ask for more information

Minhseu123 · December 8, 2022, 5:54pm

Can I see the whole script please?

sandermath · December 8, 2022, 5:55pm

here i wrote the script for you

Minhseu123 · December 8, 2022, 6:18pm

I think I found some problems. Try this.

game:GetService("Players").PlayerAdded:Connect(function(plr)
	local LevelStats = plr:WaitForChild("LevelStats")
	local stats = plr:WaitForChild("Stats")
	local level = LevelStats:FindFirstChild("Level")
	local xp = LevelStats:FindFirstChild("XP")
	local req = LevelStats:FindFirstChild("Req")
	local g = stats:FindFirstChild("Gems")
	local o = stats:FindFirstChild("UPo")
	local x = require(game.ReplicatedStorage.Data.EternityNum)
	local ui = game.StarterGui
	local mod = require(game.ReplicatedStorage.Functions.ButtonBoost)
	
	local function levelUp()
		level.Value += 1
		xp.Value = 0
		req.Value *= 2.31
	end

 
   xp:GetPropertyChangedSignal("Value"):Connect(function()
		if xp.Value >= req.Value then
			levelUp()
		end
	end)
	
	while wait(60) do
		local mul = stats:FindFirstChild("Gs")
		mul.Value = x.bnumtostr(x.add(1, o.Value))
		local GemsPerMinute = stats:FindFirstChild("GemsPM")
		GemsPerMinute.Value = x.bnumtostr(x.mul(25, mul))
		
		print(mul.Value .. "x")
		print(GemsPerMinute.Value .. "/m")
		
		g.Value = x.bnumtostr(x.add(g.Value, GemsPerMinute))
	end
end)

Minhseu123 · December 8, 2022, 6:20pm

The problems is you put wait(2) so .PlayerAdded will be late to fire because the player joined the game while waiting 2 second.

sandermath · December 8, 2022, 6:28pm

new problem, my level goes up even tho my xp isnt more or the same value as the requirement

sandermath · December 8, 2022, 6:29pm

the xp goes up by 5 when pressing the button

iVlados · December 8, 2022, 6:43pm

Try not to put the whole values and a while wait() loop inside a PlayerAdded event, it usually doesn’t run twice from what I know.

Instead, try:

Creating a RemoteEvent inside ReplicatedStorage
Name it “PlayerAdded”

local event = game:GetService("ReplicatedStorage"):WaitForChild("PlayerAdded")
game:GetService("Players").PlayerAdded:Connect(function(plr)

event:FireClient(plr)

end)

Then again on the client you can make a script with all the content.
I see you have a while wait() loop for the XP, you can make a ServerScript inside of your current script and set it’s .Enabled property to “True” whenever you want to start gaining XP, then you can set it to false anytime from the Server.
Although you have to get all these values from the Player, which requires client scripts, then pass them onto the server script.
Then when it’s time to level up, fire another RemoteEvent on the server that changes the value of the player’s level, and setting the XP = 0.

Changing these values on the client will have no effect, so you always have to fire back at the server.

Minhseu123 · December 8, 2022, 6:43pm

Can i see where a part is touched and your xp start growing?

sandermath · December 8, 2022, 6:46pm

can i link this event with my other player added event?

iVlados · December 8, 2022, 6:50pm

Yes, you can.

I hope I explained everything right for you and if this works, don’t forget to mark it as solution

sandermath · December 8, 2022, 6:50pm

--//Settings\\--
local x = require(game.ReplicatedStorage.Data.EternityNum)
local mod = require(game.ReplicatedStorage.Functions.ButtonBoost)
local config = script.Parent.config
local boostText = config.Boost
local isOn = workspace.isOn

--//Region3 Stuff\\--
local Button = script.Parent
local region3 = Region3.new(Button.Position	- (Button.Size/2) , Button.Position + (Button.Size/2))
local part = Instance.new("Part")
part.Anchored = true
part.Size = region3.Size
part.CanCollide = false
part.Transparency = 1
part.CFrame = region3.CFrame + Vector3.new(0,.075,0)
part.Parent = script.Parent -- Parent your instance at the last

--//Changing Billboard\\--
local bbg = script.Parent:FindFirstChild("Multi")
local config = script.Parent:WaitForChild("config")

bbg:WaitForChild("Cost").Text = "$"..x.short(config:WaitForChild("Cost").Value)
bbg:WaitForChild("Gain").Text = "x"..x.short(config:WaitForChild("Gain").Value).." Multi"
--------------------------

--//Actual Function\\--
while wait(.06) do
    local PartsInRegion = workspace:FindPartsInRegion3(region3,part, 1000)
    for i,v in pairs(PartsInRegion) do
        if v.Parent:FindFirstChild("Humanoid") then

            local char = v.Parent
            local plr = game.Players:GetPlayerFromCharacter(char)

			local cost = script.Parent.config.Cost.Value
            local success, error = pcall(function()
                local StatToGain = x.convert(plr:WaitForChild("Stats"):WaitForChild("Multi").Value)
                local StatToCost = x.convert(plr:WaitForChild("Stats"):WaitForChild("Cash").Value)
                if x.meeq(StatToCost,cost) then
                    local gain = script.Parent.config.Gain.Value
                    StatToCost = x.sub(StatToCost,cost)
                    plr:WaitForChild("Stats"):WaitForChild("Cash").Value = x.bnumtostr(StatToCost)

                    --Boosting--
                    for i , v in pairs(mod.MultiBoostStats) do
                        local stat = plr.Stats:FindFirstChild(v)
                        if x.me(x.convert(stat.Value), "0") then
                            local boost = x.mul(x.convert(stat.Value), x.convert(mod.MultiBoostStatsFactors[i]))
                            gain = x.mul(gain, boost)
                        end
					end
					
					boostText = x.bnumtostr(gain)
                    ------------

                    --Gain Portion--
					plr:WaitForChild("Stats"):WaitForChild("Multi").Value = x.bnumtostr(x.add(StatToGain,gain))
					plr:WaitForChild("LevelStats"):WaitForChild("XP").Value += 5
				end
			end)
		end
	end
end

sandermath · December 8, 2022, 6:56pm

local pa = game.ReplicatedStorage.PlayerAdded
local lu = game.ReplicatedStorage.LeveledUp

pa.OnClientEvent:Connect(function(plr)
	local LevelStats = plr:WaitForChild("LevelStats")
	local stats = plr:WaitForChild("Stats")
	local level = LevelStats:FindFirstChild("Level")
	local xp = LevelStats:FindFirstChild("XP")
	local req = LevelStats:FindFirstChild("Req")
	local g = stats:FindFirstChild("Gems")
	local o = stats:FindFirstChild("UPo")
	local x = require(game.ReplicatedStorage.Data.EternityNum)
	local ui = game.StarterGui
	local mod = require(game.ReplicatedStorage.Functions.ButtonBoost)
	
	xp.GetPropertyChangedSignal:Connect(function()
		if xp.Value >= req.Value then
			lu:FireServer(plr)
		end
	end)

	while wait(60) do
		local mul = stats:FindFirstChild("Gs")
		mul.Value = x.bnumtostr(x.add(1, o.Value))
		local GemsPerMinute = stats:FindFirstChild("GemsPM")
		GemsPerMinute.Value = x.bnumtostr(x.mul(25, mul))

		print(mul.Value .. "x")
		print(GemsPerMinute.Value .. "/m")

		g.Value = x.bnumtostr(x.add(g.Value, GemsPerMinute))
	end
end)

does this look correct?

sandermath · December 8, 2022, 6:56pm

local lu = game.ReplicatedStorage.LeveledUp

lu.OnClientEvent:Connect(function(plr)
	plr:WaitForChild("LevelStats"):FindFirstChild("Level").Value += 1
end)

sandermath · December 8, 2022, 6:58pm

it dont seem to work, it dont level up again.

sandermath · December 8, 2022, 6:59pm

and the while wait function is boosting for gems

iVlados · December 8, 2022, 7:04pm

Unfortunately, NO values can be changed on the client, so you have to fire a Remote everytime.
Here is the script that should work:

local pa = game.ReplicatedStorage.PlayerAdded
local lu = game.ReplicatedStorage.LeveledUp
local main_value_event = game.ReplicatedStorage.MultiplierEvent

pa.OnClientEvent:Connect(function(plr)
	local LevelStats = plr:WaitForChild("LevelStats")
	local stats = plr:WaitForChild("Stats")
	local level = LevelStats:FindFirstChild("Level")
	local xp = LevelStats:FindFirstChild("XP")
	local req = LevelStats:FindFirstChild("Req")
	local g = stats:FindFirstChild("Gems")
	local o = stats:FindFirstChild("UPo")
	local x = require(game.ReplicatedStorage.Data.EternityNum)
	local ui = game.StarterGui
	local mod = require(game.ReplicatedStorage.Functions.ButtonBoost)
	
	xp.GetPropertyChangedSignal:Connect(function()
		if xp.Value >= req.Value then
			lu:FireServer(plr)
		end
	end)

	while wait(60) do
		
                local _mult = x.bnumtostr(x.add(1, o.Value))
                
		
                local gems_per_min =  x.bnumtostr(x.mul(25, mul))

                
		print(mul.Value .. "x")
		print(GemsPerMinute.Value .. "/m")

		local _gval = x.bnumtostr(x.add(g.Value, GemsPerMinute))
               main_value_event:FireServer(plr, _mult, gems_per_min, _gval)
	end
end)

Script in ServerScriptService

local main_value_event = game.ReplicatedStorage.MultiplierEvent

main_value_event.OnServerEvent:Connect(function(plr, mul, gems, g)
local LevelStats = plr:WaitForChild("LevelStats")
	local stats = plr:WaitForChild("Stats")
	local level = LevelStats:FindFirstChild("Level")
	local xp = LevelStats:FindFirstChild("XP")
	local req = LevelStats:FindFirstChild("Req")
	local g = stats:FindFirstChild("Gems")
	local o = stats:FindFirstChild("UPo")
	local x = require(game.ReplicatedStorage.Data.EternityNum)
	local ui = game.StarterGui
	local mod = require(game.ReplicatedStorage.Functions.ButtonBoost)

        local GemsPerMinute = stats:FindFirstChild("GemsPM")
        local mul = stats:FindFirstChild("Gs")

        mul.Value = mul
        GemsPerMinute.Value = gems
        g.Value = g

end)

As you can see, I’ve created placeholder variables that pass with the remotevent onto the server where the actual values can be changed to them.

sandermath · December 8, 2022, 7:26pm

ty, and thanks for trying Minh

system · December 22, 2022, 7:26pm

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.