My Save Tool Script Is Erroring

Help and Feedback Scripting Support
, , ,
#1

Hello, my save tool script is not working, and I was wondering if anyone could help me fix it, there is one error (screenshot below) and I need help fixing that, so here is my code and error.

local dss = game:GetService("DataStoreService")

local toolsDS = dss:GetDataStore("ToolsData")

local toolsFolder = game.ReplicatedStorage.ToolsFolder

local function AddPlayer(plr)
	
	local toolsSaved = toolsDS:GetAsync(plr.UserId .. "-tools") or {}
	
	print("This line should at least work")
	local Data

	local success, whoops = pcall(function()
		Data = toolsDS:GetAsync(plr.UserId .. "-tools") or {}
	end)

	if success and Data then
		for i, toolSaved in pairs(toolsSaved) do

			if toolsFolder:FindFirstChild(toolSaved) then 

				toolsFolder[toolSaved]:Clone().Parent = plr.Backpack
				toolsFolder[toolSaved]:Clone().Parent = plr.StarterGear 
			end
		end
	else
		warn("Something happened while obtaining to get the Player's Data: ", whoops)
	end

	plr.CharacterRemoving:Connect(function(char)

		char.Humanoid:UnequipTools()
		local tableOfTools = {}
		for i, v in pairs(plr.Backpack:GetChildren()) do
			table.Insert(tableOfitems,v.Name,#tableOfitems+1)
		end 

		local success, whoops = pcall(function()
			toolsDS:SetAsync(plr.UserId .. "-tools", tableOfTools)
		end)

		if success then
			print("Data saved successfully!")
		else 
			warn(whoops)
		end

	end)
end

game.Players.PlayerAdded:Connect(AddPlayer)

for _, Plr in pairs(game.Players:GetPlayers()) do
	AddPlayer(Plr)
end

image
image1609Ă—37 3.17 KB

#2

You never declared tableOfItems, so it errors when you try to get the length of it.

1 Like
#3

What Should I declare tableofitems as then?

#4

From looking at your script, it looks like you meant to use tableOfTools?

#5

I tried that and it did not work.

#6

I just saw the output box and it says attempt to call a nil value on line 36

#7

table.Insert should be lowercase.

#8

I am now getting this error about the table.insert

image
image1938Ă—34 3.21 KB

#9

Get rid of the 3rd argument in table.insert

1 Like
#10

Would that be the +1 or the name or what would it be

#11

When you do not put in the 3rd argument of table.insert, it will automatically add it to the “end” of the table (so +1).

“Appends the provided value to the end of array t. The optional pos value defaults to #t+1, meaning that value is inserted at the end of array t unless otherwise specified.”

#12

Should I keep the # at the beginning of the second tableoftools

#13

What part of the code are you talking about? Do you mean this:

#14

Yes I do mean that part of code.

#15

First off, you need to make it a lowercase “I” instead. Also, you can instead just do this:

for i, v in pairs(plr.Backpack:GetChildren()) do
	  table.insert(tableOfTools, v.Name)
end

Edit: You should save on PlayerRemoving instead.

#16

There was no errors, however the saved data successfully did not print

or i, v in pairs(plr.Backpack:GetChildren()) do
			table.insert(tableOfTools, v.Name)
		end 

		local success, whoops = pcall(function()
			toolsDS:SetAsync(plr.UserId .. "-tools", tableOfTools)
		end)

		if success then
			print("Data saved successfully!")
		else 
			warn(whoops)
		end

Edit: The Warn Statement did also not print

#17

You should save data in PlayerRemoving instead. Also, you should not be saving tools from the Backpack. I would recommend storing the tool information in a table instead.

#18

Sorry to keep asking, but i’m new to datastores and I don’t quite get the full concept so I was wondering if I could get an example please.