My script suddenly stopped working?

Help and Feedback Scripting Support
, ,
#1

So before the audio update, my script was working fine. I woke up the next day to it literally not working at all, as well as no errors of the script coming up?
My Script:

--// Index Variables \\--
local Penguins = game.Workspace.Penguins:GetChildren()
local Player = game.Players.LocalPlayer
local Max = #Penguins
local Button = script.Parent.Sample.Penguin:Clone()
local Index = script.Parent
local SC = Index.Holder
local GridLayout = SC.UIGridLayout
local Math = math.ceil(Max/10)
local Number = 0
local Counts = Index.Count

Index.Sample.Penguin:Destroy()

--// Functions \\--
local function Sort(Order)
	SC.UIGridLayout.SortOrder = Order
	SC.UIGridLayout:ApplyLayout()
	wait(0.5)
end

-- Using 1 For Now
local function Count(Collected,Total)
	Counts.Text = Collected .. "/" .. Total
end

local function Color(Clone,StrokeColor,NormalColor)
	Clone.Rarity.UIStroke.Color = StrokeColor
	Clone.Rarity.BackgroundColor3 = NormalColor
	Clone.Rarity.Title.UIStroke.Color = StrokeColor
	Clone.UIStroke.Color = StrokeColor
end

--// Main \\--
for i = 1, Max, 1 do
	local Clone = Button:Clone()
	Clone.Visible = true
	Clone.Parent = SC
	Clone.Name = Penguins[i].Values.PName.Value
	Clone.Penguin.Image = 'rbxassetid://' .. Penguins[i].Values.PIcon.Value
	Clone.Rarity.Title.Text = Penguins[i].Values.PDiff.Value
	Clone.Hint.Value = Penguins[i].Values.PHint.Value
	Clone.Difficulty.Value = Penguins[i].Values.PDiff.Value
	Clone.Stars.Value = Penguins[i].Values.PStars.Value
	Clone.LayoutOrder = Penguins[i].Values.SortOrders.Value
	Number += 1
	
	if Clone.Difficulty.Value == "Common" then
		Color(Clone,Color3.new(0.615686, 0.615686, 0.615686),Color3.new(1, 1, 1))
	else if Clone.Difficulty.Value == "UnCommon" then
			Color(Clone,Color3.new(0.301961, 0.301961, 0.301961),Color3.new(0.584314, 0.584314, 0.584314))
	else if Clone.Difficulty.Value == "Rare" then
			Color(Clone,Color3.new(0.615686, 0, 0),Color3.new(1, 0.435294, 0.435294))
		else if Clone.Difficulty.Value == "Legendary" then
					Color(Clone,Color3.new(0.639216, 0.592157, 1),Color3.new(0.72549, 0.564706, 1))
				end
			end
		end
	end
	
	game.Players.LocalPlayer:WaitForChild("PenguinsIndex").ChildAdded:Connect(function(Object)
		if Object.Name == Clone.Name then
			Clone.BackgroundColor3 = Color3.new(0.333333, 1, 0.498039)
			Clone.Check.Visible = true
		end
	end)
	
	Clone.MouseButton1Click:Connect(function()
		-- Sends Data For The Information
		local Player = game:GetService("Players").LocalPlayer
		local Name = Clone.Name
		local DifficultLvl = Clone.Difficulty.Value
		local Image = Clone.Penguin.Image
		local Hint = Clone.Hint.Value
		local Stars = Clone.Stars.Value

		if Player then
			if Hint ~= "" then
				game:GetService("ReplicatedStorage").Remotes.IndexData:FireServer(Name,Image,DifficultLvl,Hint,Stars)
			end
		end
	end)
end

SC.CanvasSize = UDim2.new(0,0,2*Math,0)

Sort(Enum.SortOrder.LayoutOrder)
while wait() do
Count(Player.leaderstats.Penguins.Value, Number)
end

print("The Total Number Of Penguins Are " .. Number)

Basically, Its supposed to make an index of every penguin in a folder in workspace. Again I’m not getting any errors in my output tab, but its not working at all like its supposed to.
Any help would be apprecitated
Thanks

1 Like
#2

I think the audio update did that you make your own sound sadly :frowning_face:

#3

At least it’s now free to upload audio. But yeah, we still have to cope with that update…

#4

But how?? There isnt anything audio related with this script and all the audios that were affected were then reuploaded in the group.

Edit:
Ive checked it out again. The for loop in the script isnt running at all for some reason

#5

Hmm, you have to rewrite script then or let me see.

#6

If you are using a LocalScript I recommend using WaitForChild because sometimes the LocalScript would load before the character and you get errors and don’t use while wait() it sucks for looping use RunService.

1 Like
#7

I think I know, Penguins hasn’t loaded when you referenced it. Try putting something like wait(5), so you can check if that helps. Let me know if it works.

#8

Nope nothing. The problem is with the for loop. Its not running at all even when printing something inside of it. The parts outside the for loop run.

#9

Uhm. The script is working completely fine in a new game? Is it just the experiences fault or…

1 Like
#10

It wasn’t running because the table was nil?

#11

No, there were things in the folder. I even added a wait to make it load. Jus to be sure, i went to a new baseplate and copy pasted the same exact script with the same folder, and everything worked fine.

#12

I guess the folder hasn’t loaded because there was a lot of other stuff in the game. Moving it to a baseplate made it load faster.

#13 
--// Index Variables \\--
local Penguins = game.Workspace.Penguins
local Player = game.Players.LocalPlayer
local Max = #Penguins
local Button = script.Parent.Sample.Penguin:Clone()
local Index = script.Parent
local SC = Index.Holder
local GridLayout = SC.UIGridLayout
local Math = math.ceil(Max/10)
local Number = 0
local Counts = Index.Count

Index.Sample.Penguin:Destroy()

--// Functions \\--
local function Sort(Order)
	SC.UIGridLayout.SortOrder = Order
	SC.UIGridLayout:ApplyLayout()
	wait(0.5)
end

-- Using 1 For Now
local function Count(Collected,Total)
	Counts.Text = Collected .. "/" .. Total
end

local function Color(Clone,StrokeColor,NormalColor)
	Clone.Rarity.UIStroke.Color = StrokeColor
	Clone.Rarity.BackgroundColor3 = NormalColor
	Clone.Rarity.Title.UIStroke.Color = StrokeColor
	Clone.UIStroke.Color = StrokeColor
end

--// Main \\--
for i = 1, #Penguins:GetChildren(), 1 do
	local Clone = Button:Clone()
	Clone.Visible = true
	Clone.Parent = SC
	Clone.Name = Penguins[i].Values.PName.Value
	Clone.Penguin.Image = 'rbxassetid://' .. Penguins[i].Values.PIcon.Value
	Clone.Rarity.Title.Text = Penguins[i].Values.PDiff.Value
	Clone.Hint.Value = Penguins[i].Values.PHint.Value
	Clone.Difficulty.Value = Penguins[i].Values.PDiff.Value
	Clone.Stars.Value = Penguins[i].Values.PStars.Value
	Clone.LayoutOrder = Penguins[i].Values.SortOrders.Value
	Number += 1
	
	if Clone.Difficulty.Value == "Common" then
		Color(Clone,Color3.new(0.615686, 0.615686, 0.615686),Color3.new(1, 1, 1))
	else if Clone.Difficulty.Value == "UnCommon" then
			Color(Clone,Color3.new(0.301961, 0.301961, 0.301961),Color3.new(0.584314, 0.584314, 0.584314))
	else if Clone.Difficulty.Value == "Rare" then
			Color(Clone,Color3.new(0.615686, 0, 0),Color3.new(1, 0.435294, 0.435294))
		else if Clone.Difficulty.Value == "Legendary" then
					Color(Clone,Color3.new(0.639216, 0.592157, 1),Color3.new(0.72549, 0.564706, 1))
				end
			end
		end
	end
	
	game.Players.LocalPlayer:WaitForChild("PenguinsIndex").ChildAdded:Connect(function(Object)
		if Object.Name == Clone.Name then
			Clone.BackgroundColor3 = Color3.new(0.333333, 1, 0.498039)
			Clone.Check.Visible = true
		end
	end)
	
	Clone.MouseButton1Click:Connect(function()
		-- Sends Data For The Information
		local Player = game:GetService("Players").LocalPlayer
		local Name = Clone.Name
		local DifficultLvl = Clone.Difficulty.Value
		local Image = Clone.Penguin.Image
		local Hint = Clone.Hint.Value
		local Stars = Clone.Stars.Value

		if Player then
			if Hint ~= "" then
				game:GetService("ReplicatedStorage").Remotes.IndexData:FireServer(Name,Image,DifficultLvl,Hint,Stars)
			end
		end
	end)
end

SC.CanvasSize = UDim2.new(0,0,2*Math,0)

Sort(Enum.SortOrder.LayoutOrder)
while wait() do
Count(Player.leaderstats.Penguins.Value, Number)
end

print("The Total Number Of Penguins Are " .. Number)

This code should work

#14

Have you checked for any backdoors in your game?
If you haven’t, use a plug-in called server defender

#15

Attempt to index a nil value on the Penguins:GetChildren() [Prob since getchildren is already called on the variable.]

#16

I dont think there are any backdoors in the game. However i will check just in case.

#17

Penguins does not exist according to the script. Try WaitForChild ()

#18

Nope, still dosent work, i added a waitforchild as well

#19

Are there any errors or warnings in the output?

#20

I specifed above, there isnt any errors occuring in the output tab.