Need help making a light switch

Help and Feedback Scripting Support
, , ,
#1

I want to make a light switch for a room in my friend’s place.

The script I am using (tried to make my own) is not working.

Here's the script I am using 
local lights = true
local ClickDetector = script.Parent.ClickDetector
local ne = Enum.Material.Neon
local gl = Enum.Material.Glass
	
function onMouseClick()
	if lights == true then
		lights = true
		script.Parent.Parent.Parent.LightA.LptA.SpotLight.Enabled = true
		script.Parent.Parent.Parent.LightA.Neon1.Material = ne
		script.Parent.Parent.Parent.LightA.Neon2.Material = ne
		script.Parent.Parent.Parent.LightB.LptB.SpotLight.Enabled = true
		script.Parent.Parent.Parent.LightB.Neon3.Material = ne
		script.Parent.Parent.Parent.LightB.Neon4.Material = ne
	else
		lights = false
		script.Parent.Parent.Parent.LightA.LptA.SpotLight.Enabled = false
		script.Parent.Parent.Parent.LightA.Neon1.Material = gl
		script.Parent.Parent.Parent.LightA.Neon2.Material = gl
		script.Parent.Parent.Parent.LightB.LptB.SpotLight.Enabled = false
		script.Parent.Parent.Parent.LightB.Neon3.Material = gl
		script.Parent.Parent.Parent.LightB.Neon4.Material = gl
	end
end

ClickDetector.MouseClick:connect(onMouseClick)
See attatchements for results of the script

No errors in Output after clicking.

image
image1655×463 23.7 KB

Video of me clicking the button, nothing happening

Here’s the place file containing only the room.
room.rbxl (96.1 KB)

Any help is appreciated. thank you. I am not good at coding lol

1 Like
#3

You can fix this by changing line 8 to lights = false and line 16 to lights = true

#4

I guess “local lights = true” works as a switch, in the statment “if lights == true then” you are not switching the “lights” to false, you are making it true again. change the bool value in the line 8 to “lights = false” and in the line 16 to “lights = true”.

Here is your script fixed:

local lights = true
local ClickDetector = script.Parent.ClickDetector
local ne = Enum.Material.Neon
local gl = Enum.Material.Glass
	
function onMouseClick()
	if lights == false then ---> I change this value
		lights = true
		script.Parent.Parent.Parent.LightA.LptA.SpotLight.Enabled = true
		script.Parent.Parent.Parent.LightA.Neon1.Material = ne
		script.Parent.Parent.Parent.LightA.Neon2.Material = ne
		script.Parent.Parent.Parent.LightB.LptB.SpotLight.Enabled = true
		script.Parent.Parent.Parent.LightB.Neon3.Material = ne
		script.Parent.Parent.Parent.LightB.Neon4.Material = ne
	elseif lights == true then ---> I change this value
		lights = false 
		script.Parent.Parent.Parent.LightA.LptA.SpotLight.Enabled = false
		script.Parent.Parent.Parent.LightA.Neon1.Material = gl
		script.Parent.Parent.Parent.LightA.Neon2.Material = gl
		script.Parent.Parent.Parent.LightB.LptB.SpotLight.Enabled = false
		script.Parent.Parent.Parent.LightB.Neon3.Material = gl
		script.Parent.Parent.Parent.LightB.Neon4.Material = gl
	end
end

ClickDetector.MouseClick:connect(onMouseClick)
1 Like
#5

You forgot the ClickDetector.MouseClick:connect(onMouseClick) at the end. After adding it myself, it works. thanks!

1 Like
#6

you’re turning on the lights if the variable ‘lights’ is true. you are setting it to true again even though it is true.

in your else statement, what you’re basically doing is checking if the lights are off, and if they are off, then it turns off the lights.

local ne = Enum.Material.Neon
local gl = Enum.Material.Glass

function onMouseClick()
	if lights == false then
		lights = true
		script.Parent.Parent.Parent.LightA.LptA.SpotLight.Enabled = true
		script.Parent.Parent.Parent.LightA.Neon1.Material = ne
		script.Parent.Parent.Parent.LightA.Neon2.Material = ne
		script.Parent.Parent.Parent.LightB.LptB.SpotLight.Enabled = true
		script.Parent.Parent.Parent.LightB.Neon3.Material = ne
		script.Parent.Parent.Parent.LightB.Neon4.Material = ne
	else
		lights = false
		script.Parent.Parent.Parent.LightA.LptA.SpotLight.Enabled = false
		script.Parent.Parent.Parent.LightA.Neon1.Material = gl
		script.Parent.Parent.Parent.LightA.Neon2.Material = gl
		script.Parent.Parent.Parent.LightB.LptB.SpotLight.Enabled = false
		script.Parent.Parent.Parent.LightB.Neon3.Material = gl
		script.Parent.Parent.Parent.LightB.Neon4.Material = gl
	end
end

ClickDetector.MouseClick:connect(onMouseClick)

the above script should work.

edit: I just realized you already fixed it as I was writing this post lol

#7

yeah sorry abt that i shoulda waited a sec