Need help on proximity prompt and tool

iiheavenlymarsx · July 15, 2023, 9:10am

Hi, so this code won’t work when I equip a tool, and use the proximity prompt, it doesn’t do the thing it’s supposed to do. I think there’s a problem with the “local ToolEquipped = Player.Character and Player.Character:FindFirstChildOfClass(“Tool”)” however I’m not sure, as you already saw the script is running in LocalScript, and the scripts parent is a Proximity Prompt.

script.Parent.Triggered:Connect(function()
	local Player = game.Players.LocalPlayer
	local ToolEquipped = Player.Character and Player.Character:FindFirstChildOfClass("Tool")

	if ToolEquipped then
		local toolName = ToolEquipped.Name

		if toolName == "Cake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cake Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Cookie Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cookie Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Cupcake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cupcake Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Mochi Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Mochi Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Muffin Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Muffin Dough"]:Clone()
			Clone.Parent = Player.Backpack
		end
	end
end)

Deb0rahAliWilliams · July 15, 2023, 9:21am

LocalScripts will not work in the Workspace. Replace the current script with an ServerScript instead.

Add a parameter for the Player when the ProximityPrompt gets triggered. This will directly point to the Player who triggered the ProximityPrompt.

script.Parent.Triggered:Connect(function(player)
-- code here

iiheavenlymarsx · July 15, 2023, 9:23am

Doesn’t work,

script.Parent.Triggered:Connect(function(Player)
	local ToolEquipped = Player.Character and Player.Character:FindFirstChildOfClass("Tool")

	if ToolEquipped then
		local toolName = ToolEquipped.Name

		if toolName == "Cake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cake Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Cookie Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cookie Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Cupcake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cupcake Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Mochi Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Mochi Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Muffin Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Muffin Dough"]:Clone()
			Clone.Parent = Player.Backpack
		end
	end
end)```

I added the script into a Serverside one, not a client one.

Deb0rahAliWilliams · July 15, 2023, 9:26am

Remove Player.Character in the code, and keep only Player.Character:FindFirstChildOfClass(“Tool”) for the ToolEquipped variable.

Player.Character is simply pointing to the Player’s Character, which isn’t a tool itself, and would not make the script work as intended.

iiheavenlymarsx · July 15, 2023, 9:29am

Makes an error of Workspace.Dif.ProximityPrompt.Script:3: attempt to index nil with ‘Character’

iiheavenlymarsx · July 15, 2023, 9:29am

Wait, my bad I forgot to remove something. Ignore what I said earlier.

iiheavenlymarsx · July 15, 2023, 9:30am

Still doesn’t work. It doesn’t error anything, weird.

script.Parent.Triggered:Connect(function(Player)
	local ToolEquipped = Player.Character:FindFirstChildOfClass("Tool")

	if ToolEquipped then
		local toolName = ToolEquipped.Name

		if toolName == "Cake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cake Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Cookie Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cookie Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Cupcake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cupcake Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Mochi Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Mochi Dough"]:Clone()
			Clone.Parent = Player.Backpack

		elseif toolName == "Muffin Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Muffin Dough"]:Clone()
			Clone.Parent = Player.Backpack
		end
	end
end)

ThanksRoBama · July 15, 2023, 9:31am

If you think that part might be the issue, then try using the debugger and Watch window to inspect variables and control flow as the program executes one line at a time.

iiheavenlymarsx · July 15, 2023, 9:33am

It’s probably with the if toolEquipped then etc, I tried this script below but it only printed working once:

script.Parent.Triggered:Connect(function(Player)
	local ToolEquipped = Player.Character:FindFirstChildOfClass("Tool")
	print("working!")

	if ToolEquipped then
		local toolName = ToolEquipped.Name
		print("working!")

		if toolName == "Cake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cake Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Cookie Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cookie Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Cupcake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cupcake Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Mochi Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Mochi Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Muffin Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Muffin Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")
		end
	end
end)

Deb0rahAliWilliams · July 15, 2023, 9:40am

I don’t seem to see anything wrong with the script. Could you send a screenshot of where the Script is located in the game’s Explorer?

iiheavenlymarsx · July 15, 2023, 11:15am

Here.

Deb0rahAliWilliams · July 15, 2023, 11:16am

Like I said before, you need to change this to a ServerScript instead of a LocalScript.

LocalScripts don’t work in the Workspace, so keep that in mind.

iiheavenlymarsx · July 15, 2023, 11:17am

Do I use the same script?

script.Parent.Triggered:Connect(function(Player)
	local ToolEquipped = Player.Character:FindFirstChildOfClass("Tool")
	print("working!")

	if ToolEquipped then
		local toolName = ToolEquipped.Name
		print("working!")

		if toolName == "Cake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cake Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Cookie Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cookie Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Cupcake Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Cupcake Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Mochi Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Mochi Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")

		elseif toolName == "Muffin Dough" then
			ToolEquipped:Destroy()
			local Clone = game.ServerStorage["Rolled Muffin Dough"]:Clone()
			Clone.Parent = Player.Backpack
			print("working!")
		end
	end
end)

Deb0rahAliWilliams · July 15, 2023, 11:18am

Yep, it will work in the same way!

iiheavenlymarsx · July 15, 2023, 11:19am

Still doesn’t work, it just prints 1 “working” instead of printing multiple ones.

Deb0rahAliWilliams · July 15, 2023, 11:33am

Hm, how about trying to replace FindFirstChildOfClass() with FindFirstChildWhichIsA()?

iiheavenlymarsx · July 15, 2023, 11:39am

Nope still the same like before.

Deb0rahAliWilliams · July 15, 2023, 12:00pm

Okay, let’s try to debug from the name of the ToolEquipped variable.

Can you temporarily remove the code below the first print() function, and just detect if a Player is holding a tool, and try printing the results. Something like:

script.Parent.Triggered:Connect(function(Player)
	local ToolEquipped = Player.Character:FindFirstChildOfClass(“Tool”)
	print(ToolEquipped.Name)
end)

iiheavenlymarsx · July 15, 2023, 12:10pm

Workspace.Dif.ProximityPrompt.Script:3: attempt to index nil with ‘Name’, thats the error. I also have the dough equipped.

Deb0rahAliWilliams · July 15, 2023, 12:12pm

Try to replace:

print(ToolEquipped.Name)

With:

print(ToolEquipped)

See if it changes anything.