Need help with infinite loop

BerkeCavdaroglu · August 7, 2021, 4:56pm

You can write your topic however you want, but you need to answer these questions:

What do you want to achieve? Keep it simple and clear!
I want my fuel gui to close whenever player leaves the area
What is the issue? Include screenshots / videos if possible!

image768×292 13.4 KB

Infinite loop
What solutions have you tried so far? Did you look for solutions on the Developer Hub?
After that, you should include more details if you have any. Try to make your topic as descriptive as possible, so that it’s easier for people to help you!
I tried adding debounce but it didn’t to anything because it says attempt to index nil with playergui

-- This is an example Lua code block

Please do not ask people to write entire scripts or design entire systems for you. If you can’t answer the three questions above, you should probably pick a different category.

Opinality · August 7, 2021, 4:59pm

Question, What do you mean by infinite loop?

maxxswrld · August 7, 2021, 5:00pm

Your issue here is that TouchEnded acts mainly the same as the Touched event, you would most likely need to use Region3 to add players to a table when they are in the region and check every few seconds whether they are still in the Region or not.

If could also elaborate in what you mean by “infinite loop”

BerkeCavdaroglu · August 7, 2021, 5:01pm

D0RYU · August 7, 2021, 5:01pm

I think the problem is that the connection gets made every time the part is touched

making thousands of connections for a TouchEnded

BerkeCavdaroglu · August 7, 2021, 5:02pm

So how could i fix this? Any clues?

script.Parent.Touched:Connect(function(hit2)
	local db = false
	local rs = 2
	script.Parent.TouchEnded:Connect(function(ontouchended)
		local plr = game.Players:GetPlayerFromCharacter(hit2.Parent)
		wait(1)
		if(plr.PlayerGui:FindFirstChild("GiveUI")) then
			db = true
			plr.PlayerGui.GiveUI:Destroy()
			wait(1)
			db = false
			wait(rs)
		end
	end)
end)

code is here

Opinality · August 7, 2021, 5:03pm

script.Parent.TouchEnded:Connect(function(hit)
local player = game.Players:GetPlayerFromCharacter(hit.Parent)
local playerGui = player.PlayerGui

if (playerGui:FindFirstChild("GiveUI")) then
local gui = playerGui:FindFirstChild("GiveUI")
if gui then
gui:Destroy()
end
end
end)

Make sure that this event is not inside another event.

BerkeCavdaroglu · August 7, 2021, 5:04pm

(Script 2)

Opinality · August 7, 2021, 5:04pm

Only make those two events in one script.

D0RYU · August 7, 2021, 5:04pm

if player is nil then this line will error

domboss37 · August 7, 2021, 5:06pm

Opinality:

script.Parent.TouchEnded:Connect(function(hit)
local player = game.Players:GetPlayerFromCharacter(hit.Parent)
local playerGui = player.PlayerGui

if (playerGui:FindFirstChild("GiveUI")) then
local gui = playerGui:FindFirstChild("GiveUI")
if gui then
gui:Destroy()
end
end
end)

Make it this:


script.Parent.TouchEnded:Connect(function(hit)
    local player = game.Players:GetPlayerFromCharacter(hit.Parent)
    if player then
        local playerGui = player.PlayerGui

        if (playerGui:FindFirstChild("GiveUI")) then
            local gui = playerGui:FindFirstChild("GiveUI")
            if gui then
                gui:Destroy()
            end
        end
    end
end)

Opinality · August 7, 2021, 5:07pm

For example, And by the way this is the whole script that you desire. Hope it works!

script.Parent.Touched:Connect(function(hit)
local player = game.Players:GetPlayerFromCharacter(hit.Parent)
local giveUI = (the gui):Clone()
if player:FindFirstChild("GiveUI") then
return nil
else
giveUI.Parent = player.PlayerGui
end
end)
script.Parent.TouchEnded:Connect(function(hit)
local player = game.Players:GetPlayerFromCharacter(hit.Parent)
local playerGui = player.PlayerGui

if (playerGui:FindFirstChild("GiveUI")) then
local gui = playerGui:FindFirstChild("GiveUI")
if gui then
gui:Destroy()
end
end
end)

Opinality · August 7, 2021, 5:08pm

Oh, I forgot. My bad hehe, Let me fix it up!

domboss37 · August 7, 2021, 5:09pm

I added the indentation afterwords in an edit btw

BerkeCavdaroglu · August 7, 2021, 5:09pm

Thanks for whose trying to help me. But i have another thing i think can be considered as loop

D0RYU · August 7, 2021, 5:12pm

you aren’t debouncing properly
also you need to understand what a loop is

your code runs multiple times because you are touching it multiple times

make sure to use debounce in your if statements!

BerkeCavdaroglu · August 7, 2021, 5:15pm

Thanks. I already tried adding debounce == false in the red spot.

and now i added debounce in if(plr) and it works fine i guess… Thanks!

D0RYU · August 7, 2021, 5:17pm

could you send the code, I want to remove some unnecessary code for you

BerkeCavdaroglu · August 7, 2021, 5:17pm

local debounce = false
local reset_secs= 2
script.Parent.Touched:Connect(function(hit)
	local plr = game.Players:GetPlayerFromCharacter(hit.Parent)
	if(plr) and debounce == false then
		if(plr.PlayerGui:FindFirstChild("GiveUI")) then
			wait(15)
			debounce = true
			plr.PlayerGui.GiveUI:Destroy()
			wait(reset_secs)
			debounce = false
		else
			debounce=true
			script.Parent.GiveUI:Clone().Parent = plr.PlayerGui
			wait(reset_secs)
			debounce=false

		end
	end
end)

D0RYU · August 7, 2021, 5:28pm

local debounce = false
local reset_secs = 2

script.Parent.Touched:Connect(function(hit)
	 local plr = game.Players:GetPlayerFromCharacter(hit.Parent)
	 if(plr) and debounce == false then
		debounce = true
		if(plr.PlayerGui:FindFirstChild("GiveUI")) then
			task.wait(15)
			plr.PlayerGui.GiveUI:Destroy()
		else
			script.Parent.GiveUI:Clone().Parent = plr.PlayerGui
		end
		task.wait(reset_secs)
		debounce = false
	end
end)

sorry for the wait, on a train and we were in a tunnel

also I didn’t think you needed that wait(15)