Need Help with Ordered Data Store data.value = nil

Help and Feedback Scripting Support
,
#1

Hi! I was working on a global leaderboard and I can’t figure out why on Line 11:
local Cash = data.value
is passing nil rather than the players Cash value.

Any help is much appreciated :slight_smile:

local WinsLeaderboard = DataStoreService:GetOrderedDataStore("WinsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local CashPage = Data:GetCurrentPage()
		for Rank, data in ipairs(CashPage) do
			local userName = game.Players:GetNameFromUserIdAsync(tonumber(data.key))
			local Name = userName
			local Cash = data.value
			local isOnLeaderboard = false
			for i, v in pairs(game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLeaderboard = true
					break
				end
			end

			if Cash and isOnLeaderboard == false then
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrame"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Cash.Text = Cash
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + (.08 * #game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()), 0)
				newLbFrame.Parent = game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder
			end
		end
	end)

	if not success then
		print(errorMessage)
	end
end

while true do

	for _, player in pairs(game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.UserId, player.leaderstats.Cash.Value)
	end

	for _, frame in pairs(game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
		frame:Destroy()
	end

	updateLeaderboard()
	print("Updated!")

	wait(10)
end
#2 
local userId = data.value
local player = game.Players:GetPlayerByUserId(userId)
local name = player.Name
local cash = player.leaderstats.Wins.Value

Like this would be more easy to do ? with data.Value

#3

image
image849×62 10.9 KB

Getting this error now

#4

Do you change eveything in your script to make this work ?

#5

This is the script now

local DataStoreService = game:GetService("DataStoreService")
local WinsLeaderboard = DataStoreService:GetOrderedDataStore("WinsLeaderboard")

local function updateLeaderboard()
	local success, errorMessage = pcall(function()
		local Data = WinsLeaderboard:GetSortedAsync(false, 5)
		local CashPage = Data:GetCurrentPage()
		for Rank, data in ipairs(CashPage) do
			
			local userId = data.value
			local player = game.Players:GetPlayerByUserId(userId)
			local Name = player.Name
			local Cash = player.leaderstats.Cash.Value
			local isOnLeaderboard = false
			for i, v in pairs(game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
				if v.Player.Text == Name then
					isOnLeaderboard = true
					break
				end
			end

			if Cash and isOnLeaderboard == false then
				local newLbFrame = game.ReplicatedStorage:WaitForChild("LeaderboardFrame"):Clone()
				newLbFrame.Player.Text = Name
				newLbFrame.Cash.Text = Cash
				newLbFrame.Rank.Text = "#"..Rank
				newLbFrame.Position = UDim2.new(0, 0, newLbFrame.Position.Y.Scale + (.08 * #game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()), 0)
				newLbFrame.Parent = game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder
			end
		end
	end)

	if not success then
		print(errorMessage)
	end
end

while true do

	for _, player in pairs(game.Players:GetPlayers()) do
		WinsLeaderboard:SetAsync(player.UserId, player.leaderstats.Cash.Value)
	end

	for _, frame in pairs(game.Workspace.GlobalLeaderboard.LeaderboardGUI.Holder:GetChildren()) do
		frame:Destroy()
	end

	updateLeaderboard()
	print("Updated!")

	wait(10)
end
#6

You use UserId you should use the data.key field to retrieve the player’s user ID or just GetPlayerByUserId

#7

Could you explain more by what you mean, I don’t fully understand.

#8

i don’t know how i can explain more what i mean :huh:

#10

Figured it out with this, thank you.

#11

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.