Number value isn't updating after subtracting in module script

Help and Feedback Scripting Support
#1 
local function SHC(Hum,Result,Shield)
	Shield -= Result

	if Shield > 0 then
		print("SHIELD =",Shield)
	elseif Shield < 0 then
		Hum.Health += Shield
		print("SHIELD =",Shield)
		print("HEALTH =",Hum.Health)
	end
end

--Stats--

--Health Calcuations

module.DAC = function(Hum,Damage,Values) 
	local Shield = Values.Shield.Value
	local Defense = Values.Defense.Value
	local Modifier = Values.DMGModifier.Value
	local Result = Round((Damage - Damage / 100 * Defense) * Modifier)

	if Shield == 0 then
		Hum.Health -= Result
		print("HP DIFF =",Result)
	else
		SHC(Hum,Result,Shield)
	end
end

Module script ^

Negative.Touched:Connect(function(hit)
	if CD == false then
		local Values = hit.Parent:WaitForChild("Handler").Values
		local Char = hit.Parent
		
		module.DAC(Char.Humanoid,25,Values)
		Cooldown()
	end
end)

Script ^

1 Like
#2

Because you’re updating them as a local variable to update then you need to do BlaBlaBla.Value = Shield or nah…

2 Likes
#3

I’ve already tried Shield.Value = Shield - Result. It prints out 25, but it never saves the changes to the server and remains as 50

1 Like
#4

Also, use TakeDamage on a humanoid, not Humanoid.Health =- Result. And about your problem… idk bro, i can’t figure it out!

2 Likes
#5

Yeah, I’ve been at it for an hour or two. BTW, why would I use Humanoid:TakeDamage() ?

#6

Basically, Humanoid.Health -= blabla is the same as TakeDamage(), sooo idk… I’m just more used to TakeDamage().

#7

Probably not worth updating all of my code to use :TakeDamage() instead then

#8

there’s no reason to use it, infact health -= executes faster, but at this little difference, it doesn’t matter at all, use whichever you’d like.
image

2 Likes
#9

Thank you, would you know anything about my problem ?

#10

image
Forgot to post this. Shield is a number value.

#11

You might want to try Shield.Value :slight_smile:

#12

Already have, plus I’ve already got it in the variable
image

#13

Would you be comfortable with sharing a copy of your game? Would make it easier for me to debug

#14

Nope. This is all of the relevant code

1 Like
#15

yeah so when doing

SHC(Hum,Result,Shield)

you are only passing in the shield’s value, not a reference to it, you’d have to pass Values.Shield, and subtract Result from Shield.Value inside ur SHC function

1 Like
#16

that sounds quite plausible… give me a moment

#17

I have already tried this, but for some reason when you mention it, it works lol…
thank you

#18

Bro… Didn’t i answered something similar like that before? :neutral_face::neutral_face::neutral_face:

#19

BlaBlaBla.Value = Shield or nah…

i don’t believe thats a properly reply, also he had to pass in the instance which you didn’t tell him, he would have kept passing in the number and trying to access its Value property

Edit: stop replying to the post, its solved

1 Like
#20

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.