Parent locked sometimes?

Help and Feedback Scripting Support
1

Could anyone tell me why some of my cloned assets arent parenting somtimes? These scripts are supposed to generate 3 blocks yet sometimes it only visibly shows 2 or even 1.

I also got an error once telling me ‘Parent was locked’ but idk how to fix this.

Module script (cropped):

function Round.blockMaker(coords: {string}) --Coord e.g "2 3" ("x y")
	--Creates each tile
	local block = Instance.new("Frame")
	block.Name = "Block"
	block.BackgroundColor3 = Color3.fromRGB(255, 115, 0)
	block.BackgroundTransparency = 1
	
	--Creates block size by calculating maximum boundaries
	local x, y = 0, 0
	for i,coord in pairs(coords) do
		local tX, tY = unpack(string.split(coord, " "))
		tX, tY = tonumber(tX), tonumber(tY)
		
		if tX > x then
			x = tX
		end
		if tY > y then
			y = tY
		end
	end
	block.Size = UDim2.new(0, 120*x, 0, 120*y)
	
	--Creates an adjacent frame for each tile to create a shadow effect
	local shadow = Instance.new("Frame")
	shadow.Size = UDim2.new(1,0,1,0)
	shadow.Name = "Shadow"
	shadow.Position = UDim2.new(0,20,0,20)
	shadow.BackgroundTransparency = 1
	shadow.Parent = block
	
	--Creates a block for each coordinate and clones into the shadow frame and block
	for i, coord in pairs(coords) do
		local tX, tY = unpack(string.split(coord, " "))
		tX, tY = tonumber(tX), tonumber(tY)
		--Creates shadows first
		local miniShadow = Instance.new("Frame")
		miniShadow.Name = coord
		miniShadow.BackgroundColor3 = Color3.fromRGB(0, 0, 0)
		miniShadow.BackgroundTransparency = .75
		miniShadow.Size = UDim2.new(1/x, 0, 1/y, 0)
		miniShadow.Position = UDim2.new((tX-1)/x, 0, (tY-1)/y, 0)
		miniShadow.Parent = shadow
		--Creates Tole
		local tile = miniShadow:Clone()
		tile.BackgroundColor3 = Color3.fromRGB(255, 115, 0)
		tile.BackgroundTransparency = 0
		tile.BorderColor3 = Color3.fromRGB(255, 115, 0)
		tile.BorderSizePixel = 2
		rp.Assets.Shading:Clone().Parent = tile
		tile.Parent = block
	end
	--Adds final touches to block and parents it to block folder
	rp.Assets.UIDragDetector:Clone().Parent = block
	local blockScript = rp.Assets.BlockScript:Clone()
	blockScript.Parent = block
	blockScript.Enabled = true
	block.Parent = rp.Blocks
end

function Round.random(max)
	return math.random(1, max)
end

function Round.generate(plr: Player, number: number?)
	local blockNumber = number or 3
	local max = #game.ReplicatedStorage.Blocks:GetChildren()
	
	local blockTable = {}
	for i, v in pairs(game.ReplicatedStorage.Blocks:GetChildren()) do
		table.insert(blockTable, v)
	end
	
	local blocks = {}
	for i = 1,blockNumber do
		local block = blockTable[Round.random(max)]
		table.insert(blocks, block)
		block.Position = UDim2.new(0,200,0,200*i)
		block.BlockScript.OriginalPos.Value = "0,200,0,"..(200*i)
	end
	rp.Events.GenerateBlocks:FireClient(plr, blocks)
	
    --Irrelevant
	local blocksSplit = {}
	for i,v in pairs(blocks) do
		local blockSplit2 = {}
		for i,c in ipairs(v:GetChildren()) do
			if c.Name ~= "Shadow" and c:IsA("Frame") then
				table.insert(blockSplit2, c.Name)
			end
		end
		table.insert(blocksSplit, blockSplit2)
	end
	return blocksSplit
end

Local script:

local rp = game.ReplicatedStorage
local gameUI = script.Parent.GameUi

rp.Events.GenerateBlocks.OnClientEvent:Connect(function(blocks)
	task.wait()
	for i,block in ipairs(blocks) do
		block.Parent = gameUI.RoundFrame.Blocks
		block.UIDragDetector.BoundingUI = gameUI.RoundFrame
	end
end)
1 Like
2

pls helpppppppppppppppppppppppppppppp.

3

Instead of:

local block = blockTable[Round.random(max)]

you should clone the instance:

local block = blockTable[Round.random(max)]:Clone()

I think the “Parent was locked” error happens in this situation, because the instance is being re-parented at the same time.

2 Likes
4

Lemme test this out
assssssssssssssa

5

this error usually happens if you try to reparent an object after it has been destroyed

6

Thats what i discovered when i googled it but I’m not destroying anything so idk why I’m still getting the error :sob:

7

Does this fix your problem, @Ashtagreunited ?

1 Like
8

No i found the isssue but im struggling to fix it. This line:

#game.ReplicatedStorage.Blocks:GetChildren()

isnt updating even when blocks are being removed (even though they should be deleting but oh well). idk how to fix this

9

I’ve managed to fix it, for some reason

#game.ReplicatedStorage.Blocks:GetChildren()

wouldn’t updated, however I never realised blocks were being deleted anyways because I for got to clone.

Here’s the updated script:

function Round.generate(plr: Player, number: number?)
	local blockNumber = number or 3
	local max = #game.ReplicatedStorage.Blocks:GetChildren()
	
	local blocks = {}
	for i = 1,blockNumber do
		local block = game.ReplicatedStorage.Blocks:GetChildren()[Round.random(max)]:Clone()
		print(block, typeof(block))
		block.Position = UDim2.new(0,200,0,200*i)
		block.BlockScript.OriginalPos.Value = "0,200,0,"..(200*i)
		block.Parent = game.ReplicatedStorage
		table.insert(blocks, block)
	end
	rp.Events.GenerateBlocks:FireClient(plr, blocks)

Thanks @Bloxynet for helping me realise this!

1 Like