Player able to buy more weapons when not wanted

Help and Feedback Scripting Support
,
#1

Hello, the reason i made this topic because im having a problem with my Shop script(it works fine its just when the player clicks the gui it fires a remotevent sending it to server side where the player would get the weapon but i only want the player to get one of each weapon but the player is still able to get a bunch when your inside the lobby you can choose which weapon you want to use(only bat for now) but if you continue to click on it more bats would show up in your backpack when the match starts script: local OnWeapon = game.ReplicatedStorage.Events.OnWeapon
local hasWeapon = game.ReplicatedStorage.Values.HasWeapon
local Weapons = {
[“Bat”] = game.ReplicatedStorage.Weapons.Bat,
– add more weapons here
}

OnWeapon.OnServerEvent:Connect(function(player, char, hum)

local weaponName = player.Character.Weapon.Value
if player.Character.HumanoidRootPart:FindFirstChild("Weapons[weaponName]") then
	hasWeapon.Value = true
else if not player.Character.HumanoidRootPart:FindFirstChild("Weapons[weaponName]") then
		hasWeapon.Value = false
	end
	
end
if Weapons[weaponName] and hasWeapon.Value == false then
	local NewWeapon = Weapons[weaponName]:Clone()
	NewWeapon.Parent = player.Character.HumanoidRootPart
	hasWeapon.Value = true
	while wait(0.1) do
		if player.Character.InMatch.Value == true then
			NewWeapon.Parent = player.Backpack
				break
		end
	end
else
	print("can not get another weapon")
	-- the player's weapon does not match any weapon in the Weapons table
	
end

end)

2 Likes
#2

the video is an mp3 file not an mp4?

1 Like
#3

yea uh ima just remove the video

1 Like
#4

the problem is if you were to click the bat gui from the shop it will show up in the hp(humanoidRootPart) but when you click it multiple times a bunch will show which i only want one of that weapon.

#5

the fired remotevent is in a different script.

#6

I think the issue is on these line of code:

if player.Character.HumanoidRootPart:FindFirstChild("Weapons[weaponName]") then
	hasWeapon.Value = true
else if not player.Character.HumanoidRootPart:FindFirstChild("Weapons[weaponName]") then
		hasWeapon.Value = false
	end
end

Because you’re FindFirstChild(“Weapons[weaponName]”) so the script will find object that have a name “Weapons[weaponName]” to fix this you should use:

if player.Character.HumanoidRootPart:FindFirstChild(Weapons[weaponName]) then
	hasWeapon.Value = true
elseif not player.Character.HumanoidRootPart:FindFirstChild(Weapons[weaponName]) then
		hasWeapon.Value = false
	end
end

also elseif statement should be call as elseif not else if.

#7

Well, when I remove the quotes, I get another error I think the problem is the while wait loop.

1 Like
#8

What’s the error say in ourput?

#9

03:59:49.935 Argument 1 missing or nil - Server - GivePlayerWeapon:13 when I remove the quotes this occurs, I tried remaking that whole section, but this is all I got.

#10

Maybe your weaponName variable just got nil value did you set value of your player.Character.Weapon.Value in local script? if yes then you need to set the value with server script or else server script will see it be nil

#11

Yes, its server sided and its a stringvalue.

#12

There might be another way to do this…

#14

So yea its because of the elseif statement.

#15

Okay can you try this?:

if player.Character.HumanoidRootPart:FindFirstChild(Weapons[weaponName].Name) then
	hasWeapon.Value = true
elseif not player.Character.HumanoidRootPart:FindFirstChild(Weapons[weaponName].Name) then
	hasWeapon.Value = false
end

also can you tell me what’s the value of weaponName?

#16

Yea the problem is the elseif statement im trying to find other ways to get around it.

#17

The Weapon Name is Called Bat.

#18

Okay so that code should be work

#19

finally, I figured it out😒 so instead of using the if and elseif statement i did this local OnWeapon = game.ReplicatedStorage.Events.OnWeapon
local hasWeapon = game.ReplicatedStorage.Values.HasWeapon
local Weapons = {
[“Bat”] = game.ReplicatedStorage.Weapons.Bat,
– add more weapons here
}

OnWeapon.OnServerEvent:Connect(function(player, char, hum)

local weaponName = player.Character.Weapon.Value
--if player.Character.HumanoidRootPart:FindFirstChild(Weapons[weaponName]) then
--	hasWeapon.Value = true

– elseif not player.Character.HumanoidRootPart:FindFirstChild(Weapons[weaponName]) then
– hasWeapon.Value = false
–end
print(Weapons[weaponName])
if Weapons[weaponName] and not player.Character.HumanoidRootPart:FindFirstChild(weaponName) then
print(hasWeapon.Value)
local NewWeapon = Weapons[weaponName]:Clone()
NewWeapon.Parent = player.Character.HumanoidRootPart
hasWeapon.Value = true
while wait(0.1) do
if player.Character.InMatch.Value == true then
NewWeapon.Parent = player.Backpack
break
end
end
–elseif not player.Character.HumanoidRootPart:FindFirstChild(“Weapons[weaponName]”) then
–hasWeapon.Value = false
–print(Weapons[weaponName])
– the player’s weapon does not match any weapon in the Weapons table
end
end)
which caused it to work! thank you for your help!

#20

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.