Player must be a child of Players using PlayerAdded

Bug Reports Engine Bugs
#1
  • Describe the bug. Describe what is happening when the bug occurs. Describe what you would normally expect to occur.

I get Player must be a child of Players as an error when using the PlayerAdded event

  • How often does the bug happen (Everytime/sometimes/rarely)? What are the steps that reproduce the bug? Please list them in very high detail. Provide simple example places that exhibit the bug and provide description of what you believe should be the behavior.

Enough that I see it in my logs about 30 times per day from a game that gets ~4k visits per day.

  • Where does the bug happen (www, gametest, etc) Is it level-specific? Is it game specific? Please post a link to the place that exhibits the issue.

Live

  • When did the bug start happening? If we can tie it to a specific release that helps us figure out what we broke.

First seen on 8th Sept

  • Anything else that you would want to know about the bug if it were your job to find and fix it.

The code used is the following:

function setupPlayer(player)
-- Do stuff
end
game.Players.PlayerAdded:connect(function(player)
    setupPlayer(player)
end
#2

The error sounds like you are trying to re-parent players - try using some print debugging to see exactly where the error happens.

Does it give a line where it errors? If so, is it line with the PlayerAdded event?

Also how do you reproduce it? Have you tried using PlayerAdded in a different script in the same place, and then again in another place?

Sorry for being skeptical but it doesn’t sound like a bug that would be from ROBLOX (I may be wrong though).

#3

The specific line is:

player:GetRoleInGroup(GROUP_ID)

Which is only called after the PlayerAdded event according to the stack trace

#4

Alright so either :GetRoleInGroup is attempting to re-parent or somehow the error gets thrown while the code is running that line (I think I get the latter when testing code that needs to be broken/killed - like an infinite while loop).

#5

I can guarantee that no reparenting of players is done within the script.
There is an infinite loop in a spawn() function, you think that could interrupt the HTTP request for GetRoleInGroup?

#6

Not really. That also still wouldn’t explain the error, I think.

I believe it has something to do with whatever is re-parenting player acting similar to the while loop example and not throwing an error from the correct source.

You’ll probably need to talk to someone who knows this better than me lol

#7

I don’t think this has anything to do with reparenting.

I’m pretty sure GetRoleInGroup is programmed and designed such that you are only supposed to be getting the role of players that are in the game. That’s why it’s a method of Player instead of GroupService, and why it errors if the player is not “in the game”. You’re not allowed to get the role of players that are not in the game, such as players that have left the server.

image

Try putting something like this before you use GetRoleInGroup:

while player.Parent ~= game.Players do
    wait()
end

If that fixes it, then it seems that the bug is either:

  • PlayerAdded is firing before the player is a child of Players (bug)
  • or players are removed before your code runs…
    • by internal Roblox programming (bug)
    • or by programming in your game, that could, for example, be kicking players before you check their role (your problem that you need to fix)
1 Like
#8

Sounds like players are just leaving the game by themselves before you call GetRoleInGroup.

3 Likes
#9

If this is the case, you definitely don’t want to loop waiting for them to get parented to game.Players without a timeout.

1 Like
#10

I’ve just added checks to see if they are a child of Players to stop this appearing but it does seem strange that a player can join a game, trigger PlayerAdded and leave before GetRoleInGroup returns.
Thanks for the help guys
@Lilly_S lock please

#11

Maybe they’re lagging out and close Roblox, which still runs for a tiny bit in the background. It completes connection and in the same packet sends the “I left the game” stuff. PlayerAdded fires while the connection is already closed (thus the Player parented to nil)

just a guess. could always scan through the NetworkReplicators and see if the player is actually still connected to see if this is actually the case

#12