Im looking to give a Player +1 item every 60 seconds.
while true and task.wait(1) do
playerItem += 1
end
^ this would be on the PlayerJoined connection
My question is:
Would this loop giving method be efficient for a larger scale of players?
you can add to all larger scale of players.when the event runs the function for too much time,every function will work since they started.
No problem should appear 
The players.PlayerAdded() event spawns a new task on the server every time it is called. The loop would only run in 1 task, meaning that it would be fine if multiple players join. There might be issues with performance if there are large amounts of players on each server, but it shouldn’t cause serious lag.
Also, just something I noticed, doing:
while true and task.wait(1) do
The true part of that line is redundant. You can instead just do:
while tast.wait(1) do
And it would work the same.
Wait pls answer my wondered question 
while true do
task.wait(1)
end
OR
while task.wait(1) do
end
which one is better i commonly use the first one please help
I’ve seen a good amount of people say that task.wait(1) is more efficient
never have I done any sort of tests to prove this myself but i just got into habit to use task.wait()
this deserves to be shamed for i cannot read to save my life LOL
This is better. It takes up less space and does the exact same thing.
Oh man i thought the first one was better 
ok i’ll try this 
ignore me for i was dyslexic there 
LOL
anyways thanks for commenting <3
yes sure use task.wait(1) i tested difference between wait() and task.wait() wait is not waiting correctly.something like 1.2 seconds but task.wait(1) actually waits like 1.0 seconds
wait() will be get deprecated i must cry for that 
You should use the first option if you have a conditional statement, in place of “true”, that will be false at some point. Otherwise, as @Fittergem1000 stated, you should just use the second option.
You should do
while true do
for i,v in pairs(game.Players:GetPlayers()) do
pcall(function())
v.playerItem += 1
end)
end
end
in a server script. This is the easiest and most effective way to reward all players equally for playing.
uh hey but we will add every player at same time for this code?
and uhh.not the best way what if it triggers when player isnt loaded fully?
Correct, if you are only looping something that if a value is true, EX:
local value = false
while value = true do
Then you should use the first option. Otherwise the second object saves space and time.
no this code is all you need. You don’t need to keep track of the current players in the server as game.Players:GetPlayers() does that for you
how would this be equal playing time.
no hate.
just curious on your thinking
this would mean if i join like .2 seconds before the loop plays then ill get that reward others worked for.
that one sucks my script wasnt working because of that little error.
if value is false then the loop becomes mad and goes to MCdonalds and never comes back
im not choosing favotires for the solution I chose just wanted to say this cause you also helped the other persons response is helpful for more people since its a bit more in depth answer
<3 thanks for respond
there is no other solution that is “more equal” than the one I provided.
but if the playerjoined makes a new task each time its called then you would wanna reward for players ACTUAL playtime vs a global one no?
Your solution provides a loop for a global reward system. The system that @bbnoshanky has in place is fired upon a player joining (players.PlayerAdded()). The player is already defined in the function and the server is only managing the specific player that joined. This happens every time a new player joins, that way each player gets their own reward loop.