Premium Benefits

Help and Feedback Scripting Support
#1

Hey devs,

I am attempting to add premium benefits to my game, using the following code:

cash.Changed:Connect(function()
	if player.MembershipType == Enum.MembershipType.Premium then
		cash.Value = cash.Value + (cash.value * .01)
	end
end)

This code checks for when the Player’s cash changes, and adds extra cash to their balance.

The issue that I having is that this works whenever the player buys something with their cash as well. So they loss the money from the purchase, and then receive extra cash from the code.

Basically I need a way to check if the balance increase, and only have the code run if they are gaining money. However, I am not sure how to check if their money is increasing or decreasing.

1 Like
#2

You’d likely want to use some sort of client-server event for when a player is purchasing or earning money. Instead of binding this function to cash.Changed, bind it to your own RemoteEvent.

That way you don’t even need to check if the player lost or earned money, you already know which it was based on which event fired.

1 Like
#3

You need a RemoteEvent to do this.

Also, multiplying numbers with a number less than 1 will essentially subtract the number, if that is not what you’re going with.

1 Like
#4 
local lastCash = cash.Value
cash.Changed:Connect(function()
	-- check if we gained cash
	if cash.Value > lastCash then
		if player.MembershipType == Enum.MembershipType.Premium then
			cash.Value = cash.Value + (cash.value * .01)
		end
	end
	lastCash = cash.Value
end)
1 Like
#5

You could check if the new balance is greater than the current one (assuming that when they buy more currency their cash value will rise), and if it is, it will double

cash.Changed:Connect(function(new)
	if player.MembershipType == Enum.MembershipType.Premium then
        if cash.Value >= new then
	    	cash.Value = cash.Value + (cash.value * .01)
        end
	end
end)
1 Like
#6

Which is why I take the current value then add the multiplied amount onto it

1 Like
#7

An easier way of doing it would be this

cash.Value *= 1.01
2 Likes
#8

I am getting this error now

Maximum event re-entrancy depth exceeded for IntValue.Changed

1 Like
#9

You are changing the value inside a value changed event, which will end up calling the event over and over forever.

Maybe instead of listening for the cash value changing just apply the bonus in whichever script is adding the cash.

#10

You can just add a debounce, and you should also probably use GetPropertyChangedSignal instead of Changed

local lastCash = cash.Value
local debounce = false
cash:GetPropertyChangedSignal'Value':Connect(function()
	if debounce then return end
	if cash.Value > lastCash then
		debounce = true
		if player.MembershipType == Enum.MembershipType.Premium then
			cash.Value = cash.Value + (cash.Value * .01)
		end
		debounce = false
	end
	lastCash = cash.Value
end)
2 Likes
#11

Why bother with all the extra code when you can just bind the same functionality to a RemoteEvent and call that when the player earns cash? Using cash.Changed or cash:GetPropertyChangedSignal is just bloat.

cashEarned.OnServerEvent:Connect(function()
	if player.MembershipType == Enum.MembershipType.Premium then
		cash.Value = cash.Value + (cash.Value * .01)
	end
end)

There is no need to create extra variables to compare the before and after of the cash value if the function is bound to an event that only fires when the player earns cash.

1 Like