Random Selector printing nil

Help and Feedback Scripting Support
#1

Hello!
I’m using an open source module by @ImageLabel to make a random selector.
Post: How do i design a role-chance system, similar to Murder Mystery 2? - #5 by ImageLabel

It’s not working!
Here is my script:

local function SelectDoge()
	local selected = nil;
	
	local TotalWeight = 0;
	local Weights = {};
	
	for index, player in pairs(PlayingPlayers) do
		
		Weights[index] = 10;
		
		--if MarketplaceService:UserOwnsGamePassAsync(player.UserId, MultProduct) then
			--multiplier of 10 for every player that owns the relevant gamepass
			--Weights[index] = Weights[index] * 10
		--end
	
		TotalWeight = TotalWeight + Weights[index]
		
		Events.DogeChance:FireClient(player,TotalWeight)
	end
	
	
	local ticket = Random.new():NextInteger(1, TotalWeight);
	
	for index = 1, TotalWeight do
		
		
		ticket = ticket - Weights[index]
		if ticket <= 0 then
			
			selected = PlayingPlayers[index]
			break
		end
	end
	print(selected)
	return selected;
end

When I do, print(selected), it prints Nil. It should select a random person from the playing players!
Why is it printing nil?

#2

Your testing with more than one player, correct?

#3

No, just myself…

#4

Try testing with more than one player

#5

You know what the word nil means right? It means nothing, when you are printing the variable, it prints nil because it isn’t anything. Try moving it into the loop and tell me the output.

#6

The reason has to be that your selected variable is nil or nothing.

#7

I know what nil means, but why isn’t it selecting a random player and printing them?

#8

Try putting that print statement into the loop.

#9

Which? there’s 2…

#10

I still got the same error…

#11

Alrighty, let me review your code.

#12

Might have found the error in your code.
selected = PlayingPlayers[index] is the error.
What data type is PlayingPlayers?

#13

I’m very sorry, but I found my issue, after testing the same thing on a baseplate.

This is my code:

		for _, Player in pairs(game.Players:GetPlayers()) do
			spawn(function()
				table.insert(PlayingPlayers, Player)
			end)
		end
		
		wait()
		
		--Music(true,false,'LobbyMusic')
		
		TopText.Value = 'GameTimeText'
		
		local Map = ChosenMap:Clone()
		Map.Parent = workspace
		
		wait(.3)
		
		local Doge = SelectDoge()

I fixed it, by adding those waits. I’m guessing that the players weren’t properly inserted, so adding that fixed my issue.
Thanks!

@jumbopushpop112

#14

You’re welcome! Glad I was able to help. :slight_smile: