RemoteEvent not firing? (Solved)

Help and Feedback Scripting Support
#1

My upgrade system is not working, please tell me what is wrong with my code.

It basically does not fire the remote event when the button is clicked.

LocalScript that fires the event 
local cash = game.Players.LocalPlayer.leaderstats.Cash
local price1 = 150
local level = game.Players.LocalPlayer.upgradestats.Upgrade
local player = game.Players.LocalPlayer

local price = price1 * level.Value

while wait() do
	script.Parent.Price.Text = "Price: "..price.." Cash"
	script.Parent.Level.Text = "Your Level: "..level.Value
end

script.Parent.Submit.MouseButton1Click:Connect(function()
	game.ReplicatedStorage.Upgrade:FireServer(player, price)
	print("made it") --this part is not printing
end)
Script that is supposed to receive the event 
game.ReplicatedStorage.Upgrade.OnServerEvent:Connect(function(player, price)
	if player.leaderstats.Cash.Value > price - 1 then
		player.leaderstats.Cash.Value -= price
		player.upgradestats.Upgrade.Value += 1
	end
end)
leaderstats 
local service = game:GetService("DataStoreService")
local datastore = service:GetDataStore("JumpStore")
local datastore2 = service:GetDataStore("CashStore")

game.Players.PlayerAdded:Connect(function(plr)
	local leaderstats = Instance.new("Folder", plr)
	leaderstats.Name = "leaderstats"

	local stat = Instance.new("IntValue", leaderstats)
	stat.Name = "Jumps"
	
	local stat2 = Instance.new("IntValue", leaderstats)
	stat2.Name = "Cash"
	
	local data
	local success, errorMessage = pcall(function()
		data = datastore:GetAsync(plr.UserId.."-jumps")
	end)
	
	local data2
	local success2, errorMessage2 = pcall(function()
		data2 = datastore2:GetAsync(plr.UserId.."-cash")
	end)

	if success then
		stat.Value = data
	else
		warn(errorMessage)
	end
	
	if success2 then
		stat2.Value = data2
	else
		warn(errorMessage2)
	end
end)

game.Players.PlayerRemoving:Connect(function(plr)
	local success, errorMessage = pcall(function()
		datastore:SetAsync(plr.UserId.."-jumps", plr.leaderstats.Jumps.Value) 
	end)

	if not success then
		warn(errorMessage)
	end
	
	local success2, errorMessage2 = pcall(function()
		datastore2:SetAsync(plr.UserId.."-cash", plr.leaderstats.Cash.Value)
	end)
	
	if not success2 then
		warn(errorMessage2)
	end
end)
upgradestats (level) 
local service = game:GetService("DataStoreService")
local datastore = service:GetDataStore("UpgradeStore")

game.Players.PlayerAdded:Connect(function(plr)
	local upgradestats = Instance.new("Folder", plr)
	upgradestats.Name = "upgradestats"
	
	local stat = Instance.new("IntValue", upgradestats)
	stat.Name = "Upgrade"
	
	local data
	local success, errorMessage = pcall(function()
		data = datastore:GetAsync(plr.UserId.."-upgrade")
	end)
	
	if success then
		stat.Value = data
	else
		warn(errorMessage)
	end
	
	if stat.Value == 0 then
		stat.Value = 1
	end
end)

game.Players.PlayerRemoving:Connect(function(plr)
	local success, errorMessage = pcall(function()
		datastore:SetAsync(plr.UserId.."-upgrade", plr.upgradestats.Upgrade.Value) 
	end)
	
	if not success then
		warn(errorMessage)
	end
end)

Ty!

#2

Are there any errors? And does the server receive the message from the client?

#3

What do you mean by “message”? The event? There are 0 errors

#4

We want to know what is that the problem is your script show us that poeming on

#5

This loop runs forever and nothing under it will run. If you have an infinite loop, you need to put it at the bottom of whatever thread it is in. Move it to the bottom of this script.

#6

Ok, I’ll try that and see if it works

#7
  1. local ReplicatedStorage = game:GetService(“ReplicatedStorage”)
  2. local TextService = game:GetService(“TextService”)
  3. local Players = game:GetService(“Players”)
  5. – Define remotes for communication with client
  6. local Remotes = Instance.new(“Folder”, ReplicatedStorage)
  7. Remotes.Name = “PetNamingRemotes”
  10. local UserNamedPet = Instance.new(“RemoteEvent”, Remotes)
  11. UserNamedPet.Name = “UserNamedPet”
  12. –[[
  13. RemoteEvent UserNamedPet

  15. Paramaters: petName (string)

  17. To be fired by the client when the user has picked a name for their pet.

  19. Example:

  21. local userNamedPet = ReplicatedStorage:WaitForChild("PetNamingRemotes"):WaitForChild("UserNamedPet")

  22. userNamedPet:FireServer("Max")
  23. ]]
  25. local SendPetName = Instance.new(“RemoteEvent”, Remotes)
  26. SendPetName.Name = “SendPetName”
  27. –[[
  28. RemoteEvent SendPetName

  30. Paramaters: userId (int), petName (string)

  32. Fired by the server when a user changes their pet's name

  34. Example:

  36. local sendPetName = ReplicatedStorage:WaitForChild("PetNamingRemotes"):WaitForChild("SendPetName")

  37. sendPetName.OnClientEvent:Connect(function(userId, petName)

  38. 	local player = Players:GetPlayerByUserId(userId)

  39. 	if player then

  40. 		print(player.Name.." has named their pet ".. petName)

  41. 	end	

  42. end)
  43. ]]
  45. local RequestAllPetNames = Instance.new(“RemoteFunction”, Remotes)
  46. RequestAllPetNames.Name = “RequestAllPetNames”
  47. –[[
  48. RemoteEvent SendPetName

  50. Paramaters: n/a

  52. Fetches the names of every player's pet. To be invoked by the client when a user joins the game. 

  54. Example:

  56. local requestAllPetNames = ReplicatedStorage:WaitForChild("PetNamingRemotes"):WaitForChild("RequestAllPetNames")

  57. local petNames = requestAllPetNames:InvokeServer()

  58. for userId, petName in pairs(petNames or {}) do

  59. 	local player = Players:GetPlayerByUserId(userId)

  60. 	if player then

  61. 		print(player.Name.." has a pet named ".. petName)

  62. 	end	

  63. end
  65. ]]
  67. local filterResults = {}
  69. local function broadcastPetName(userId)
  70. local filterResult = filterResults[userId]

  71. if filterResult then

  72. 	for _, player in pairs(Players:GetPlayers()) do 

  73. 		if player then

  75. 			-- spawn a new thread so as to not yield the update

  76. 			spawn(function()

  78. 				-- grab the filtered string for this user

  79. 				local toUserId = player.UserId

  80. 				local filteredString = filterResult:GetNonChatStringForUserAsync(toUserId)

  81. 				filteredString = filteredString or ""

  82. 				-- send the remote event

  83. 				SendPetName:FireClient(player, userId, filteredString)

  84. 			end)

  85. 		end

  86. 	end

  87. end
  88. end
  90. UserNamedPet.OnServerEvent:Connect(function(player, petName)
  91. local fromUserId = player.UserId

  93. -- pcall to catch errors

  94. local success, result = pcall(function()

  95. 	return TextService:FilterStringAsync(

  96. 		petName, 

  97. 		fromUserId

  98. 	)

  99. end)
  101. if success then
  102.    filterResults[fromUserId] = result

  103.    broadcastPetName(fromUserId)
  104. else
  105.    print("Could not filter pet name")
  106. end
  107. end)
  109. RequestAllPetNames.OnServerInvoke = (function(player)
  110. local toUserId = player.UserId
  112. local petNames = {}
  114. – go through filter results and filter the pet name to be sent
  115. for fromUserId, filterResult in pairs(filterResults) do
  116.    local filteredString = filterResult:GetNonChatStringForUserAsync(toUserId)

  117.    filteredString = filteredString or ""

  119.    -- need to convert userId to string so it can't be sent via a remote function

  120.    petNames[tostring(fromUserId)] = filteredString
  121. end
  123. return petNames
  124. end)
  126. – Listen for players being removed, and clean up old filter results
  127. Players.PlayerRemoving:Connect(function(oldPlayer)
  128. local userId = oldPlayer.UserId
  129. filterResults(userId) = nil
  130. end)
#8

Maybe you have to try that script

#9

I got an error, ServerScriptService:Upgrade:2: attempt to perform arithmetic (sub) on Instance and number

#10

I don’t think that script will be helpful to his problem. It’s for something completely different and it is formatted poorly. That script was probably for a pet system you copied and pasted without knowing what it actually is.

#11

But we know this the problem is coming to error the script is if you enter that maybe will come to me ever

#12

This is the line where it says the error occured

if player.leaderstats.Cash.Value > price - 1 then
#13

But we know is that big problem my steps it is it’ll but if you try that maybe we will fix that problem I will see

#14

price is a reference to an instance, you may need to do price.Value instead if it is a reference to a value object (IntValue, NumberValue etc.).

1 Like
#15

Change the local script to fire (price).

When the server receives the message it will automatically add another parameter before the price with the player.

#16

These are the 2 lines where Price is defined

local price = price1 * level.Value
local price1 = 150
#17 
:FireServer(player, price)

The player parameter here isn’t required, the client’s (which fired the server) player object is automatically passed to the server.

1 Like
#18

Ok, i removed the player parameter and it works now except for the price text label

#19 
local price = price1 * level.Value

while wait() do
	script.Parent.Price.Text = "Price: "..price.." Cash"

The value of price is only assigned once, you need to reassign it whenever necessary.

2 Likes
#21

Price1 was predefined as 150.

Basically it’ll keep updating it, given that the price is 150. You’ll need to update the variable using a function.