Removing repeating attribute changes

Help and Feedback Code Review
#1

Hi, I am working on a movement script and everytime I check it, it annoys me to see so much repeating of attributes. Heres a example

Screen Shot 2023-05-12 at 11.10.27 PM
Screen Shot 2023-05-12 at 11.10.27 PM1470×742 205 KB 


LocalPlayer:SetAttribute("MOVE_SPEED",24)
LocalPlayer:SetAttribute("RUN_ACCELERATION",3.2)
LocalPlayer:SetAttribute("RUN_DEACCELERATION",0.2)
LocalPlayer:SetAttribute("AIR_ACCELERATION",6)
LocalPlayer:SetAttribute("AIR_DEACCELERATION",2)
LocalPlayer:SetAttribute("SIDE_STRAFE_ACCELERATION",100)
LocalPlayer:SetAttribute("SIDE_STRAFE_SPEED",1)
LocalPlayer:SetAttribute("AIR_FRICTION",1)
LocalPlayer:SetAttribute("MAX_SPEED",46)
LocalPlayer:SetAttribute("JUMP_BUFFER",0.4)
LocalPlayer:SetAttribute("FRICTION",3)

local MOVE_SPEED = LocalPlayer:GetAttribute("MOVE_SPEED")
local RUN_ACCELERATION = LocalPlayer:GetAttribute("RUN_ACCELERATION")
local RUN_DEACCELERATION = LocalPlayer:GetAttribute("RUN_DEACCELERATION")
local AIR_ACCELERATION = LocalPlayer:GetAttribute("AIR_ACCELERATION")
local AIR_DEACCELERATION = LocalPlayer:GetAttribute("AIR_DEACCELERATION")
local SIDE_STRAFE_ACCELERATION = LocalPlayer:GetAttribute("SIDE_STRAFE_ACCELERATION")
local SIDE_STRAFE_SPEED = LocalPlayer:GetAttribute("SIDE_STRAFE_SPEED")
local FRICTION = LocalPlayer:GetAttribute("FRICTION")
local AIR_FRICTION = LocalPlayer:GetAttribute("AIR_FRICTION")
local MAX_SPEED = LocalPlayer:GetAttribute("MAX_SPEED")
local JUMP_BUFFER = LocalPlayer:GetAttribute("JUMP_BUFFER")

Is there anyway to make these easier to look at?

#2

If the variables directly correlate with the numbers you are inputting you can do this:

local MOVE_SPEED = 24
local RUN_ACCELERATION = 3.2
local RUN_DEACCELERATION = 0.2
local AIR_ACCELERATION = 6
local AIR_DEACCELERATION = 2
local SIDE_STRAFE_ACCELERATION = 100
local SIDE_STRAFE_SPEED = 1
local AIR_FRICTION = 1
local MAX_SPEED = 46
local JUMP_BUFFER = 0.4
local FRICTION = 3

LocalPlayer:SetAttribute("MOVE_SPEED", MOVE_SPEED )
LocalPlayer:SetAttribute("RUN_ACCELERATION", RUN_ACCELERATION )
LocalPlayer:SetAttribute("RUN_DEACCELERATION", RUN_DEACCELERATION )
LocalPlayer:SetAttribute("AIR_ACCELERATION", AIR_ACCELERATION )
LocalPlayer:SetAttribute("AIR_DEACCELERATION", AIR_DEACCELERATION )
LocalPlayer:SetAttribute("SIDE_STRAFE_ACCELERATION", SIDE_STRAFE_ACCELERATION )
LocalPlayer:SetAttribute("SIDE_STRAFE_SPEED", SIDE_STRAFE_SPEED )
LocalPlayer:SetAttribute("AIR_FRICTION", AIR_FRICTION )
LocalPlayer:SetAttribute("MAX_SPEED", MAX_SPEED )
LocalPlayer:SetAttribute("JUMP_BUFFER", JUMP_BUFFER )
LocalPlayer:SetAttribute("FRICTION", FRICTION )
1 Like
#3

Thanks this looks easier to look at! :smile:

#4

Got a new fix:

local Settings = {
	MOVE_SPEED = 24,
	RUN_ACCELERATION = 3.2,
	RUN_DEACCELERATION = 0.2,
	AIR_ACCELERATION = 6,
	AIR_DEACCELERATION = 2,
	SIDE_STRAFE_ACCELERATION = 100,
	SIDE_STRAFE_SPEED = 1,
	AIR_FRICTION = 1,
	MAX_SPEED = 46,
	JUMP_BUFFER = 0.4,
	FRICTION = 3,
}

for setting,value in pairs(Settings) do
	Humanoid:SetAttribute(setting,value)
end
#5

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.