Review this code on the latest adaptation of FastValuesService

Help and Feedback Code Review
#1

https://github.com/MFD-gh/RojoFastValuesAPI
This is a github repo because I am not sending the body of 5 scripts

Feedback format
[ScriptName]: I found this good and that but you could change them etc.

2 Likes
#2

Looks like this has been automatically exported to a github repo. Could be useful to clean up the directories and update the README to explain what the script is supposed to do

1 Like
#3

What naming convention is this?

#4

What do you mean by β€œnaming convention”

1 Like
#5

Throughout your project, what is the rationale behind prefixing almost every variable with underscores?

It reminds me of the Hungarian Notation bit less effective.

#6

It’s the format for every mfd project, it used to also be minified

#7

Are you designing this to be open-source? Or, rather, are you using GitHub just as a means to display the current project?

#8

It’s already open-source,

#9

In that case, refer to GitHub for the issues I’ve provided.

1 Like
#10

As this was kind of rushed onto the repo, we didn’t have time to put it into a good enough style, as of now (02/08/2020 since 25/07/2020) we have been working on a style that will suit the lua style guide