Script only works once

volantias · January 15, 2022, 10:29pm

Currently, I can only do !start once. After I do !ref (which refreshes the map), the !start breaks.

	local Players = game:GetService("Players")
	local serverstorage = game:GetService("ServerStorage")
	local replicatedStorage = game:GetService("ReplicatedStorage")

	local AmountOfPlayers = #Players:GetPlayers()
	local folder = workspace.Game.Scriptable.Pillars:GetChildren()
	local amountValue = #folder

	local PlayersService = game:GetService("Players")
	local StringToDetect = "!start"
	local string2 = "!ref"

	Players.PlayerAdded:Connect(function(Player)
AmountOfPlayers = AmountOfPlayers + 1
	end)

	Players.PlayerRemoving:Connect(function(Player)
AmountOfPlayers = AmountOfPlayers - 1
	end)

	PlayersService.PlayerAdded:Connect(function(Player)
Player.Chatted:Connect(function(Message1)
	print(AmountOfPlayers)
	if string.find(string.lower(Message1), string.lower(string2)) then
		workspace.Game.Scriptable.Pillars:Destroy()
		local pillarClone = replicatedStorage.Pillars:Clone()
		pillarClone.Name = "Pillars"
		pillarClone.Parent = workspace.Game.Scriptable
	end
end)
Player.Chatted:Connect(function(Message)
	print(AmountOfPlayers)
	if string.find(string.lower(Message), string.lower(StringToDetect)) then
		amountValue = #folder
		repeat wait(0.0001)
			folder[math.random(#folder)]:Destroy()
		until #(workspace.Game.Scriptable.Pillars:GetChildren()) == #Players:GetPlayers()
		
		if #(workspace.Game.Scriptable.Pillars:GetChildren()) == #Players:GetPlayers() then
		end
	end
end)
	end)

12Noob_19761 · January 15, 2022, 10:37pm

Try adding this



spawn(function()
	warn("Loading...")
	wait(.5)
	
	warn("Loaded!")
	
local Players = game:GetService("Players")
local serverstorage = game:GetService("ServerStorage")
local replicatedStorage = game:GetService("ReplicatedStorage")

local AmountOfPlayers = #Players:GetPlayers()
local folder = workspace.Game.Scriptable.Pillars:GetChildren()
local amountValue = #folder

local PlayersService = game:GetService("Players")
local StringToDetect = "!start"
local string2 = "!ref"

Players.PlayerAdded:Connect(function(Player)
	AmountOfPlayers = AmountOfPlayers + 1
end)

Players.PlayerRemoving:Connect(function(Player)
	AmountOfPlayers = AmountOfPlayers - 1
end)

PlayersService.PlayerAdded:Connect(function(Player)
	Player.Chatted:Connect(function(Message1)
		print(AmountOfPlayers)
		if string.find(string.lower(Message1), string.lower(string2)) then
			workspace.Game.Scriptable.Pillars:Destroy()
			local pillarClone = replicatedStorage.Pillars:Clone()
			pillarClone.Name = "Pillars"
			pillarClone.Parent = workspace.Game.Scriptable
		end
	end)
	Player.Chatted:Connect(function(Message)
		print(AmountOfPlayers)
		if string.find(string.lower(Message), string.lower(StringToDetect)) then
			amountValue = #folder
			repeat wait(0.0001)
				folder[math.random(#folder)]:Destroy()
			until #(workspace.Game.Scriptable.Pillars:GetChildren()) == #Players:GetPlayers()

			if #(workspace.Game.Scriptable.Pillars:GetChildren()) == #Players:GetPlayers() then
				end
			end
		end)
	end)
end)
```

volantias · January 15, 2022, 10:43pm

Currently, the function you added in breaks the script.

12Noob_19761 · January 15, 2022, 10:44pm

I think the Repeat wait() is breaking the !start

volantias · January 15, 2022, 10:45pm

Ah, alright. Do you know another alternative for the repeat wait?

12Noob_19761 · January 15, 2022, 10:46pm

You can try using while wait() do

12Noob_19761 · January 15, 2022, 10:49pm

or try this >

	
local Players = game:GetService("Players")
local serverstorage = game:GetService("ServerStorage")
local replicatedStorage = game:GetService("ReplicatedStorage")

local AmountOfPlayers = #Players:GetPlayers()
local folder = workspace.Game.Scriptable.Pillars:GetChildren()
local amountValue = #folder

local PlayersService = game:GetService("Players")
local StringToDetect = "!start"
local string2 = "!ref"

Players.PlayerAdded:Connect(function(Player)
	AmountOfPlayers = AmountOfPlayers + 1
end)

Players.PlayerRemoving:Connect(function(Player)
	AmountOfPlayers = AmountOfPlayers - 1
end)

PlayersService.PlayerAdded:Connect(function(Player)
	Player.Chatted:Connect(function(Message1)
		print(AmountOfPlayers)
		if string.find(string.lower(Message1), string.lower(string2)) then
			workspace.Game.Scriptable.Pillars:Destroy()
			local pillarClone = replicatedStorage.Pillars:Clone()
			pillarClone.Name = "Pillars"
			pillarClone.Parent = workspace.Game.Scriptable
		end
	end)
	Player.Chatted:Connect(function(Message)
		print(AmountOfPlayers)
		if string.find(string.lower(Message), string.lower(StringToDetect)) then
			amountValue = #folder
			while wait() do
			
			repeat task.wait()
				folder[math.random(#folder)]:Destroy()
		until	 #(workspace.Game.Scriptable.Pillars:GetChildren()) == #Players:GetPlayers()

			if #(workspace.Game.Scriptable.Pillars:GetChildren()) == #Players:GetPlayers() then
				end
			end
			
			end
		end)
	end)

[Never made this btw so it might not work still]

bleintant · January 15, 2022, 10:49pm

Maybe it’s not working because you’re destroying all of the clones?

volantias · January 15, 2022, 10:56pm

No, it still has the folder in it. I’m deleting the old folder to add a new once in.

bleintant · January 15, 2022, 11:02pm

Instead of doing repeat wait() you could do a while loop?

while #(workspace.Game.Scriptable.Pillars:GetChildren()) ~= #Players:GetPlayers()

volantias · January 15, 2022, 11:03pm

Alright, thank you! I will try that.

Forummer · January 15, 2022, 11:18pm

local Players = game:GetService("Players")
local Server = game:GetService("ServerStorage")
local Replicated = game:GetService("ReplicatedStorage")

local Pillar = Replicated:WaitForChild("Pillars")
local GameFolder = workspace:WaitForChild("Game")
local Scriptable = GameFolder:WaitForChild("Scriptable")
local PillarFolder = Scriptable:WaitForChild("Pillars")
local AmountOfPlayers = nil

Players.PlayerAdded:Connect(function(Player)
	AmountOfPlayers = #Players:GetPlayers()
	
	Player.Chatted:Connect(function(Message)
		print(AmountOfPlayers)
		
		if string.find(string.lower(Message), "!ref") then
			PillarFolder:Destroy()
			local pillarClone = Pillar:Clone()
			pillarClone.Name = "Pillars"
			pillarClone.Parent = Scriptable
			
		elseif string.find(string.lower(Message), "!start") then
			local Pillars
			repeat task.wait()
				Pillars = PillarFolder:GetChildren()
				Pillars[math.random(#Pillars)]:Destroy()
			until #Pillars == #Players:GetPlayers()

			if #(PillarFolder:GetChildren()) == #Players:GetPlayers() then
			end
		end
	end)
end)

Players.PlayerRemoving:Connect(function(Player)
	AmountOfPlayers = #Players:GetPlayers()
end)

volantias · January 15, 2022, 11:41pm

It works, but it errors after I do !restart and then !start again.

Forummer · January 15, 2022, 11:43pm

There isn’t a command named “!restart” but the command named “!ref” deletes the Pillars folder which is referenced inside the command named “!start” if this isn’t intended then remove the
PillarFolder:Destroy() line.

volantias · January 15, 2022, 11:44pm

I meant ref, sorry about that.

volantias · January 15, 2022, 11:44pm

What I wanted to do was basically make the original parts again.

Forummer · January 15, 2022, 11:46pm

You’d need to loop over the folder’s children and then destroy those instead of the entire folder. Is the instance named “Pillars” inside of ReplicatedStorage a folder of pillars? If so the code which clones that will need to be changed slightly as well.

volantias · January 15, 2022, 11:48pm

Mhm, it’s the exact same clone as the ones from workspace.

Forummer · January 15, 2022, 11:52pm

local Players = game:GetService("Players")
local Server = game:GetService("ServerStorage")
local Replicated = game:GetService("ReplicatedStorage")

local StoragePillars = Replicated:WaitForChild("Pillars")
local GameFolder = workspace:WaitForChild("Game")
local Scriptable = GameFolder:WaitForChild("Scriptable")
local WorkspacePillars = Scriptable:WaitForChild("Pillars")
local AmountOfPlayers = nil

Players.PlayerAdded:Connect(function(Player)
	AmountOfPlayers = #Players:GetPlayers()

	Player.Chatted:Connect(function(Message)
		print(AmountOfPlayers)

		if string.find(string.lower(Message), "!ref") then
			for _, Pillar in ipairs(WorkspacePillars:GetChildren()) do
				Pillar:Destroy()
			end
			
			for _, Pillar in ipairs(StoragePillars:GetChildren()) do
				local PillarClone = Pillar:Clone()
				PillarClone.Name = "Pillars"
				PillarClone.Parent = WorkspacePillars
			end

		elseif string.find(string.lower(Message), "!start") then
			local Pillars
			repeat task.wait()
				Pillars = WorkspacePillars:GetChildren()
				Pillars[math.random(#Pillars)]:Destroy()
			until #Pillars == #Players:GetPlayers()
		end
	end)
end)

Players.PlayerRemoving:Connect(function(Player)
	AmountOfPlayers = #Players:GetPlayers()
end)

volantias · January 16, 2022, 3:42am

Also, do you know how to make a player spawn on their own pillar using this?