Script stops running on death?

Help and Feedback Scripting Support
#1

So i have this script, and its meant to run forever. But it stops running whenever the player dies

I think its because i have it inside StarterPlayerScripts, but where else should i put it? :sweat_smile:

local plr = game.Players.LocalPlayer
local char = plr.CharacterAdded:Wait()
local hum = char:WaitForChild("Humanoid")
local gui = plr.PlayerGui.ValueGui
local textLabel = gui.SpeedValue

while true do
	wait(5)
	repeat wait() until hum ~= nil
	hum.WalkSpeed = hum.WalkSpeed + 1
	textLabel.Text = "Speed: "..hum.WalkSpeed
end
3 Likes
#3

The issue is you repeat waiting for hum to not be nil, but after the character has died you never actually search for a new humanoid again…

Try changing the repeat loop to:

repeat
    wait()
    if not char or not char:IsDescendantOf(game.Workspace) then
        char = plr.Character or plr.CharacterAdded:Wait()
    end
    hum = char:FindFirstChild("Humanoid")
until hum ~= nil

Edit: mobile typo fix.

2 Likes
#4

Like this?

local plr = game.Players.LocalPlayer
local char = plr.CharacterAdded:Wait()
local gui = plr.PlayerGui.ValueGui
local textLabel = gui.SpeedValue

while true do
	wait(5)
	repeat
    wait()
    if not char or not char:IsDescendantOf(game.Workspace) then
        char = plr.Character or old.CharacterAdded:Wait()
    end
    hum = char:FindFirstChild("Humanoid")
	until hum ~= nil
	hum.WalkSpeed = hum.WalkSpeed + 1
	textLabel.Text = "Speed: "..hum.WalkSpeed
end
2 Likes
#5

Yeah, I made a typo due to being on mobile. Where it said old.CharacterAdded it should be plr

Other than that, it looks good. Give it a go and see if that solves the issue for you.

#6

It doenst print out any errors, but it also doenst increase the WalkSpeed

#7

Does it not increase the actual walkspeed or does it just not update the GUI? You can check by looking at the actual Humanoid in Studio.

There may be a secondary issue linked to the other replier’s suggestion regarding the GUI itself - it needs ResetOnSpawn to be false otherwise this script will end up referencing an old version of the GUI that has been destroyed and not the newly spawned version.

Having ResetOnSpawn false means the same GUI remains regardless of resets.

#8

It doenst give you any speed when you join the game, but first when you die the first time, so the script only starts running when you have died your first time

#9

This could be due to cases where the character is already loaded when the script begins running.

I’ve tweaked a couple bits below to move the character logic entirely into the loop to ensure it doesn’t do any strange yielding at the start and to make it clear that it gets the new character if there isn’t one.

Hopefully this solves the issues for you.

local plr = game.Players.LocalPlayer
local gui = plr.PlayerGui:WaitForChild("ValueGui")
local textLabel = gui.SpeedValue

local char, hum

while true do
	wait(5)
	repeat
        wait()
        if not char or not char:IsDescendantOf(game.Workspace) then
            char = plr.Character or plr.CharacterAdded:Wait()
        end
        hum = char:FindFirstChild("Humanoid")
	until hum ~= nil
	hum.WalkSpeed = hum.WalkSpeed + 1
	textLabel.Text = "Speed: "..hum.WalkSpeed
end
#10

Out of curiousity, why are you using repeat wait() until hum ~= nil?

In all honesty I’d just use Player.CharacterAdded and just increase the WalkSpeed of the Humanoid from there.

Player.CharacterAdded:Connect(function(Character)
    local Humanoid = Character:WaitForChild("Humanoid")

    while Humanoid.Health > 0 do
       Humanoid.WalkSpeed = Humanoid.WalkSpeed + 1
       wait(5)
    end
end)
#11

player.CharacterAdded:Wait() only runs the code the first time the character is added. You need to run the code every time the character is added so that the script doesn’t break when the character respawns.
Code:

local plr = game.Players.LocalPlayer
local gui = plr.PlayerGui.ValueGui
local textLabel = gui.SpeedValue
player.CharacterAdded:Connect(function(char)
	local hum = char:WaitForChild("Humanoid")
	while wait(5) do
		if hum.Health == 0 then break end
		hum.WalkSpeed = hum.WalkSpeed + 1
		textLabel.Text = "Speed: "..hum.WalkSpeed
	end
end)
2 Likes