Script Troubleshooting

Help and Feedback Scripting Support
#1

Hey everyone, I’m having trouble with a script I drafted up and according to Script Analysis in studio everything should be working. Its a relatively simple script that checks if the player character is below 1/4 health and if they are they take a large amount of damage and I’ve posted it below.

Summary 
local used = false 

script.Parent.Touched:connect(function(part)
	if not used then 
		used = true 
		if part.Parent then
			local human = part.Parent:FindFirstChild("Humanoid")
			if human.Health <= (human.Maxhealth/4) then
			human.Health = human.Health - 999
		end
		wait (3)
		used = false
		end
	end
end)

Could someone point me in the right direction? I’m completely stumped.

Thanks!

2 Likes
#2

Move this to #help-and-feedback:scripting-support and please format your code in a codeblock.

1 Like
#3

Whoops, I’ve moved the topic and added a codeblock. Thanks!

#4

Hi, I see some things that might cause the problem. You should use :Connect instead of lower case :connect. In one line, you’re searching for a humanoid. If it doesn’t find a humanoid, it will return null, so it will error when you try to change it’s health. You also misspelt Humanoid.MaxHealth.

The code now would look like this

local used = false 

script.Parent.Touched:connect(function(part)
    -- will return if used is true
	if used then return end
    used = true
	local human = part.Parent:FindFirstChild("Humanoid")
    -- will return if it doesn't find a humanoid
    if not human then return end
	if human.Health <= (human.MaxHealth / 4) then
	human.Health = human.Health - 999
	wait(3)
	used = false
end)
2 Likes
#5

What exactly isn’t working?​​​​​​​​​​​​​​​​​​​​​

1 Like
#6

So I’ve put this script into a block in the workspace and am touching it while below 25 Health and nothing is happening.

#7

Hi, I changed the :Connect line as you suggested. As for the humanoid maxhealth being misspelt thats actualy by design due to line 7 stating.

local human = part.Parent:FindFirstChild(“Humanoid”)

#8

I see, does the script work now? I haven’t tested it since I wrote it on the fly.

#9

The error is probably here your trying to get the humanoid of the part with :FindFirstChild() use :WaitForChild(“Humanoid”)

local human = part.Parent:WaitForChild("Humanoid")

The code is executed before the humanoid loads and human.Health returns a “nil” value.

1 Like
#10

I gave your reccomendation a shot but nothing changed in regards to the script working. There are no errors in Output or Script Analysis either.

#11

The script is still not functioning as of yet.

#12

Shouldn’t you be checking for players instead? and then the humanoid descendent.

#13

Ok, I understand what happens and this is probably the problem, the script works correctly but if you modify the player’s humanoid health from the explorer it will not work, this happens because when modifying it from the explorer the changes are only visible from the client.

Try looking for another way to set your humanoid health to 25.

Also humanoid.Maxhealth/4 is key sensitive so you should do it like this

humanoid.MaxHealth/4

1 Like
#14

I believe you can get the player from the character (thus proving that the parent of the touched part is a player character) and then find the humanoid as its descendent.

local character = game.Players:GetPlayerFromCharacter(part.Parent)
if not character then return end
local human = character:WaitForChild("Humanoid")
if not human then return end
-- do rest of stuff below
#15

The MaxHealth is what fixed it. It’s always the small things that catch me up. Thanks for the help!

1 Like