Spaghetti code improvements

[pixeldippz]

Completely re-wrote this entire section of code by implementing guard and saved a bunch of lines while making it easier to read. Any tips on how to further squash it down?

Started with this bad boy

Turned it into this and saved a dozen lines

Edit: I changed line 101’s if statement to

if crouching or not sprinting then

and 106 to

if not fwd then return end

as the speed wouldn’t change from 1 to a normal walking speed, lol

Edit 2: Thanks for the input, was able to reduce it further down to this

[bytesleuth]

You could condense the if statements into one

[bytesleuth]

Nvm, I didn’t see they had code in them ignore what I said.

[bytesleuth]

You could add ternary when you’re setting hum.WalkSpeed, idk if that would make it smaller.

[STORMGAMESYT7IP]

In the sprinting section you can do this:

if not sprinting and hum.WalkSpeed ~= speedTarget.mid then
	hum.WalkSpeed += if hum.WalkSpeed < speedTarget.mid then .25 else -.25;
	return
end

Another thing, in the not moving() part you can do:

if not moving() and hum.WalkSpeed ~= 1 then
...
return end

Also, there’s no need for the if hum.WalkSpeed == speedTarget.max line in 107 since there’s nothing after that.

[pixeldippz]

I didn’t even know you could write something like that o.O

[pixeldippz]

Oh, it returns out of that if statement so the game doesn’t keep checking afterwards if the speed is above or below the max.

[bytesleuth]

Yeah that’s what I was talking about lol that’s ternary.

[pixeldippz]

I know about ternary, I just didnt know you could use it doing math operations like that

55 += if X then Y else Z

Pretty freaky

[Askavix]

Have a look into finite state machines.