System that only allows one menu in a table to be active at once?

[FBIagent9903 (ThatFBIGuy)]

As a suggestion if you want to try and call functions from in between scripts, I would suggest trying out ModuleScripts!

[StrongBigeMan9]

@hugtrain

Then it tells me that the boolvalue isnt there anymore?

Ah, that’s probably because of this:

@hugtrain

isOpen = not isOpen

Make sure to change that to isOpen.Value = not isOpen.Value, so that it updates the Value property. Otherwise, it’ll update the variable itself to false instead of referring to the BoolValue object (hopefully I explained that properly).

---

@hugtrain

ImageButton.MouseButton1Click:Connect(toggleGUI())

Edit 1: Also make sure to update the last line of code with the change that @Lauri9 suggested:

ImageButton.MouseButton1Click:Connect(toggleGUI)

Edit 2: And then lastly, consider the suggestion of @FBIagent9903 if you want to create systems that can communicate between scripts. There’s resources on the Roblox Creator Documentation site regarding Modules if you want to learn more.

[hugtrain]

Awesome! It’s working now. I should really be proofreading these better for such simple mistakes.

Thank you so much!

P.S. this error comes up after using it, is this an important error or is it negligable?

It’s making a loop, isnt it

[StrongBigeMan9]

@hugtrain

P.S. this error comes up after using it, is this an important error or is it negligable?

It’s making a loop, isnt it

Yup, the :GetPropertyChangedSignal() listener is calling the function over and over again because isOpen.Value is being changed every time the function is called.

Now that I think about it, I don’t think isOpen.Value = not isOpen.Value would be necessary to include in the function at all, since the necessary changes that need to happen are only related to opening or closing the GUI after you’ve detected the value being changed (so you could remove that from the function and then that error will no longer occur).

[hugtrain]

That makes sense, however, the button no longer works because it cant change the bool value. Naturally, I changed

ImageButton.MouseButton1Click:Connect(toggleGUI())

to

ImageButton.MouseButton1Click:Connect(function()
	if isOpen.Value == true then
		isOpen.Value = false
	elseif isOpen.Value == false then
		isOpen.Value = true
	end
end)

But now I’m running into the same problem where, when the game starts, the code somehow thinks that the variable is true?

When I had the output open and the bool value selected, I clicked the button and it set the bool value to true, but the output says “Attempting to close…”

[StrongBigeMan9]

@hugtrain

That makes sense, however, the button no longer works because it cant change the bool value.

Oh yeah, I forgot that it’s not being updated from a single place somewhere else in the game.

Before trying to explain a possible solution, I think it’d be good to have some more clarification about how the menus are set up, first.

• Are all of the menus within the same ScreenGui?

• Were you planning on having these functions included in separate scripts for each menu, or would everything be in a single script?

• Would this singular BoolValue be referenced by each of the menus?

---

And sorry about taking quite a while to help ya figure out a viable solution. It’s past 6 AM here and I should have gone to sleep a long time ago… so after this I’m going to actually get some rest haha

[hugtrain]

1. Right now, all the menus are seperate screenGUIs. “Main” is the toolbar with the buttons on it.
   
   Maybe it would be better to consolidate it under one Screen gui
   

2. The button controls the frames right now, which may not be a great idea for efficiency and organization.
   

3. The buttons would reference the bool values of all the other menus (except for the toolbar and main start menu).

[StrongBigeMan9]

Thanks for clarifying! With all of that in mind, here’s one possible way of going about that should be able to be scaled fairly easily *(without using BoolValues, though), even if you create more menus.

1. Create a ModuleScript in the ReplicatedStorage that will act as the centralized place for handling the opening / closing of GUIs and keeping track of the menu that is currently open.

2. Whenever one of the buttons that is meant to open or close the Frame is pressed, have it call the relevant function in the ModuleScript so it can handle everything without needing to copy and paste the functions into scripts for each menu.

If you have any questions, feel free to ask! Although I may not respond for several hours because it is now 7 AM and I am going to sleep lol.

Example ModuleScript

local MenuModule = {}

MenuModule.activeMenu = nil

local function openGUI(Frame, tweenInfo) -- Function based on what was included in the original post
    if not tweenInfo then
        -- Consider creating a backup tweenInfo in case one wasn't sent through
    end

    local targetPosition = UDim2.new(0.5, 0, 0.5, 0) -- Center of the screen
    local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
end

local function closeGUI(Frame, tweenInfo) -- Function based on what was included in the original post
    if not tweenInfo then
        -- Consider creating a backup tweenInfo in case one wasn't sent through
    end

    local targetPosition = UDim2.new(0.5, 0, 1.5, 0) -- Below the screen
    local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
    tween:Play()
end

function MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
    if Frame ~= nil then
        if desiredFrameVisibility == true then

            local activeMenuCheck = MenuModule.activeMenu
            if activeMenuCheck ~= nil then
                closeGUI(activeMenuCheck)
            end
--[[
Consider creating a backup tweenInfo somewhere (preferably in this Module,
for ease of access), so that in the case where the currently active menu needs,
to be closed as a result of another menu being opened, the currently visible Frame
will have appropriate settings given the desired style of the closing animation.
--]]

            MenuModule.activeMenu = Frame
            openGUI(Frame, tweenInfo)
            
        elseif desiredFrameVisibility == false then
            closeGUI(Frame, tweenInfo)
        end
    end
end

Example of a LocalScript communicating with the ModuleScript

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local MenuModule = require(ReplicatedStorage.MenuModule)

local ImageButton -- Reference to ImageButton here
local Frame -- Reference to relevant Frame here

local function getTweenInfo()
--[[ If this needs to be specific for each menu, then you can retrieve it
in the same way you are already, but then have it sent to the ModuleScript.
Otherwise, a universal TweenInfo could be stored in the ModuleScript so these
LocalScripts don't have to communicate it every time a menu needs to be
opened or closed --]]

-- If the function below calls this function, have it return the TweenInfo
end

ImageButton.Activated:Connect(function()
    local currentFrameVisibility = Frame.Visible
    local desiredFrameVisibility = not currentFrameVisibility
--[[ If the Frame is currently invisible, the menu is closed. Since the player
pressed the button, they want to open it, so we can just reverse the value of
Frame.Visible and send that to the ModuleScript so it knows what value it
should be updated to --]]

    local tweenInfo = getTweenInfo()

    MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
end)

[hugtrain]

Thank you. Your help is greatly appreciated. Sleep well!

[hugtrain]

Okay, after a while of trial and error, I ended up with these two scripts.
They work well, no errors yet. But the GUIs are still overlapping. Can you help me start on the activeMenu check?

Module

local MenuModule = {}

MenuModule.activeMenu = nil
local TweenService = game:GetService("TweenService")

local function openGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		return TweenInfo.new(
			0.5, -- Time
			Enum.EasingStyle.Quad, -- Easing style
			Enum.EasingDirection.Out, -- Easing direction
			0, -- Repeat count (0 = no repeat)
			false, -- Reverses (true = reverse)
			0 -- Delay time   
		)
	end
	local targetPosition = UDim2.new(0.5, 0, 0.5, 0) -- Center of the screen
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
end

local function closeGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		return TweenInfo.new(
			0.5, -- Time
			Enum.EasingStyle.Quad, -- Easing style
			Enum.EasingDirection.Out, -- Easing direction
			0, -- Repeat count (0 = no repeat)
			false, -- Reverses (true = reverse)
			0 -- Delay time
		)
	end
	
	local targetPosition = UDim2.new(0.5, 0, 1.5, 0) -- Below the screen 
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
	
end

function MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	print(MenuModule.activeMenu)
	if Frame ~= nil then
		if desiredFrameVisibility == true then

			local activeMenuCheck = MenuModule.activeMenu
			if activeMenuCheck ~= nil then
				closeGUI(activeMenuCheck)
			end
			
			MenuModule.activeMenu = Frame
			openGUI(Frame, tweenInfo)

		elseif desiredFrameVisibility == false then
			closeGUI(Frame, tweenInfo)
		end

	end
end

return MenuModule

Local Script

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local MenuModule = require(ReplicatedStorage.MenuModule)
print(MenuModule)

local associatedButtonName = script.Parent.Name

local ImageButton = script.Parent.Parent.Parent:WaitForChild("Toolbar"):WaitForChild(associatedButtonName)
local Frame = script.Parent

local function getTweenInfo()
	    return TweenInfo.new(
        0.5, -- Time
        Enum.EasingStyle.Quad, -- Easing style
        Enum.EasingDirection.Out, -- Easing direction
        0, -- Repeat count (0 = no repeat)
        false, -- Reverses (true = reverse)
        0 -- Delay time
    )

end
local currentFrameVisibility = false
ImageButton.MouseButton1Click:Connect(function()

	local desiredFrameVisibility = not currentFrameVisibility

	local tweenInfo = getTweenInfo()
	
	MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	
	currentFrameVisibility = not currentFrameVisibility
	
end)```

[StrongBigeMan9]

@hugtrain

I ended up with these two scripts.
They work well, no errors yet. But the GUIs are still overlapping. Can you help me start on the activeMenu check?

Sure! I think I know which section of code is causing that to happen, but there are a few things I’d like to mention:

@hugtrain

local currentFrameVisibility = false
ImageButton.MouseButton1Click:Connect(function()

	local desiredFrameVisibility = not currentFrameVisibility

	local tweenInfo = getTweenInfo()
	
	MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	
	currentFrameVisibility = not currentFrameVisibility
	
end)

For the example LocalScript code, the way that currentFrameVisibility and desiredFrameVisibility are defined and updated could cause some issues. For example, if any of the Menus happen to start with their Visible property set to true and the player tried to close it directly, it would require them to press it twice because the script would begin by setting desiredFrameVisibility to true and sending a request to the module to make it visible.

In addition to that, because currentFrameVisibility is only updated upon the activation of that ImageButton, this would very quickly create discrepancies when another menu is opened, since it would cause this frame to be automatically closed by the closeGUI function in the module without updating the currentFrameVisibility variable in the LocalScript (since the player needed to press the ImageButton to do so).

As a result, it’d be more reliable to move currentFrameVisibility into the function and to directly reference the Frame.Visible property for currentFrameVisibility, as that would ensure that the function will always be referring to the current visibility of the Frame whenever the player decides to press the button.

---

@hugtrain

	if not tweenInfo then
		return TweenInfo.new(
			0.5, -- Time
			Enum.EasingStyle.Quad, -- Easing style
			Enum.EasingDirection.Out, -- Easing direction
			0, -- Repeat count (0 = no repeat)
			false, -- Reverses (true = reverse)
			0 -- Delay time   
		)
	end

Within the openGUI and closeGUI functions, you wouldn’t need to return the TweenInfo since it would be used in those functions (and returning is typically meant for sending something back to the line of code where the function was called from). In this case, you would just need to override the tweenInfo variable with that newly created TweenInfo. And since both of the backup TweenInfos happen to have the same settings, it may be better to keep that stored in a single place (such as within the module’s table) for ease of access and organization.

As far as I understand, this is what was causing the menus to continue overlapping, since the activeMenu did not have a tweenInfo sent with it to the closeGUI function. As a result, it would have to create a new TweenInfo, but when it reaches that part of the function and it returns it, it stops the rest of the function from running, meaning that the frame is not moved off of the screen.

There’s also one more change I’d make to the ModuleScript that I didn’t consider earlier, which would be to set activeMenu to nil if the updateCurrentMenu function is called with the desiredFrameVisibility being set to false, so that the next time a menu is opened, it won’t try to set that menu’s visibility to false again since it was already manually closed by the player. It would have still worked properly without making this change, but this creates more consistency.

---

Here’s an example revision of both of those scripts:

Revised ModuleScript Example

local MenuModule = {}

MenuModule.activeMenu = nil
MenuModule.defaultTweenInfo = TweenInfo.new(
    0.5, -- Time
    Enum.EasingStyle.Quad, -- Easing style
    Enum.EasingDirection.Out, -- Easing direction
    0, -- Repeat count (0 = no repeat)
    false, -- Reverses (true = reverse)
    0 -- Delay time   
)

local TweenService = game:GetService("TweenService")

local function openGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		tweenInfo = MenuModule.defaultTweenInfo
	end

	local targetPosition = UDim2.new(0.5, 0, 0.5, 0) -- Center of the screen
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
end

local function closeGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		tweenInfo = MenuModule.defaultTweenInfo
	end
	
	local targetPosition = UDim2.new(0.5, 0, 1.5, 0) -- Below the screen 
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
end

function MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	print(MenuModule.activeMenu)
	if Frame ~= nil then
		if desiredFrameVisibility == true then

			local activeMenuCheck = MenuModule.activeMenu
			if activeMenuCheck ~= nil then
				closeGUI(activeMenuCheck)
			end
			
			MenuModule.activeMenu = Frame
			openGUI(Frame, tweenInfo)

		elseif desiredFrameVisibility == false then
            if Frame == MenuModule.activeMenu then
                MenuModule.activeMenu = nil
            end

			closeGUI(Frame, tweenInfo)
		end

	end
end

return MenuModule

Revised LocalScript Example

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local MenuModule = require(ReplicatedStorage.MenuModule)
print(MenuModule)


local Frame = script.Parent
local associatedButtonName = Frame.Name

local ToolBar = Frame.Parent.Parent:WaitForChild("Toolbar")
--[[
I'd recommend defining the other objects (e.g. Frame.Parent and then
the Parent of that Parent) so that if you ever change its hierarchy, you
know what object it was supposed to be referring to at each step
--]]
local ImageButton = Toolbar:WaitForChild(associatedButtonName)


local function getTweenInfo()
    return TweenInfo.new(
        0.5, -- Time
        Enum.EasingStyle.Quad, -- Easing style
        Enum.EasingDirection.Out, -- Easing direction
        0, -- Repeat count (0 = no repeat)
        false, -- Reverses (true = reverse)
        0 -- Delay time
    )
end

ImageButton.MouseButton1Click:Connect(function()
    local currentFrameVisibility = Frame.Visible
	local desiredFrameVisibility = not currentFrameVisibility

	local tweenInfo = getTweenInfo()
	
	MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
end)

[hugtrain]

Is there a way to do this without making it invisible? I want the tween to be visible.
Secondly, when I didn’t put the tweenInfo in again, it gave me the error “Argument 2 missing or nil.” when opening a second time. (Start > Open menu > Close menu > Open menu (ERROR))

And lastly, how can I set up a close button within the frame?

Again, thanks for your help!

[StrongBigeMan9]

@hugtrain

Is there a way to do this without making it invisible? I want the tween to be visible.

The Tween would not be invisible; the currentFrameVisibility variable is just referring to the current Visibility value of the Frame, and when desiredFrameVisibility is set to not currentFrameVisibility, it’s only storing a value in that variable which is the opposite of currentFrameVisibility. It doesn’t actually change the visibility of the frame, it stores the value in the variable so it can be sent to the updateCurrentMenu function within the module.

@hugtrain

Secondly, when I didn’t put the tweenInfo in again, it gave me the error “Argument 2 missing or nil.” when opening a second time.

Which function is that error coming from? *And, so we’re on the same page, what do both of the scripts look like now?

@hugtrain

And lastly, how can I set up a close button within the frame?

Ah, I had structured the LocalScript in a way where if the player pressed the same ImageButton that they pressed to open the menu, it would close it. If you wanted a completely separate button to close it (with the option to also click the original button that had opened it), you could create a new function within the LocalScript which calls the updateCurrentMenu function exclusively with a second value of false. Here’s an example:

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local MenuModule = require(ReplicatedStorage.MenuModule)
print(MenuModule)


local Frame = script.Parent
local associatedButtonName = Frame.Name
local closeButton -- Reference to the newly created "close menu" button here

local ToolBar = Frame.Parent.Parent:WaitForChild("Toolbar")
--[[
I'd recommend defining the other objects (e.g. Frame.Parent and then
the Parent of that Parent) so that if you ever change its hierarchy, you
know what object it was supposed to be referring to at each step
--]]
local ImageButton = Toolbar:WaitForChild(associatedButtonName)


local function getTweenInfo()
    return TweenInfo.new(
        0.5, -- Time
        Enum.EasingStyle.Quad, -- Easing style
        Enum.EasingDirection.Out, -- Easing direction
        0, -- Repeat count (0 = no repeat)
        false, -- Reverses (true = reverse)
        0 -- Delay time
    )
end

ImageButton.MouseButton1Click:Connect(function()
    local currentFrameVisibility = Frame.Visible
	local desiredFrameVisibility = not currentFrameVisibility

	local tweenInfo = getTweenInfo()
	
	MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
end)

closeButton.MouseButton1Click:Connect(function()
    local tweenInfo = getTweenInfo()
    MenuModule.updateCurrentMenu(Frame, false, tweenInfo)
end)

[hugtrain]

The Tween would not be invisible; the currentFrameVisibility variable is just referring to the current Visibility value of the Frame,

But when Frame.Visible is set to false, the Frame wont be rendered. I also don’t see anything that would switch that value, wouldn’t it stay at true forever? If it wasn’t clear, I am not changing the value of the Frame.Visible property, I’m just hiding it off screen. Would you explain more?

Which function is that error coming from? *And, so we’re on the same page, what do both of the scripts look like now?

I’m pretty sure it was coming from the Module, but I cant check now because Im not at my computer. I deduced that it was talking about openGUI(Frame, tweenInfo) so I put the tweenInfo in again.
Both scripts right now look like the ones I sent here

you could create a new function within the LocalScript which calls the updateCurrentMenu function exclusively with a second value of false . Here’s an example:

Thanks, that makes sense!

[StrongBigeMan9]

@hugtrain

If it wasn’t clear, I am not changing the value of the Frame.Visible property, I’m just hiding it off screen.

Ahhh for some reason I had been stuck thinking that the Frame’s visibility was also being set to false after it went off-screen. Thanks for pointing that out because I kept missing that every time lol.

In that case, I have an idea which would simultaneously allow for the Tweens within the open and close GUI to appear as intended while also making the usage of referring to Frame.Visible possible so that the currentFrameVisibility variable would not be susceptible to returning inaccurate values if the menu is closed from the opening of a different menu.

Ideas

• When closing a menu, listen for the completion of the Tween with Tween.Completed, and then update the Frame’s visibility to false.

local function closeGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		tweenInfo = MenuModule.defaultTweenInfo
	end
	
	local targetPosition = UDim2.new(0.5, 0, 1.5, 0) -- Below the screen 
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
    tween.Completed:Wait()

    Frame.Visible = false
end

• When opening a menu, immediately set the Frame’s visibility to true and then play the Tween.

local function openGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		tweenInfo = MenuModule.defaultTweenInfo
	end

    Frame.Visible = true

	local targetPosition = UDim2.new(0.5, 0, 0.5, 0) -- Center of the screen
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	tween:Play()
end

This would ensure that the Frame is not unnecessarily set to visible when it’s meant to be hidden off-screen while avoiding any interference with the visualization of the Tweens (making sure that it doesn’t suddenly appear or disappear while the Tween is still playing), all while allowing the function in the LocalScript to be able to refer to the current “state” (open or closed) of the menu, through its Visible property.

---

@hugtrain

Both scripts right now look like the ones I sent here

Oh; the ModuleScript code in that post still has the return TweenInfo in both the openGUI and closeGUI functions, which would be stopping the function from running when there is no TweenInfo provided.

I explained an example solution for that and a possible revision in the post right after you sent that one, if you want to give that a try (although I don’t think that is what would be causing the error to appear, because it would stop the function before it had a chance to error, if I understand correctly).

*If you decide to also go with the idea for updating the Frame’s visibility before / after the Tweens, then the example LocalScript code I provided in that same post would be compatible with that (since it’s checking the value of Frame.Visible when the player presses the ImageButton).

---

@hugtrain

I’m pretty sure it was coming from the Module, but I cant check now because Im not at my computer. I deduced that it was talking about openGUI(Frame, tweenInfo) so I put the tweenInfo in again.

Whenever you have the time to check it, please let me know (no rush)!

[hugtrain]

@StrongBigeMan9

	print(MenuModule.activeMenu)
	if Frame ~= nil then
		if desiredFrameVisibility == true then

			local activeMenuCheck = MenuModule.activeMenu
			if activeMenuCheck ~= nil then
				closeGUI(activeMenuCheck)
			end
			
			MenuModule.activeMenu = Frame
			openGUI(Frame, tweenInfo)

		elseif desiredFrameVisibility == false then
            if Frame == MenuModule.activeMenu then
                MenuModule.activeMenu = nil
            end

			closeGUI(Frame, tweenInfo)

Works Perfectly!
robloxapp-20240429-1655535.wmv (637.8 KB)

The only other thing I’d note is that it takes a bit for the new menu to open? Is there anyway the new menu can come up while the old one leaves? Maybe using delay()?

[StrongBigeMan9]

@hugtrain

The only other thing I’d note is that it takes a bit for the new menu to open? Is there anyway the new menu can come up while the old one leaves?

Oh yeah, that’s because the closeGUI function is called first in that scenario, and it yields because of the tween.Completed:Wait(), making it wait until that’s completed before going back and calling openGUI on the new menu.

One way to make both Tweens run simultaneously in that scenario would be to call task.spawn() on the closeGUI function. An analogy for how that works could be if the two functions were in a checkout line at the store; instead of making openGUI wait for closeGUI to finish scanning every item and paying for it, closeGUI moves to a different checkout line so both can complete their tasks at the same time.

So the only thing that would change is in the updateCurrentMenu function of the ModuleScript when the if desiredFrameVisible == true and if activeMenuCheck ~= nil conditions are met.

-- Before
closeGUI(activeMenuCheck)

-- After
task.spawn(closeGUI, activeMenuCheck)

And just to make it easier to know what that entire function looks like after making that change, here it is:

function MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	print(MenuModule.activeMenu)
	if Frame ~= nil then
		if desiredFrameVisibility == true then

			local activeMenuCheck = MenuModule.activeMenu
			if activeMenuCheck ~= nil then
				task.spawn(closeGUI, activeMenuCheck) -- Updated
			end
			
			MenuModule.activeMenu = Frame
			openGUI(Frame, tweenInfo)

		elseif desiredFrameVisibility == false then
            if Frame == MenuModule.activeMenu then
                MenuModule.activeMenu = nil
            end

			closeGUI(Frame, tweenInfo)
		end

	end
end

---

If you’d like to, you could post the full completed ModuleScript and LocalScript code here after making that change so that anyone else who ends up reading this thread will know what the “final” solution for the original question is, since it has now changed a decent amount since I wrote the post that you marked as a solution.

[hugtrain]

Thanks, nice analogy.

I’ll post the final script tomorrow.

[hugtrain]

Here is the Final Script as of now.

Please feel free to use this code!

MODULE SCRIPT

local MenuModule = {}

MenuModule.activeMenu = nil
MenuModule.defaultTweenInfo = TweenInfo.new(
	0.5, -- Time
	Enum.EasingStyle.Quad, -- Easing style
	Enum.EasingDirection.Out, -- Easing direction
	0, -- Repeat count (0 = no repeat)
	false, -- Reverses (true = reverse)
	0 -- Delay time   
)
local TweenService = game:GetService("TweenService")

local function openGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		tweenInfo = MenuModule.defaultTweenInfo
	end
	local targetPosition = UDim2.new(0.5, 0, 0.5, 0) -- Center of the screen
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	
	Frame.Visible = true
	tween:Play()
	
end

local function closeGUI(Frame, tweenInfo) -- Function based on what was included in the original post
	if not tweenInfo then
		tweenInfo = MenuModule.defaultTweenInfo
	end
	
	local targetPosition = UDim2.new(0.5, 0, 1.5, 0) -- Below the screen 
	local tween = TweenService:Create(Frame, tweenInfo, {Position = targetPosition})
	
	tween:Play()
	tween.Completed:Wait()
	
	Frame.Visible = false
	
end

function MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	print(MenuModule.activeMenu)
	if Frame ~= nil then
		if desiredFrameVisibility == true then

			local activeMenuCheck = MenuModule.activeMenu
			if activeMenuCheck ~= nil then
				task.spawn(closeGUI, activeMenuCheck)
			end
			
			MenuModule.activeMenu = Frame
			openGUI(Frame, tweenInfo)

		elseif desiredFrameVisibility == false then
            if Frame == MenuModule.activeMenu then
                MenuModule.activeMenu = nil
            end

			closeGUI(Frame, tweenInfo)
		end

	end
end
return MenuModule

LOCAL SCRIPT

local ReplicatedStorage = game:GetService("ReplicatedStorage")
local MenuModule = require(ReplicatedStorage.Modules.MenuModule)
print(MenuModule)

local Frame = script.Parent
local associatedButtonName = Frame.Name

local ImageButton = Frame.Parent.Parent:WaitForChild("Bottom Container"):WaitForChild("Toolbar"):WaitForChild(associatedButtonName)
local closeButton = Frame:WaitForChild("Close")

local function getTweenInfo()
	    return TweenInfo.new(
        0.5, -- Time
        Enum.EasingStyle.Quad, -- Easing style
        Enum.EasingDirection.InOut, -- Easing direction
        0, -- Repeat count (0 = no repeat)
        false, -- Reverses (true = reverse)
        0 -- Delay time
    )
--[[ If this needs to be specific for each menu, then you can retrieve it
in the same way you are already, but then have it sent to the ModuleScript.
Otherwise, a universal TweenInfo could be stored in the ModuleScript so these
LocalScripts don't have to communicate it every time a menu needs to be
opened or closed --]]

	-- If the function below calls this function, have it return the TweenInfo
end

ImageButton.MouseButton1Click:Connect(function()
	local currentFrameVisibility = Frame.Visible
	local desiredFrameVisibility = not currentFrameVisibility
--[[ If the Frame is currently invisible, the menu is closed. Since the player
pressed the button, they want to open it, so we can just reverse the value of
Frame.Visible and send that to the ModuleScript so it knows what value it
should be updated to --]]

	local tweenInfo = getTweenInfo()
	
	MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
	print(MenuModule)
	
	currentFrameVisibility = not currentFrameVisibility
	
end)

closeButton.MouseButton1Click:Connect(function()
		local currentFrameVisibility = true
		local desiredFrameVisibility = false
		local tweenInfo = getTweenInfo()
		MenuModule.updateCurrentMenu(Frame, desiredFrameVisibility, tweenInfo)
		print(MenuModule)

		currentFrameVisibility = not currentFrameVisibility

	end)