The code is not working as intended

itzmerose_12 · November 6, 2021, 3:17pm

itzmerose_12 · November 7, 2021, 3:59pm

hey dude are those screenshots enough?

D4nisback3lbz · November 7, 2021, 5:52pm

Sorry. I am have been very busy, and also I was trying to fix one of my old projects, and haven’t been on the devforum in a while. And yes, those are enough.

D4nisback3lbz · November 7, 2021, 6:04pm

Are you trying to make something like this?

local function checkCoins()
    local plr = game.Players.LocalPlayer
    
    if plr.STATSHOLDERNAME.STATNAME.Value ~= 0 then -- Replace STATSHOLDERNAME with the name of the item/folder the stat is in, then change STATNAME to the name of stat, e.g coins.
        game.Players.PlayerGUI.tools_gui.tools_frame.ScrollingFrame:WaitForChild("buy all").Visible = true
    else
        game.Players.PlayerGUI.tools_gui.tools_frame.ScrollingFrame:WaitForChild("buy all").Visible = false
    end
end

checkCoins()

itzmerose_12 · November 8, 2021, 6:07am

PlayerGUI is not a valid member of Players “Players”
and yes with a few changes if the coins’ value is greater than the tools’ cost then only it should be visible. I tried to make those changes.

local function checkCoins()
	local plr = game.Players.LocalPlayer

	if plr.leaderstats.Coins.Value ~=0  then -- Replace STATSHOLDERNAME with the name of the item/folder the stat is in, then change STATNAME to the name of stat, e.g coins.
		game.Players.PlayerGUI.tools_gui.tools_frame:WaitForChild("canbuy").Visible = true
		game.Players.PlayerGui.tools_gui.tools_frame:WaitForChild("status").Text = "BUY"
		game.Players.PlayerGui.tools_gui.tools_frame:WaitForChild("cant_buy").Visible = false
	else
		game.Players.PlayerGUI.tools_gui.tools_frame:WaitForChild("can_buy").Visible = false
		game.Players.PlayerGUI.tools_gui.tools_frame:WaitForChild("status").Text = "CANT BUY!"
		game.Players.PlayerGUI.tools_gui.tools_frame:WaitForChild("cant_buy").Visible = false
	end
end

checkCoins()

BANSA168 · November 8, 2021, 10:30am

I don’t know if you managed to fix the script but I’d recommend adding this to your code if you didn’t already.

plr.leaderstats.Coins:GetPropertyChangedSignal('Value'):Connect(function()
    checkCoins()
end)

So this’ll call the checkCains() function whenever your coins value changes.

itzmerose_12 · November 8, 2021, 10:39am

hey i added that lines after i sent that script and also now i dont have any errors in my output tab now idk why

BANSA168 · November 8, 2021, 10:50am

Does the script work as intented now or it’s still broken?

itzmerose_12 · November 8, 2021, 1:32pm

its still broken. I debugged it too everything prints.

itzmerose_12 · November 9, 2021, 2:27pm

by changes i mean when the player has more or enough coins to buy a tool then the buy button will be visible

VikkiVuk · November 9, 2021, 2:43pm

this is checking if the coins are NOT 0 and not above the price try something like this

local function checkCoins()
	local plr = game.Players.LocalPlayer

	if plr.leaderstats.Coins.Value >= price  then
		plr.PlayerGui.tools_gui.tools_frame:WaitForChild("canbuy").Visible = true
		plr.PlayerGui.tools_gui.tools_frame:WaitForChild("status").Text = "BUY"
		plr.PlayerGui.tools_gui.tools_frame:WaitForChild("cant_buy").Visible = false
	else
		plr.PlayerGui.tools_gui.tools_frame:WaitForChild("can_buy").Visible = false
		plr.PlayerGui.tools_gui.tools_frame:WaitForChild("status").Text = "CANT BUY!"
		plr.PlayerGui.tools_gui.tools_frame:WaitForChild("cant_buy").Visible = true
	end
end

checkCoins()

~= (not equal to)
>= (more than or equal to)
== (equal to)
<= (less or equal to)
< (less than)
> (more than)

also this needs to be a local script, thats either in the starter gui or the starter player

itzmerose_12 · November 10, 2021, 8:38am

it still doesnt work

local function checkCoins()
	local plr = game.Players.LocalPlayer
	local frame = game.Player.PlayerGUI.tools_gui.tools_frame
	local price = tonumber(frame.price.Text)
	if plr.leaderstats.Coins.Value >= price  then -- Replace STATSHOLDERNAME with the name of the item/folder the stat is in, then change STATNAME to the name of stat, e.g coins.
		frame:WaitForChild("canbuy").Visible = true
		frame:WaitForChild("status").Text = "BUY"
		frame:WaitForChild("cant_buy").Visible = false
	else
		frame:WaitForChild("can_buy").Visible = false
		frame:WaitForChild("status").Text = "CANT BUY!"
		frame:WaitForChild("cant_buy").Visible = false
	end
	plr.leaderstats.Coins:GetPropertyChangedSignal('Value'):Connect(function()
		checkCoins()
	end)
end

VikkiVuk · November 10, 2021, 10:26am

Its PlayerGui not PlayerGUI its case sensitive. And put the

outside of the function otherwise it wont work. I also see that you put game.Player.PlayerGUI this wont work. Try this:

local plr = game.Players.LocalPlayer

local function checkCoins()
	local frame = plr.PlayerGui.tools_gui.tools_frame
	local price = tonumber(frame.price.Text)
	if plr.leaderstats.Coins.Value >= price  then -- Replace STATSHOLDERNAME with the name of the item/folder the stat is in, then change STATNAME to the name of stat, e.g coins.
		frame:WaitForChild("canbuy").Visible = true
		frame:WaitForChild("status").Text = "BUY"
		frame:WaitForChild("cant_buy").Visible = false
	else
		frame:WaitForChild("can_buy").Visible = false
		frame:WaitForChild("status").Text = "CANT BUY!"
		frame:WaitForChild("cant_buy").Visible = true
	end
end

plr.leaderstats.Coins:GetPropertyChangedSignal('Value'):Connect(function()
	checkCoins()
end)

itzmerose_12 · November 10, 2021, 11:25am

idk why but it still doesn’t work

VikkiVuk · November 10, 2021, 11:26am

Can you screenshot the hierarchy of your explorer (by this I mean screenshot the whole explorer)

itzmerose_12 · November 10, 2021, 1:27pm

VikkiVuk · November 10, 2021, 1:54pm

where is the script you are doing this in and what is it called?

itzmerose_12 · November 10, 2021, 3:47pm

in startplayer and its called “localscriptbuy”

VikkiVuk · November 10, 2021, 4:27pm

Okay, heres what should work:

Put the Localscript inside of StarterGui.
Inside of the local script put this code:

game.Players.LocalPlayer.leaderstats.Coins.Changed:Connect(function()
    local truecoins = game.ReplicatedStorage.REMOTE_FUNCTION_NAME:InvokeServer()
    local frame = script.Parent:FindFirstChild("tools_gui"):FindFirstChild("tools_frame")
    if (truecoins >= tonumber(frame.price.Text)) then
         frame.canbuy.Visible = true
         frame.status.Text = "BUY"
         frame:FindFirstChild("cant_buy").Visible = false
    else
         frame.canbuy.Visible = false
         frame.status.Text = "NOT ENOUGH COINS"
         frame:FindFirstChild("cant_buy").Visible = true
    end
end)

Make a RemoteFunction inside of ReplicatedStorage named whatever you want, this will be used to get the leader stats data and the price from the server-side so that exploiters cant cheat to get the thing.
Make a server script inside of ServerScriptService and put this in it:

game.ReplicatedStorage.REMOTE_FUNCTION_NAME.OnServerInvoke = function(plr)
    return plr.leaderstats.Coins.Value
end

This is the way to securely get the coins and show it. The other way you can do this if you just put the localscript in StarterPlayer.StarterPlayerScripts, but this is the better version of the script.

(the script doesnt work because its in starterplayer only and not in starterplayerscripts)

itzmerose_12 · November 10, 2021, 4:34pm

i got an error
Players.itzmerose_12.PlayerGui.feetus:1: attempt to index number with ‘Changed’