The Roblox paintbucket is very OP

GIitzDev · July 13, 2022, 8:24pm

I’m currently working on a war RP game & added the Roblox paint bucket tool to paint lands. The problem is that the paint bucket will paint everything that’s in the workspace & when I try modifying the script it’ll stop being FE.
Original LocalScript by Roblox.

-- // Recreated by StarWars
local Players = game:GetService("Players")
local RunService = game:GetService("RunService")

local Player = Players.LocalPlayer
local Mouse = Player:GetMouse()
local PlayerGui = Player:WaitForChild("PlayerGui")

local Tool = script.Parent
local Handle = Tool:WaitForChild("Handle")
local PaintSound = Handle:WaitForChild("PaintSound")
local PaletteGui = script:WaitForChild("PaletteGui")

local Remotes = Tool:WaitForChild("Remotes")
local ServerControls = Remotes:WaitForChild("ServerControls")

local ColorSelection = BrickColor.new("White").Color

local CurrentGui = nil
local SelectionBox = Instance.new("SelectionBox")
SelectionBox.Color3 = ColorSelection
SelectionBox.Parent = PlayerGui

local LineHandle = Instance.new("LineHandleAdornment")
LineHandle.Color3 = ColorSelection
LineHandle.Thickness = 5
LineHandle.Parent = PlayerGui

local ToolEquipped = false
local InPalette = false

local function SetupGui()
	if CurrentGui then
		CurrentGui:Destroy()
	end	
	
	CurrentGui = PaletteGui:Clone()
	local Palette = CurrentGui:WaitForChild("ColorPallet")	
	local ColorTitle = Palette:WaitForChild("ColorTitle")
	
	Palette.MouseEnter:Connect(function()
		Mouse.Icon = ""
		InPalette = true
	end)
	
	Palette.MouseLeave:Connect(function()
		InPalette = false
	end)
	
	for _, button in next, Palette:GetChildren() do
		if button:IsA("GuiButton") then
			button.MouseButton1Click:Connect(function()
				ColorSelection = BrickColor.new(button.Name).Color
				ColorTitle.Text = button.Name
				SelectionBox.Color3 = ColorSelection
				LineHandle.Color3 = ColorSelection
				ColorTitle:WaitForChild("ColorFrame").BackgroundColor3 = ColorSelection
			end)
		end
	end
	
	CurrentGui.Parent = PlayerGui
end

local function UpdateSelectionBox()
	if Mouse and Mouse.Target and SelectionBox then
		SelectionBox.Adornee = Mouse.Target
		if LineHandle and Player.Character then
			LineHandle.Adornee = Player.Character.PrimaryPart
			local OffsetTargetPosition = Player.Character.PrimaryPart.CFrame:pointToObjectSpace(Mouse.Hit.p)
			LineHandle.CFrame = CFrame.new(LineHandle.CFrame.p, OffsetTargetPosition)
			LineHandle.Length = (Mouse.Target.CFrame.p - Player.Character.PrimaryPart.CFrame.p).Magnitude
		end
	end
end

Tool.Equipped:Connect(function(mouse) 
	if ToolEquipped then return end 
	
	ColorSelection = BrickColor.new("White").Color
	ToolEquipped = true
	mouse.Button1Up:Connect(function()
		if ColorSelection then
			local Data = {Part = mouse.Target, Color = ColorSelection}
			ServerControls:InvokeServer("PaintPart", Data)
			PaintSound:Play()
			PaintSound.PlaybackSpeed = 0.9 + (math.random() * .1)
		end		
	end)
	mouse.Move:Connect(function()
		if CurrentGui and not InPalette then
			mouse.Icon = "rbxasset://textures\\FillCursor.png"
		end
	end)
	
	SelectionBox.Color3 = ColorSelection
	LineHandle.Color3 = ColorSelection
		
	RunService:BindToRenderStep("UpdateSelectionBox", Enum.RenderPriority.Input.Value, UpdateSelectionBox)	
	SetupGui()
end)

Tool.Unequipped:Connect(function()
	if not ToolEquipped then return end 
	ToolEquipped = false
	if CurrentGui then
		CurrentGui:Destroy()
	end
	
	RunService:UnbindFromRenderStep("UpdateSelectionBox")
	if SelectionBox then
		SelectionBox.Adornee = nil
	end
	if LineHandle then
		LineHandle.Adornee = nil
	end

	InPalette = false
	CurrentGui = nil
	Mouse.Icon = ""
end)

Modified by me, To know which part was modified search for the Comment.

-- // Recreated by StarWars
local Players = game:GetService("Players")
local RunService = game:GetService("RunService")

local Player = Players.LocalPlayer
local Mouse = Player:GetMouse()
local PlayerGui = Player:WaitForChild("PlayerGui")

local Tool = script.Parent
local Handle = Tool:WaitForChild("Handle")
local PaintSound = Handle:WaitForChild("PaintSound")
local PaletteGui = script:WaitForChild("PaletteGui")

local Remotes = Tool:WaitForChild("Remotes")
local ServerControls = Remotes:WaitForChild("ServerControls")

local ColorSelection = script.Parent:GetAttribute("ColorThing")

local CurrentGui = nil
local SelectionBox = Instance.new("SelectionBox")
SelectionBox.Color3 = ColorSelection
SelectionBox.Parent = PlayerGui

local LineHandle = Instance.new("LineHandleAdornment")
LineHandle.Color3 = ColorSelection
LineHandle.Thickness = 5
LineHandle.Parent = PlayerGui

local ToolEquipped = false
local InPalette = false

local function SetupGui()
	if CurrentGui then
		CurrentGui:Destroy()
	end	
	
	CurrentGui = PaletteGui:Clone()
	local Palette = CurrentGui:WaitForChild("ColorPallet")	
	local ColorTitle = Palette:WaitForChild("ColorTitle")
	
	Palette.MouseEnter:Connect(function()
		Mouse.Icon = ""
		InPalette = true
	end)
	
	Palette.MouseLeave:Connect(function()
		InPalette = false
	end)
	
	for _, button in next, Palette:GetChildren() do
		if button:IsA("GuiButton") then
			button.MouseButton1Click:Connect(function()
				ColorSelection = BrickColor.new(button.Name).Color
				ColorTitle.Text = button.Name
				SelectionBox.Color3 = ColorSelection
				LineHandle.Color3 = ColorSelection
				ColorTitle:WaitForChild("ColorFrame").BackgroundColor3 = ColorSelection
			end)
		end
	end
	
	CurrentGui.Parent = PlayerGui
end

local function UpdateSelectionBox()
	if Mouse and Mouse.Target and SelectionBox then
		SelectionBox.Adornee = Mouse.Target
		if LineHandle and Player.Character then
			LineHandle.Adornee = Player.Character.PrimaryPart
			local OffsetTargetPosition = Player.Character.PrimaryPart.CFrame:pointToObjectSpace(Mouse.Hit.p)
			LineHandle.CFrame = CFrame.new(LineHandle.CFrame.p, OffsetTargetPosition)
			LineHandle.Length = (Mouse.Target.CFrame.p - Player.Character.PrimaryPart.CFrame.p).Magnitude
		end
	end
end

Tool.Equipped:Connect(function(mouse) 
	if ToolEquipped then return end 
	
	ColorSelection = script.Parent:GetAttribute("ColorThing")
	ToolEquipped = true
	mouse.Button1Up:Connect(function()   -- modification starts here
		if ColorSelection then
			local target = mouse.Target
			if target.Parent == game.Workspace.Folder then
				target.Color = ColorSelection
			end
		end		
	end) -- ends here
	mouse.Move:Connect(function()
		if CurrentGui and not InPalette then
			mouse.Icon = "rbxasset://textures\\FillCursor.png"
		end
	end)
	
	SelectionBox.Color3 = ColorSelection
	LineHandle.Color3 = ColorSelection
		
	RunService:BindToRenderStep("UpdateSelectionBox", Enum.RenderPriority.Input.Value, UpdateSelectionBox)	
	SetupGui()
end)

Tool.Unequipped:Connect(function()
	if not ToolEquipped then return end 
	ToolEquipped = false
	if CurrentGui then
		CurrentGui:Destroy()
	end
	
	RunService:UnbindFromRenderStep("UpdateSelectionBox")
	if SelectionBox then
		SelectionBox.Adornee = nil
	end
	if LineHandle then
		LineHandle.Adornee = nil
	end

	InPalette = false
	CurrentGui = nil
	Mouse.Icon = ""
end)

Do anyone know how to make this FE?

Forummer · July 14, 2022, 12:52pm

The current version is compatible with filtering enabled.

GIitzDev · July 14, 2022, 1:23pm

That’s the paintbucket I used for the game, but the problem is that it’ll paint everything no matter what, being Character, Locked part, literally anything. So I tried changing the script to make it only folder avalaible but it would stop being Filtering Enabled.

Forummer · July 14, 2022, 1:27pm

You just need to modify the server script inside the tool.

-- // Recreated by StarWars
local Tool = script.Parent
local Folder = workspace.Folder --Whitelisted folder.

local GearService = require(1075123174)
local Gear = GearService:BindGear(Tool)
Gear:SetupRemoteFunctions()

local Remotes = Tool:WaitForChild("Remotes")
local ClientControls = Remotes:WaitForChild("ClientControls") 
local ServerControls = Remotes:WaitForChild("ServerControls")

ServerControls.OnServerInvoke = function(player, mode, value)
	if player ~= Gear.Player then return end 
	if not mode then return end

	if mode == "PaintPart" and value then
		if value.Part and value.Part.Parent == Folder and value.Color then --Add parent check to this conditional expression.
			value.Part.Color = value.Color
		end
	end
end

Comments indicate edits to the original code.

sssssdddddd_1212 · November 12, 2023, 4:31pm

why is this tool local? how to make it server side?