This Tween script doesnt work, (SOLVED)

Help and Feedback Scripting Support
, ,
#1

I’m making a script that Tweens two Guis off the screen when you click a button, and when you click the button again it tweens onto the screen, but it ain’t working for me

here

button = script.Parent
frame = button.Parent.Open
fram = button.Parent["Shop Open"]


button.MouseButton1Click:Connect(function()
	if frame.Position == UDim2.new(0.048, 0,0.499, 0) and fram.Position == UDim2.new(0.048, 0,0.422, 0) then
	frame:TweenPosition(UDim2.new(-0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(-0.048, 0,0.422, 0),"Out","Quad",0.5)
	elseif frame.Position == UDim2.new(-0.048, 0,0.499, 0) and fram.Position == UDim2.new(-0.048, 0,0.422, 0) then
		frame:TweenPosition(UDim2.new(0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(0.048, 0,0.422, 0),"Out","Quad",0.5)
	end
end)

thanks!

#2

Maybe its because its meant to be else not elseif (I’m comparing videos of TweenGUI to urs)

#3

that makes a bunch of red lines under my code

#4

Well did your original script had any errors, and if so can you send an image of it.

#5

nah, no errors

[ignore this text]

#6

strange, maybe try adding a print to check if that line of code is even running.
(Sometimes scripts won’t work and wouldn’t send out any errors.)

#7 
button = script.Parent
frame = button.Parent.Open
fram = button.Parent["Shop Open"]


button.MouseButton1Click:Connect(function()
	if frame.Position == UDim2.new(0.048, 0,0.499, 0) and fram.Position == UDim2.new(0.048, 0,0.422, 0) then
	frame:TweenPosition(UDim2.new(-0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(-0.048, 0,0.422, 0),"Out","Quad",0.5) print:("Works!")
	elseif frame.Position == UDim2.new(-0.048, 0,0.499, 0) and fram.Position == UDim2.new(-0.048, 0,0.422, 0) then
		frame:TweenPosition(UDim2.new(0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(0.048, 0,0.422, 0),"Out","Quad",0.5) print:("Works!")
	end
end)
#8

Nothing in the output!

I appreciate the attempts to help me

#9

Maybe instead of doing if try functions, maybe that could work

#10

Like make a boolvalue toggle to keep on track of the button

#11

ok Ill just try to do it a different way

#12

If its set to true that means it’ll turn on the frame, if its false then it’ll close the frame.

#13

I recommend not using frame.Position in the if statement.
Instead, just have a boolean that toggles when you change between the open and closed state.

button = script.Parent
frame = button.Parent.Open
fram = button.Parent["Shop Open"]

local is_open = false

button.MouseButton1Click:Connect(function()
  is_open = not is_open
  if is_open then
   -- tween the fram and frame to where you want for when it is in the open state
  else
  -- tween the fram and frame to where you want for when it is in the closed state
  end
end)
2 Likes
#15

Thanks for the help
thanks for the script referance TigerCaptian, it worked!

(idk who to give solution tho)

#16

I think you meant to use or rather than and?

Here is your fixed script:

button = script.Parent
frame = button.Parent.Open
fram = button.Parent["Shop Open"]


button.MouseButton1Click:Connect(function()
	if frame.Position == UDim2.new(0.048, 0,0.499, 0) or fram.Position == UDim2.new(0.048, 0,0.422, 0) then
	frame:TweenPosition(UDim2.new(-0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(-0.048, 0,0.422, 0),"Out","Quad",0.5)
	elseif frame.Position == UDim2.new(-0.048, 0,0.499, 0) or fram.Position == UDim2.new(-0.048, 0,0.422, 0) then
		frame:TweenPosition(UDim2.new(0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(0.048, 0,0.422, 0),"Out","Quad",0.5)
	end
end)
#17 
button = script.Parent
frame = button.Parent.Open
fram = button.Parent["Shop Open"]

local toggle = false

button.MouseButton1Click:Connect(function()
	toggle = not toggle
	if toggle then
		--tween
	else
		--tween
	end
end)
1 Like
#18

Thanks for the support tho I fixed my problem! :melting_face:

#19

try this

button = script.Parent
frame = button.Parent.Open
fram = button.Parent["Shop Open"]


button.MouseButton1Click:Connect(function()
	if frame.Position == UDim2.new(0.048, 0,0.499, 0) and fram.Position == UDim2.new(0.048, 0,0.422, 0) then
		frame:TweenPosition(UDim2.new(-0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(-0.048, 0,0.422, 0),"Out","Quad",0.5) print:("Works!")
	else 
		frame:TweenPosition(UDim2.new(0.048, 0,0.499, 0),"Out","Quad",0.5)
		fram:TweenPosition(UDim2.new(0.048, 0,0.422, 0),"Out","Quad",0.5) print:("Works!")
	end
end)