Toggle Lights Not Working

ItsPlasmaRBLX · November 21, 2020, 9:45am

I’m having problems with my light system working
Type: Script

Errors: nil

local LightsOnValue = game.ReplicatedStorage.LightsOn
local Lights = game.Workspace.Lights

--// Functions
function ToggleLights()
	for i,v in pairs(Lights:GetChildren()) do
		if v:IsA("Part") and v.Parent:FindFirstChild("PointLight") then
			v.Parent:FindFirstChild("PointLight").Enabled=game.ReplicatedStorage.LightsOn.Value
		end
	end
end

LightsOnValue.Changed:Connect(function()
	print("Light Value Changed")
	ToggleLights()
end)

Lights (Folder and instances)

LightsOn (Value)

hikma_t · November 21, 2020, 9:48am

--// Functions
function ToggleLights()
	for i,v in pairs(Lights:GetChildren()) do
		if v:IsA("Part") and v:FindFirstChild("PointLight") then
			v.PointLight.Enabled=game.ReplicatedStorage.LightsOn.Value
		end
	end
end

You were checking if v is a Part and if its Parent is a PointLight. You should’ve checked if PointLight is a child of the part (v).

ItsPlasmaRBLX · November 21, 2020, 9:50am

Ah, I should have seen that, thank you for your support!