TowerDefence Coroutine Help

Help and Feedback Code Review
#1
  • What does the code do and what are you not satisfied with?

I’ve been following Gnomecode’s tower defense tutorials, and I found a problem with his wave code.
It won’t check if the base’s health is 0 until all the enemies have spawned.


local GameOver = false
--variables
GameOverEvent.Event:Connect(function()  -- fires when base health == 0
	GameOver = true
end)

for wave = 1, 5, 1 do
	if wave <= 2 then
		 
	      mob.Spawn("Noob",2 * wave,1)
		
	elseif wave <= 3 then
		mob.Spawn("Noob",4,4.5)
	elseif wave <= 4 then
		mob.Spawn("Noob",100,0.5) -- script yields until all 100 mobs are spawned
	end
	repeat 	                          --  doesn't check if GameOver == true until all mobs get spawned
		task.wait(1)
	until #game.Workspace.Mobs:GetChildren() == 0 or GameOver
	
	if GameOver then -- same for this line
		print("Game Over!")
		break
	end
end
  • What potential improvements have you considered?

I have actually found a good solution. I used Coroutine.Wrap for each mob.Spawn function.

for wave = 1, 5, 1 do
	if wave <= 2 then
		 
		coroutine.wrap(mob.Spawn)("Noob",2 * wave,1)
		
	elseif wave <= 3 then
		coroutine.wrap(mob.Spawn)("Noob",4,4.5)
	elseif wave <= 4 then
		coroutine.wrap(mob.Spawn)("Noob",100,0.5)
	end
	repeat 
		
		task.wait(1)
	until #game.Workspace.Mobs:GetChildren() == 0 or GameOver
  • How (specifically) do you want to improve the code?

I really just need someone to tell me if this is a bad use for Coroutine.Wrap or not.
I am also a relatively good scripter. I’m just not familiar with coroutines yet.
Thanks in advance!

2 Likes
#2

I personally have used coroutine.wrap() 99% of the time. I think ur code seems perfect and the use of coroutine seems fine.

1 Like
#3

One small thing, the incrementor in:

for wave = 1, 5, >1< do

Is un-needed.
But aside from that it’s a perfectly fine and quite clean.

1 Like
#4

Thank you both! I didn’t realize I could remove that 1, thanks! So far it has worked really smoothly!