Trying to make a Shop And Menu GUI but failed

StarJ3M · January 2, 2021, 4:43pm

Hello! Im trying to make a menu Gui

But when I was finished the scripts didn’t open or close the shop at all please help

I Was doing a video tutorial on YouTube but I cant get In contact with the person who originally made it and I cant find anything on the dev forum about this.

< Scripts >

Shop Visible Script

script.Parent.MouseButton1Click:Connect(function()
	script.Parent.Parent.ShopFrame.Visible = true
end)

Shop Invisible Script

script.Parent.MouseButton1Click:Connect(function()
	script.Parent.Parent = false
end)

< Images >

FeaturedLua · January 2, 2021, 4:48pm

Fixed the script for you.

Shop Visible Script

script.Parent.MouseButton1Click:Connect(function()
	script.Parent.Parent.Parent.ShopFrame.Visible = true -- You tried to get ScreenGui and find ShopFrame for it, but you missed an extra "Parent".
end)

Shop Invisible Script

script.Parent.MouseButton1Click:Connect(function()
	script.Parent.Parent.Visible = false -- You forgot to put Visible
end)

If that doesn’t work, it looks like you’re using the same open button to close. Then you have to use MouseButton1Up, or MouseButton1Down. Like:

Shop Visible Script

script.Parent.MouseButton1Up:Connect(function()
	script.Parent.Parent.Parent.ShopFrame.Visible = true
end)

Shop Invisible Script

script.Parent.MouseButton1Down:Connect(function()
	script.Parent.Parent.Visible = false
end)

Isaque232 · January 2, 2021, 5:01pm

There’s really no need for 2 connections, instead you can use if statements to check if the Shop is already visible and if so, it makes it invisible, and that for when It’s invisible too.

The script would look like this:

local ShopFrame = script.Parent.Parent

script.Parent.MouseButton1Click:Connect(function()
if ShopFrame.Visible == true then
	ShopFrame.Visible = false -- If shop is already visible then it makes it invisible.
else
	ShopFrame.Visible = true -- If shop is invisible then it turns visible.
end)

StarJ3M · January 2, 2021, 5:04pm

It doesnt work I tried clicking it but nothing happens

StarJ3M · January 2, 2021, 5:10pm

Wait do I make it so their in the same script?

Isaque232 · January 2, 2021, 5:11pm

Yes, it would be a single localscript, that would contain that exact script I posted.

COUNTYL1MITS · January 2, 2021, 5:12pm

He has two separate buttons for showing and hiding the ShopGui.

StarJ3M · January 2, 2021, 5:15pm

Yea thats what made me a little confused

Isaque232 · January 2, 2021, 5:16pm

Ohh yeah, My bad.

Then it wouldn’t be in a single script, at your localscript called “Shop Invisible” there should be this script:

local ShopFrame = script.Parent.Parent

script.Parent.MouseButton1Click:Connect(function()
	ShopFrame.Visible = false
end)

In your “Shop Visible” localscript there should be this:

local ShopFrame = script.Parent.Parent.Parent.Parent.ShopGui.ShopFrame -- There's easier way to locate this

script.Parent.MouseButton1Click:Connect(function()
	ShopFrame.Visible = true
end)

StarJ3M · January 2, 2021, 5:19pm

Isaque232:

local ShopFrame = script.Parent.Parent.Parent.Parent.ShopGui.ShopFrame -- There's easier way to locate this

script.Parent.MouseButton1Click:Connect(function()
	ShopFrame.Visible = true
end)

The shop close Gui works now but the open one is still haywire

Isaque232 · January 2, 2021, 5:24pm

That may be because the ShopFrame screenGui has not loaded yet, so using WaitForChild we will actually wait until it loads it, which is what we need.

Change local ShopFrame to this:

local ShopFrame = script.Parent.Parent.Parent.Parent:WaitForChild("ShopGui").ShopFrame

StarJ3M · January 2, 2021, 5:28pm

no still doesnt work I dont see any errors

Isaque232 · January 2, 2021, 5:39pm

Really? Let’s try checking if you’re really getting the ShopFrame.

Change the connection to this and tell me if it prints something out.

script.Parent.MouseButton1Click:Connect(function()
    print("ShopFrame Visible: "..ShopFrame.Visible)
	ShopFrame.Visible = true
end)

StarJ3M · January 2, 2021, 5:46pm

FOUND IT

In the output theirs random errors

Isaque232 · January 2, 2021, 5:53pm

From what I saw in your first image you should be executing the localscript from ShopButton and It’s name is “Shop Visible” so this error doesn’t seem to be coming from that localscript, but from one located in PlayButton.

Were those the only errors in the Output? Are you sure nothing printed correctly?
Check if there are any errors related to “ShopButton.Shop Visible”

StarJ3M · January 2, 2021, 5:57pm

12:55:42.211  Hello world!  -  Server  -  Storz Currency:1
12:55:45.226  Players.NubblyFry.PlayerGui.ShopGui.ShopFrame.TextLabel.Tix Currency Counter:7: Expected <eof>, got 'end'  -  Studio  -  Tix Currency Counter:7

Isaque232 · January 2, 2021, 6:01pm

Those errors seem unrelated to “ShopButton.Shop Visible” though, can you see if there’s any errors or anything coming from that localscript? (The Shop Visible one)

If there’s absolutely nothing coming from the ShopVisible localscript then that probably means the MouseClick connection is not even firing, so make sure to check if It’s actually getting triggered.

StarJ3M · January 2, 2021, 6:16pm

WOO1:Unknown Global ‘shopframe’

StarJ3M · January 2, 2021, 6:29pm

I managed to fix it myself, heres the script now that it works

local player = game.Players.LocalPlayer

script.Parent.MouseButton1Click:Connect(function()
	player.PlayerGui.ShopGui.ShopFrame.Visible = true
end)

Thanks for trying to help!