What am I doing wrong with this rain script?

Help and Feedback Scripting Support
#1

I’m trying to make a weather system using BuildThomas’s rain module, and I’m having some issues.

I don’t think my code is running altogether, and I’m not getting any errors.

LocalScript: (In ServerScriptService)

local event = game.ReplicatedStorage:WaitForChild("RainEvent")

while true do
	local randomnumber = math.random(1,3) -- I changed it so that it should have run every time

	if randomnumber ==  1 then
		local num = randomnumber
		event:FireServer(num)
		print("fired")
	elseif randomnumber == 2 then
		local num = randomnumber
		event:FireServer(num)
		print("fired")
	elseif randomnumber == 3 then
		local num = randomnumber
		event:FireServer(num)
		print("fired")
	end
	wait(40)
end

BindableEvent is in ReplicatedStorage.

Script in ServerScriptService:

local event = game.ReplicatedStorage:WaitForChild("RainEvent")
rainmod = require(script.Parent.Rain)
rainmod:Disable()

event.OnServerEvent:Connect(function(num)
	print(num)
	if num == 1 then
		rainmod:SetTransparency(0)
		rainmod:SetSpeedRatio(1)
		rainmod:SetIntensityRatio(1)
		rainmod:Enable()
		wait(60)
		rainmod:Disable()
	elseif num == 2 then
		rainmod:SetTransparency(0.4)
		rainmod:SetSpeedRatio(0.6)
		rainmod:SetIntensityRatio(0.6)
		rainmod:Enable()
		wait(40)
		rainmod:Disable()
	elseif num == 3 then
		rainmod:SetTransparency(0.6)
		rainmod:SetSpeedRatio(1)
		rainmod:SetIntensityRatio(0.3)
		rainmod:Enable()
		wait(30)
		rainmod:Disable()
	end
	wait(40)
end)

Could anyone help me debug? Thanks!

#2

Local scripts do not run in servercriptservice, they only run if they are in:

Screen Shot 2021-03-21 at 2.04.33 PM
Screen Shot 2021-03-21 at 2.04.33 PM886×300 31 KB

#3

You need to pass the player as the first variable instead.

the 5th line of the server script should be event.OnServerEvent:Connect(function(player,num) instead

1 Like
#4

I’m getting this error after putting the LocalScript in StarterPlayerScripts, and changing the 5th line of the Server Script.

image

Rain is the module by BuildThomas.

#5

Why not just make it all in one server script:

rainmod = require(script.Parent.Rain)
rainmod:Disable()

while wait() do
    local num = math.random(1,3)
	print(num)
	if num == 1 then
		rainmod:SetTransparency(0)
		rainmod:SetSpeedRatio(1)
		rainmod:SetIntensityRatio(1)
		rainmod:Enable()
		wait(60)
		rainmod:Disable()
	elseif num == 2 then
		rainmod:SetTransparency(0.4)
		rainmod:SetSpeedRatio(0.6)
		rainmod:SetIntensityRatio(0.6)
		rainmod:Enable()
		wait(40)
		rainmod:Disable()
	elseif num == 3 then
		rainmod:SetTransparency(0.6)
		rainmod:SetSpeedRatio(1)
		rainmod:SetIntensityRatio(0.3)
		rainmod:Enable()
		wait(30)
		rainmod:Disable()
	end
end
#6

It doesn’t run at all, why is that?

#7

Oh probably because the while wait() function waits first then runs the code and repeats. Retry it now, I just fixed it.

#8

I’m getting the error again:
image

#9

It’s probably because there’s soemthing in the rain script that can only be ran in a local script because it has RenderStepped in it. Try it in a local script

1 Like
#11

Didn’t work, that’s how I got the error.

#12

Would where I placed the LocalScript matter?

#13

Put the code @XdJackyboiiXd21 made in a localscript and put it in StarterPlayerScripts in this case perhaps, jsut anywhere a local script can work

#14

Should I change the

rainmod = require(script.Parent.Rain)

or put the module in the same place?

#15

Put the module anywhere you want I believe, I recommend putting it in ReplicatedStorage and changing that line to

rainmod = require(game.ReplicatedStorage.Rain)
1 Like
#16

It works now, but would the rain only run for the local player? I want it to run for the whole server, if that’s possible.

#17

It would run for each player if done like this, meaning every player is going to see the rain since they each have the rain script

1 Like
#18

If I set the math.random to something else, would each player get a different number?

#19

Yea that’s the only thing that’s a problem, each will see different rain basically, you’d have to find a way to make it the same for everyone

1 Like
#20

Do you know a way I could possibly accomplish that?

#21

You could put an intvalue in replicated storage. Have a server script change the int value and have the local scripts reference that value.