Whitelist script only checks the first player in the list

Help and Feedback Scripting Support
#1

Hello, so this whitelist script I made only checks the first person on the list, but I want the list to include everyone, any help?

local whitelist = {
	"664880421",
	"2513627682",
}

game.Players.PlayerAdded:Connect(function(player)
		for i,v in pairs(whitelist) do
			if v ~= player.UserId then
			player:Kick("You're not allowed here.")
			end
	end
end)
1 Like
#2

Have you made sure the userids are correct? I don’t see anything wrong with this code.

#3

Yeah, I copied them directly from the profiles. Yet it still doesn’t work, try using ROBLOX’s user id or something first and then yours and it won’t let you in.

#4

try changing the code to:

local whitelist = {
	664880421,
	2513627682,
}

game.Players.PlayerAdded:Connect(function(player)
		for i,v in pairs(whitelist) do
			if v ~= player.UserId then
			player:Kick("You're not allowed here.")
			end
	   end
end)

What’s happening is that strings are not the same as integers.

player.UserId is of type integer, not string

#5

The player cannot be equal to both user Id’s, this is the issue.
You can try this:

local whitelist = {
	"664880421",
	"2513627682",
}

game.Players.PlayerAdded:Connect(function(player)
        local found = false
		for i,v in pairs(whitelist) do
			 if v == player.UserId then
			    found = true
			 end
	     end
         if not found then
             player:Kick("You're not allowed here.")
         end
end)

same as Farley120’s script

#6

Your kick function is being run every time the userId does not match. This means it will check the first element. If the first element does not equal their userId, it will kick them. You need to do a final check after running through the entire table.

local whitelist = {
	"664880421",
	"2513627682",
}

game.Players.PlayerAdded:Connect(function(player)
  local whitelisted = false
  for i,v in pairs(whitelist) do
    if v == player.UserId then
      whitelisted = true
      break;
    end
  end
  if not whitelisted then
    player:Kick("You're not allowed here.")
  end
end)
#7

I think I made some type of mistake while coding the original script cause this still doesn’t work.

#8

are you sure the script is running? Is it in a server script??

what Farley120 said

#9

Remove the quotation marks when storing the userIds, it’s storing them as a string.

#10

Updated code:

local whitelist = {
	664880421,
	2513627682,
}

game.Players.PlayerAdded:Connect(function(player)
  local whitelisted = false
  for i,v in pairs(whitelist) do
    if v == player.UserId then
      whitelisted = true
      break;
    end
  end
  if not whitelisted then
    player:Kick("You're not allowed here.")
  end
end)
#11

Do this instead

local players = game:GetService("Players")

local whitelist = {
	664880421,
	2513627682,
}

players.PlayerAdded:Connect(function(player)
	if not table.find(whitelist, player.UserId) then
		player:Kick("Not whitelisted")
	end
end)

A for loop is unnecessary for this

#12

What this will do is check if someone who joins the game has a userid that is in the table. If they don’t have a userid that is in the table, they will get kicked from the game.


local whitelist = {664880421,2513627682}

game.Players.PlayerAdded:Connect(function(player)
      if not whitelist[player.UserId] then
             player:Kick("You're not allowed to join this game.")
      end
      -- do stuff down here for if they are allowed to join (in the whitelist)
end)