Why am I getting this error?

Theyoloman1920 · July 21, 2020, 6:02pm

So, as you can realise from a previous of my posts earlier today, I have been trying to create a datastore. The datastore has two values, the TimesJoined and Credits. When I added the second value, the script stoped to work and this error occurred.

Here is the server Script, located in the ServerScriptService:

local DataStoreService = game:GetService("DataStoreService")
local CyberWorldDatastore = DataStoreService:GetDataStore("CyberWorldDatastore")
 
game.Players.PlayerAdded:Connect(function(player)
	
	local folder = Instance.new("Folder")
	folder.Name = "Data"
	folder.Parent = player
	
	local TimesJoined = Instance.new("IntValue")
	TimesJoined.Name = "TimesJoined" 
	TimesJoined.Parent = folder

	local Credits = Instance.new("IntValue")
	Credits.Name = "Credits" 
	Credits.Parent = folder
	
	local data

	local success, errormessage = pcall(function()
		data = CyberWorldDatastore:GetAsync("TimesJoined"..player.UserId) 
	end)
	
	if success then
		TimesJoined.Value = data.TimesJoined 
		Credits.Value = data.Credits
		print("data successfully loaded")
	else
		print("an error occured")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)
	
	local data = {
		TimesJoined = player.Data.TimesJoined;
		Credits = player.Data.Credits;
	}
	local success, errormessage = pcall(function()
		CyberWorldDatastore:SetAsync("TimesJoined"..player.UserId, player.Data.TimesJoined.Value)		
	end)

	if success then
		print("Data succesfuly saved")
	else
		print("error")
		warn(errormessage)
	end
end)

Any suggestions?

JarodOfOrbiter · July 21, 2020, 6:07pm

It helps if you point out the lines, but I think this one is 25, correct? It looks like ‘data’ is a number, and that you already saved it as a number rather than a table. Change it to just ‘data’ if I am right.

Theyoloman1920 · July 21, 2020, 6:17pm

Yes you are quite right, this is line 25. Sorry for the confusion. So, if I understood correctly you are telling me to do it:

TimesJoined.Value = data

JarodOfOrbiter · July 21, 2020, 6:25pm

I believe that is the issue. Also check how you are saving data and if you want, you can print ‘data’ to see exactly what it is.

Theyoloman1920 · July 21, 2020, 6:45pm

Now the error is not there, but the saving function still doesn’t work. Further more the print(“Data successfully saved”) is not printing anymore… Any suggestions?

jake_4543 · July 21, 2020, 7:27pm

local DataStoreService = game:GetService("DataStoreService")
local CyberWorldDatastore = DataStoreService:GetDataStore("CyberWorldDatastore")
 
game.Players.PlayerAdded:Connect(function(player)
	
	local folder = Instance.new("Folder")
	folder.Name = "Data"
	folder.Parent = player
	
	local TimesJoined = Instance.new("IntValue")
	TimesJoined.Name = "TimesJoined" 
	TimesJoined.Parent = folder

	local Credits = Instance.new("IntValue")
	Credits.Name = "Credits" 
	Credits.Parent = folder
	
	local data

	local success, errormessage = pcall(function()
		data = CyberWorldDatastore:GetAsync("TimesJoined"..player.UserId) 
	end)
	
	if success then
		TimesJoined.Value = data.TimesJoined 
		Credits.Value = data.Credits
		print("data successfully loaded")
	else
		print("an error occured")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)
	
	local data = {
		TimesJoined = player.Data.TimesJoined.Value;
		Credits = player.Data.Credits.Value;
	}
	local success, errormessage = pcall(function()
		CyberWorldDatastore:SetAsync("TimesJoined"..player.UserId, player.Data.TimesJoined.Value)		
	end)

	if success then
		print("Data succesfuly saved")
	else
		print("error")
		warn(errormessage)
	end
end)

try that

Theyoloman1920 · July 21, 2020, 7:30pm

Didn’t work. Save message printed once in 7 times…

jake_4543 · July 21, 2020, 7:32pm

Is it sending the error, if so please send it here

Theyoloman1920 · July 21, 2020, 7:32pm

No, there is no error… It just prints sometimes, which means that the function isn’t loading correctly.

jake_4543 · July 21, 2020, 7:33pm

local DataStoreService = game:GetService("DataStoreService")
local CyberWorldDatastore = DataStoreService:GetDataStore("CyberWorldDatastore")
 
game.Players.PlayerAdded:Connect(function(player)
	
	local folder = Instance.new("Folder")
	folder.Name = "Data"
	folder.Parent = player
	
	local TimesJoined = Instance.new("IntValue")
	TimesJoined.Name = "TimesJoined" 
	TimesJoined.Parent = folder

	local Credits = Instance.new("IntValue")
	Credits.Name = "Credits" 
	Credits.Parent = folder
	
	local data

	local success, errormessage = pcall(function()
		data = CyberWorldDatastore:GetAsync("TimesJoined"..player.UserId) 
	end)
	
	if success then
		TimesJoined.Value = data.TimesJoined 
		Credits.Value = data.Credits
		print("data successfully loaded")
	else
		print("an error occured")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)
	
	local data = {
		["TimesJoined"] = player.Data.TimesJoined.Value;
		["Credits"] = player.Data.Credits.Value;
	}
	local success, errormessage = pcall(function()
		CyberWorldDatastore:SetAsync("TimesJoined"..player.UserId, player.Data.TimesJoined.Value)		
	end)

	if success then
		print("Data succesfuly saved")
	else
		print("error")
		warn(errormessage)
	end
end)

try this now

Theyoloman1920 · July 21, 2020, 7:35pm

No difference… Oh, and there is an error in line 25 and 26 (I fixed it)

jake_4543 · July 21, 2020, 7:36pm

local DataStoreService = game:GetService("DataStoreService")
local CyberWorldDatastore = DataStoreService:GetDataStore("CyberWorldDatastore")
 
game.Players.PlayerAdded:Connect(function(player)
	
	local folder = Instance.new("Folder")
	folder.Name = "Data"
	folder.Parent = player
	
	local TimesJoined = Instance.new("IntValue")
	TimesJoined.Name = "TimesJoined" 
	TimesJoined.Parent = folder

	local Credits = Instance.new("IntValue")
	Credits.Name = "Credits" 
	Credits.Parent = folder
	
	local data

	local success, errormessage = pcall(function()
		data = CyberWorldDatastore:GetAsync("DATTABLE"..player.UserId) 
	end)
	
	if success then
		TimesJoined.Value = data.TimesJoined 
		Credits.Value = data.Credits
		print("data successfully loaded")
	else
		print("an error occured")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)
	
	local data = {
		["TimesJoined"] = player.Data.TimesJoined.Value;
		["Credits"] = player.Data.Credits.Value;
	}
	local success, errormessage = pcall(function()
		CyberWorldDatastore:SetAsync("DATTABLE"..player.UserId, data)		
	end)

	if success then
		print("Data succesfuly saved")
	else
		print("error")
		warn(errormessage)
	end
end)

i hope this works

Theyoloman1920 · July 21, 2020, 7:38pm

Now, the message is printing every single time, but the data don’t save… Why are datastores so hard to use?

jake_4543 · July 21, 2020, 7:39pm

they arent, they are pretty easy, your datastore is just kinda a pain (not saying its bad just saying there are a few errors)

Theyoloman1920 · July 21, 2020, 7:40pm

I see. What would you recommend in order to fix it?

Theyoloman1920 · July 21, 2020, 7:40pm

Oh, now it’s not printing the message again…

jake_4543 · July 21, 2020, 7:41pm

local DataStoreService = game:GetService("DataStoreService")
local CyberWorldDatastore = DataStoreService:GetDataStore("CyberWorldDatastore")
 
game.Players.PlayerAdded:Connect(function(player)
	
	local folder = Instance.new("Folder")
	folder.Name = "Data"
	folder.Parent = player
	
	local TimesJoined = Instance.new("IntValue")
	TimesJoined.Name = "TimesJoined" 
	TimesJoined.Parent = folder

	local Credits = Instance.new("IntValue")
	Credits.Name = "Credits" 
	Credits.Parent = folder
	
	local data

	local success, errormessage = pcall(function()
		data = CyberWorldDatastore:GetAsync("DATTABLE"..player.UserId) 
	end)
	
	if success then
		if data.TimesJoined then
                      TimesJoined.Value = data.TimesJoined 
                     else
                      TimesJoined.Value = 0
                end
		if data.Credits then
                     Credits.Value = data.Credits
                       else
                      Credits.Value = 0
                end
		print("data successfully loaded")
	else
		print("an error occured")
		warn(errormessage)
	end
end)

game.Players.PlayerRemoving:Connect(function(player)
	
	local data = {
		["TimesJoined"] = player.Data.TimesJoined.Value;
		["Credits"] = player.Data.Credits.Value;
	}
	local success, errormessage = pcall(function()
		CyberWorldDatastore:SetAsync("DATTABLE"..player.UserId, data)		
	end)

	if success then
		print("Data successfully saved")
	else
		print("error")
		warn(errormessage)
	end
end)

try this

jake_4543 · July 21, 2020, 7:43pm

Oops, just edited the code a bit please put that new code in

Theyoloman1920 · July 21, 2020, 7:45pm

Works very good, thanks. Just asking, have you set it so it won’t save unless there is something to save?

jake_4543 · July 21, 2020, 7:46pm

I set it so it wont try to load from the table if the table has no value in it