Why doesn't this DataStore work?

Help and Feedback Scripting Support
#1

For some reason this DataStore doesn’t save stats. I’m not a very experienced developer, I didn’t make it myself and have never actually tried to make a DataStore from scratch before, but I don’t see any problems with this script.

Here’s the ModuleScript:

local module = {}
local DatastoreService = game:GetService("DataStoreService")
local datastore = DatastoreService:GetDataStore("SmartDataStore")

local PlayersDatas = {}

function LoadData (player:Player,value)
	
	if PlayersDatas[player.Name] and PlayersDatas[player.Name][value.Name] then
		value.Value = PlayersDatas[player.Name][value.Name]
	end
end

function AddTable (player: Player)
	local sucess, data = pcall(function()
		return datastore:GetAsync(player.UserId)
	end)
	
	if sucess and data then
		PlayersDatas[player.Name] = data
	end
end

function addDatastore (player: Player)
	local SmartDatastore = Instance.new("Folder", player) SmartDatastore.Name = "SmartDatastore"
	
	SmartDatastore.ChildAdded:Connect(function(child)
		LoadData(player, child)
	end)
end

function module.AddValue (player:Player, value,name, starterValue)
	local SmartDatastore = player:WaitForChild("SmartDatastore")
	local Value = Instance.new(value, SmartDatastore) Value.Name = name
	if starterValue ~= nil then
		Value.Value = starterValue
	end
end

function saveDatastore (player: Player)
	local SmartDatastore = player:WaitForChild("SmartDatastore")
	local Data = {}
	
	for _, value in pairs(SmartDatastore:GetChildren()) do
		if value:IsA("ValueBase") then
			Data[value.Name] = value.Value
		end
	end
	datastore:SetAsync(player.UserId, Data)
end

game.Players.PlayerAdded:Connect(function(p)
	AddTable(p)
	addDatastore(p)
end)
game.Players.PlayerRemoving:Connect(saveDatastore)

return module

And here’s my ServerScript:

local module = require(script:WaitForChild("SmartDatastore"))


game.Players.PlayerAdded:Connect(function(player)
	
	--Coins
	module.AddValue(player, "IntValue", "Coins", 10)
	
	--Mushrooms
	module.AddValue(player, "IntValue", "Mushrooms", 0)
	
end)

Please let me know if you see any issues!
Any and all help is appreciated, thank you in advance!

#2

I haven’t seen you define ‘SmartDatastore’ anywhere in the ServerScript?

#3

Isn’t that what I did here in the first line?

#4

When is this created in the ServerScript?

#5

I don’t understand what you mean

#6

Well the .playeradded and removing in the modules will never work because in a module script for code to run it has to be ‘called’ and and roblox doesn’t go though and check if those functions to be used unless you have them already in function that has been called.

Also if you have two severscripts looking for if a player joins I don’t one of them would work. (this might not be true but, once i had a bug like this and the two .playeradded events were the problem.)

#7

I believe the issue is you not doing game:BindToClose()

If you are the last player in a server or testing in studio, data may not save properly using .PlayerRemoving, instead you would need to use game:BindToClose which will call a function once the server is closing, here’s an example script:

 game:BindToClose(function()
    for _, Player in pairs(game:GetService("Players")) do
        saveDatastore(Player)
    end
end)

You should also try to use game:GetService(“Service”) as it is better to use.

If this doesn’t work, send any errors you are getting in console & make sure the module is in a ServerSided Instance (ServerStorage, ServerScriptService)

#8

I changed the PlayerAdded and PlayerRemoving functions to where they’re now called from the ServerScript and tested them to make sure they work yet the data still isn’t saved next time I rejoin, but thank you for the suggestion! I’m sure that was one of the issues because you were right and they definitely were not working before

#9

I got this error:

image
image1611×40 11.4 KB

#10

he forget to add something

replace this

for _, Player in pairs(game:GetService("Players")) do

with

for _, Player in pairs(game:GetService("Players"):GetPlayers()) do

I think, I THINK. Try it out cause i don’t remember

1 Like
#11

Yep that’s it, was typing on mobile :sob:

1 Like
#12

There are 5 logic and 3 syntax errors in the module and 2 (missing logic) “errors” in the server script.
Roblox DataStore Tutorial - Data Stores & Saving Data - Scripting Tutorial
Think the best thing here would be a tutorial by an expert, AlvinBlox.

1 Like
#13 
local smartDataStore = Instance.new("Folder")
smartDataStore.Name = "SmartDatastore"
smartDataStore.Parent = player

Is what you’re missing, however your code appears to have more errors than just that. @2112Jay 's advice to follow a tutorial is a great idea for you :slight_smile: