Why is my table script not working?

Help and Feedback Scripting Support
#1

Why will my script not work? It does not print out anything from what I put.

local Players = {}

game.ReplicatedStorage.HostStuff.AddPlayer.OnServerEvent:Connect(function(plr)
	if plr:GetRankInGroup(6559630) >= 20 then
		if not table.find(Players, plr.Name) then
			print("Player is not in host system but now is.")
			table.insert(Players, plr.Name)
		else
			print("Player is already in the host system")
		end
	end
end)
1 Like
#2

Is the :GetRankInGroup() part working fine? If it is then try this:

local Players = {}

game.ReplicatedStorage.HostStuff.AddPlayer.OnServerEvent:Connect(function(plr)
	if plr:GetRankInGroup(6559630) >= 20 then
		if not Players[plr]  then
			print("Player is not in host system but now is.")
			Players[plr] = true
		else
			print("Player is already in the host system")
		end
	end
end)
2 Likes
#3

That fixes it, now I am trying to do this but have an error:

local Players = {}

game.ReplicatedStorage.HostStuff.HostAddPlayer.OnServerEvent:Connect(function(plr)
	if plr:GetRankInGroup(6559630) >= 20 then
		if not Players[plr]  then
			print("Player is not in host system but now is.")
			for i, v in pairs(game.Players:GetChildren()) do
				local clone = game.ServerStorage.Name:Clone()
				clone.Parent = v.PlayerGui.SurfaceGui.ListDown
				clone.Text = plr.Name
			end
			Players[plr] = true
		else
			print("Player is already in the host system")
		end
	end
end)

Error:
image

1 Like
#4

Is this the full script? Also what type of object is clone?

1 Like
#5

it is.

this is what it is cloneing and then puting it into a surface UI in the player gui

image

1 Like
#6

You’re saving an instance inside of a table, so it would be:

game.ReplicatedStorage.HostStuff.HostAddPlayer.OnServerEvent:Connect(function(plr)
	if plr:GetRankInGroup(6559630) >= 20 then
		if not Players[plr.Name]  then
			print("Player is not in host system but now is.")
			for i, v in pairs(game.Players:GetPlayers()) do
				local clone = game.ServerStorage.Name:Clone()
				clone.Parent = v.PlayerGui.SurfaceGui.ListDown
				clone.Text = plr.Name
			end
			Players[plr.Name] = true
		else
			print("Player is already in the host system")
		end
	end
end)
#7

I recommend using :WaitForChild() or :FindFirstChild(), so do this: v:FindFirstChild("PlayerGui"):FindFirstChild("SurfaceGui"):WaitForChild("ListDown")

1 Like
#8

I get this error with ur script still

image

#9

That should not affect anything with the error i am now geting

1 Like
#10

I know this is off-topic but I would put the player’s UserId in the table instead of their name…

#11

Why? It does not really matter because when the player leaves the game they will be removed from the table anyways.

1 Like
#12

The error is because you have it called Name, which is also a property. Change the name to something else.

1 Like
#13

This ^, change the Name Text GUI name to NameGUI.