Why is my tween stopping my code from continuing?

Help and Feedback Scripting Support
#1

I have a script that opens two different doors at the same time, like an elevator.

local function Open()
	if OpenValue == true then return end
	local RightSlideTween = TweenService:Create(RightRoot, SlideInfo, {CFrame = RightRoot.CFrame * CFrame.new(RightRoot.Size.X + 0.0001, 0, 0)})
	
	RightSlideTween:Play()	
	
	local LeftSideTween = TweenService:Create(LeftRoot, SlideInfo, {CFrame = LeftRoot.CFrame * CFrame.new(LeftRoot.Size.X + 0.0001, 0, 0)})

	LeftSideTween:Play()
	RightSlideTween.Completed:Wait()
    print("Tween 1 Complete")
	LeftSideTween.Completed:Wait()
	print("Doors Open! Function complete!")
end

Unfortunately, only the first print is written in the console, “Tween 1 Complete” and the other one never pops up. Am I doing something wrong or is this a Roblox bug?

1 Like
#2

Check if this works

local LeftSideTween = TweenService:Create(LeftRoot, SlideInfo, {CFrame = LeftRoot.CFrame * CFrame.new(LeftRoot.Size.X + 0.0001, 0, 0)})
local RightSideTween = TweenService:Create(RightRoot, SlideInfo, {CFrame = RightRoot.CFrame * CFrame.new(RightRoot.Size.X + 0.0001, 0, 0)})
local function OpenLeftDoor()
   LeftSideTween:Play()
   LeftSideTween.Completed:Wait()
   return true
end

local function OpenRightDoor()
   RightSideTween:Play()
   RightSideTween.Completed:Wait()
   return true
end

local function Open()
   if OpenRightDoor() and OpenLeftDoor() then
         print("Door has been opened")
          ---- more code ---------
   end
end
1 Like
#3

Put both of your tween variables at the top, outside of the function. Then play them inside the function.

#4

Done. May I know why? Is it because of performance issues?

#5

So that you can call the tweens at any point from anywhere in the script to see what state they’re in. If something else happens and you need to immediately stop the door from opening/closing you can just do Tween:Cancel()

3 Likes
#6

When doing :Wait() functions, it’s a good habit to put a 0 in between the parentheses so there isn’t a small extra delay after it’s completed. But just re order the code so that you have all the tweens at the top of the code and then play one at a time and wait for one at a time.

#7

The second tween has already completed before you execute Wait so it’s going to wait forever. Check to make sure it’s playing before you wait on it…

if LeftSideTween.PlaybackState == Enum.PlaybackState.Playing then
  LeftSideTween.Completed:Wait()
end
#8

You have a :Wait() in your code. There are two ways to fix this. I will provide both below:

--Method 1
local function Open()
	if OpenValue == true then return end
	local RightSlideTween = TweenService:Create(RightRoot, SlideInfo, {CFrame = RightRoot.CFrame * CFrame.new(RightRoot.Size.X + 0.0001, 0, 0)})
	
	RightSlideTween:Play()	
        task.spawn(function()
	        RightSlideTween.Completed:Wait()
                print("Tween 1 Complete")
        end)
	
	local LeftSideTween = TweenService:Create(LeftRoot, SlideInfo, {CFrame = LeftRoot.CFrame * CFrame.new(LeftRoot.Size.X + 0.0001, 0, 0)})
        LeftSideTween:Play()
	LeftSideTween.Completed:Wait()
	print("Doors Open! Function complete!")
end

--Method 2

local function Open()
	if OpenValue == true then return end
	local RightSlideTween = TweenService:Create(RightRoot, SlideInfo, {CFrame = RightRoot.CFrame * CFrame.new(RightRoot.Size.X + 0.0001, 0, 0)})
	
	RightSlideTween:Play()	
	RightSideTween.Completed:Connect(function()
                print("Tween 1 Complete")
        end)
	
	local LeftSideTween = TweenService:Create(LeftRoot, SlideInfo, {CFrame = LeftRoot.CFrame * CFrame.new(LeftRoot.Size.X + 0.0001, 0, 0)})
        LeftSideTween:Play()
	LeftSideTween.Completed:Wait()
	print("Doors Open! Function complete!")
end

Task.spawn() creates a new thread, so the Wait() wont effect the rest of the code

Using Connect doesn’t yeild

1 Like
#9

This solution by far works the best for me since I wanted two doors to open at the same time. Thank you so much for the other solutions guys! Much appreciated :blush: