Why isn't BodyVelocity and TakeDamage working?

Matiskra · July 26, 2024, 10:43pm

Hi Devforum, I’m learning to program and I’ve encountered a problem where BodyVelocity isn’t working and I don’t know why. Additionally, TakeDamage isn’t working either.

Here is a part of my script:

	local Hitbox = require(ReplicedStorage.MuchachoHitbox)
	
	
	local hitbox = Hitbox.CreateHitbox()
	hitbox.Size = Vector3.new(10.4, 13.7, 7.2)
	hitbox.CFrame = origin
	hitbox.Visualizer = false
	
	hitbox.Touched:Connect(function(hit, hum)
		hum:TakeDamage(100)
		print(hit)
		
		local HitEffect = ReplicedStorage.Assets.VFX.HitEffect:Clone()
		HitEffect.CFrame = hit.Parent.HumanoidRootPart.CFrame
		HitEffect.Parent = workspace.VFX
		HitEffect.Attachment.Crescents:Emit(3)
		HitEffect.Attachment.Debris:Emit(12)
		HitEffect.Attachment.Flash:Emit(1)
		HitEffect.Attachment.Shardes:Emit(16)
		

		local bv = Instance.new("BodyVelocity")
		bv.Parent = hit.Parent.HumanoidRootPart
		bv.MaxForce = Vector3.new(1,1,1) * math.huge
		bv.Velocity = Character.HumanoidRootPart.CFrame.LookVector * 100
		Debirs:AddItem(bv, .1)
	end)
	
	hitbox:Start()
	
	wait(.7)
	
	hitbox:Stop()

I’m also providing a video to show the issue:

Stratnik · July 26, 2024, 10:55pm

Is this running in a localscript or a normal script, because the only reason I think it wouldn’t work is it’s a localscript

Matiskra · July 26, 2024, 11:12pm

This is working on a Module Script.

010DevX101 · July 27, 2024, 12:09am

The .Touched event only accepts one parameter: hit, not the Humanoid. The hit part will be a child of the Character. In order to get the Humanoid from the hit part you will first have to get the Character and then the Humanoid inside the character.

local Hitbox = require(ReplicedStorage.MuchachoHitbox)
	
	local hitbox = Hitbox.CreateHitbox()
	hitbox.Size = Vector3.new(10.4, 13.7, 7.2)
	hitbox.CFrame = origin
	hitbox.Visualizer = false
	
	hitbox.Touched:Connect(function(hit)
		local Humanoid: Humanoid = hit.Parent:FindFirstChildWhichIsA("Humanoid")
		if not Humanoid then
			return
		end
		Humanoid:TakeDamage(100)
		print(hit)
		
		local HitEffect = ReplicedStorage.Assets.VFX.HitEffect:Clone()
		HitEffect.CFrame = hit.Parent.HumanoidRootPart.CFrame
		HitEffect.Parent = workspace.VFX
		HitEffect.Attachment.Crescents:Emit(3)
		HitEffect.Attachment.Debris:Emit(12)
		HitEffect.Attachment.Flash:Emit(1)
		HitEffect.Attachment.Shardes:Emit(16)
		

		local bv = Instance.new("BodyVelocity")
		bv.Parent = hit.Parent.HumanoidRootPart
		bv.MaxForce = Vector3.new(1,1,1) * math.huge
		bv.Velocity = Character.HumanoidRootPart.CFrame.LookVector * 100
		Debirs:AddItem(bv, .1)
	end)
	
	hitbox:Start()
	
	wait(.7)
	
	hitbox:Stop()

This code should work, let me know if you need anything else.

Matiskra · July 27, 2024, 12:24am

The damage dealing works, but the BodyVelocity still isn’t working

Geolio9 · July 27, 2024, 12:25am

The ModuleScript doesn’t affect how anything works. Where are you requiring the script?

010DevX101 · July 27, 2024, 12:25am

You messed up the name of the service, it’s Debris. Unless your variable is called Debirs. Can you show me where you define the variable for the Debris service?

Talking about this line:

Debirs:AddItem(bv, .1)

010DevX101 · July 27, 2024, 12:27am

Oh and where do you define the Character variable you use here:

bv.Velocity = Character.HumanoidRootPart.CFrame.LookVector * 100

Matiskra · July 27, 2024, 12:32am

where it says

hitbox.Touched:Connect(function(hit)
    --script
end

I’m not sure if that’s what you mean

010DevX101 · July 27, 2024, 12:35am

There we get the hit variable inside the function connected to the .Touched event, but when you set the velocity of the BodyVelocity you use a variable called Character that is never defined in the script. Is this the full script? If it isn’t, I’ll have to add some things.

Bovious · July 27, 2024, 12:35am

Does the dummy you’re testing this on have their humanoid root part unanchored?

Matiskra · July 27, 2024, 12:36am

No, that’s not the full script. I’ll paste it below; maybe it will help.

local Skill = {}

local ReplicedStorage = game.ReplicatedStorage
local Debirs = game:GetService("Debris")
local TweenSerice = game:GetService("TweenService")

function Skill:Start(Player, Character)

	local humanoid = Character:WaitForChild("Humanoid")

	humanoid.WalkSpeed = 0
	humanoid.JumpHeight = 0

	local animation = ReplicedStorage.Assets.Skillsets.Flame.Animations.FireFIst
	local LoadAnimation = humanoid:LoadAnimation(animation)
	LoadAnimation:Play()
	LoadAnimation:AdjustSpeed(1)

	local charge = ReplicedStorage.Assets.Skillsets.Flame.VFX.Charge:Clone()

	local weld = Instance.new("Motor6D")
	weld.Part0 = charge
	weld.Part1 = Character:WaitForChild("Left Arm")
	weld.C0 = CFrame.new(0,0.7,0)
	weld.Parent = charge
	charge.Anchored = false
	charge.Parent = workspace.VFX

	for _, v in pairs(charge:GetDescendants()) do
		if v:IsA("ParticleEmitter") then
			v.Rate = 50
			v.Enabled = true
		end
	end

	task.wait(2.6)
	for _, v in pairs(charge:GetDescendants()) do
		if v:IsA("ParticleEmitter") then
			v.Enabled = false
		end
	end
	Debirs:AddItem(charge, 1)



	local raycastPARAMS = RaycastParams.new()
	raycastPARAMS.FilterType = Enum.RaycastFilterType.Exclude
	raycastPARAMS.FilterDescendantsInstances = {Character, workspace.VFX}

	local origin = Character.HumanoidRootPart.CFrame * CFrame.new(0,2,-8)


	local Hitbox = require(ReplicedStorage.MuchachoHitbox)

	local hitbox = Hitbox.CreateHitbox()
	hitbox.Size = Vector3.new(10.4, 13.7, 7.2)
	hitbox.CFrame = origin
	hitbox.Visualizer = false

	hitbox.Touched:Connect(function(hit)
		local Humanoid: Humanoid = hit.Parent:FindFirstChildWhichIsA("Humanoid")
		if not Humanoid then
			return
		end
		Humanoid:TakeDamage(10)
		print(hit)

		local HitEffect = ReplicedStorage.Assets.VFX.HitEffect:Clone()
		HitEffect.CFrame = hit.Parent.HumanoidRootPart.CFrame
		HitEffect.Parent = workspace.VFX
		HitEffect.Attachment.Crescents:Emit(3)
		HitEffect.Attachment.Debris:Emit(12)
		HitEffect.Attachment.Flash:Emit(1)
		HitEffect.Attachment.Shardes:Emit(16)


		local bv = Instance.new("BodyVelocity")
		bv.Parent = hit.Parent.HumanoidRootPart
		bv.MaxForce = Vector3.new(1,1,1) * math.huge
		bv.Velocity = Character.HumanoidRootPart.CFrame.LookVector * 100
		Debirs:AddItem(bv, .1)
	end)

	hitbox:Start()

	wait(.7)

	hitbox:Stop()
	humanoid.WalkSpeed = 16
	humanoid.JumpHeight = 7.2





end

return Skill

010DevX101 · July 27, 2024, 12:37am

Do you get any errors in the console?

Matiskra · July 27, 2024, 12:38am

Yes, I checked if the dummy was unanchored, and it was.

Matiskra · July 27, 2024, 12:38am

No, I don’t have any errors in the console.

010DevX101 · July 27, 2024, 12:41am

Interesting, I just tested the BodyVelocity on a Dummy and it works.

pomp2008 · July 27, 2024, 12:43am

BodyVelocity is deprecated meaning it does work anymore. Just use VectorVelocity.

010DevX101 · July 27, 2024, 12:44am

Deprecated does not mean it doesn’t work anymore. It means it’s not intended to be used in new projects but it still works.

pomp2008 · July 27, 2024, 12:46am

Oh ok. Still i would suggest using VectorVelocity.

010DevX101 · July 27, 2024, 12:47am

I agree, it would be a better choice but BodyVelocity should work. I don’t understand why it’s working for me and not for him when the code looks functional.