Why this script don't save table?

Help and Feedback Scripting Support
#1

Hi,

So i want to save a value of numbervalue that is inside every tool in my backpack, im using table for this, but for some reason this don’t save them. (I checked if table is saved using Datastore editor plugin)

game.Players.PlayerRemoving:connect(function(player)
	player.Character.Humamoid:UnequipTools()
	local valuesToSave = {}
	
	for _, v in pairs(player.Backpack:GetChildren()) do
		valuesToSave[v.Name] = v:WaitForChild("Amount").Value
	end
	
	MyDataStore:SetAsync(player.UserId, valuesToSave)
end)
1 Like
#2

The connect is capital always if i am not wrong

#3

:connect is deprecated but that doesnt mean it can’t be used, like Mouse for example so I dont think thats the problem

#4

still don’t work

30 character needed…

#5

Any errors in the output possibly?

1 Like
#6

Another alternative method is:

game.Players.PlayerRemoving:connect(function(player)
	player.Character.Humamoid:UnequipTools()
	local valuesToSave = {}
	
	for _, v in pairs(player.Backpack:GetChildren()) do
		valuesToSave[v.Name] = v:WaitForChild("Amount").Value
             MyDataStore:SetAsync(player.UserId,v.name)
	end
end)
#7

ist it will just save a name of last instance? as it will save not table but name and it will rewrite it for every tool so it will save only last tool name.

#8

I am not very much sure if you can save tables as a whole with datastore and I haven’t tried it either

#9

Oh ye! I was testing in actuall game so i couldn’t see errors after leaving but i tested in studio and it seems that i have error:
Screenshot_217

Is there any way i can save value of tool that equipped/inside character?

i will try add waitforchid

1 Like
#10

I think Character might be removed before your script runs

#11

Try to add waitforchild and see what happens then

#12

Wait for child isn’t going to help it clearly says attempt to index nil which means Humanoid parent isn’t there

#13

Yeah wait for the parent which is the character

local character = plr.Character or plr.CharacterAdded:Wait()
#14

yeah… it didn’t gave any error but it don’t work

#15

that’s not going to work either instead use

player.CharacterRemoving
#16

i can use this function inside this one?

#17

The reason why you are getting this error is because you spelt Humanoid wrong. Here is your code with the correct spelling:

game.Players.PlayerRemoving:Connect(function(player)
	player.Character.Humanoid:UnequipTools()
	local valuesToSave = {}
	
	for _, v in pairs(player.Backpack:GetChildren()) do
		valuesToSave[v.Name] = v:WaitForChild("Amount").Value
	end
	
	MyDataStore:SetAsync(player.UserId, valuesToSave)
end)

Instead of using SetAsync() you should look into using UpdateAsync() because

“SetAsync() can be hazardous since it overwrites any value currently in the entry. If you’re updating an existing entry, UpdateAsync() is recommended because it considers the old value before making changes.” - Quoted from the developers hub

1 Like
#18

There is 1 problem with this actually that It would fire everytime player respawn

#19

He spelled humanoid wrong thats why it wasnt working.

#21

lol didn’t noticed that. but it still don’t save