Why Wont My Punch Script Work?

[WindyTundra]

Everything in my script works except for when its supposed to take damage, its a local script and uses a remote event to damage the player.

–Here’s The Script

local plr = game.Players.LocalPlayer

local Players = game:GetService("Players")

local Playing = false

local mouse = plr:GetMouse() or task.wait(plr:GetMouse())


local char = plr.Character or plr.CharacterAdded:Wait()
local hum = char:WaitForChild("Humanoid")
local Animator = hum:WaitForChild("Animator")

local anim = Instance.new("Animation")
anim.AnimationId = "rbxassetid://18239370085"

local animTrack = Animator:LoadAnimation(anim)

-- 18239203600

mouse.Button1Down:Connect(function ()
	if mouse and Playing == false then
		Playing = true

		for _, player in pairs(Players:GetChildren()) do
			local OneCharacter = player.Character or player.CharacterAdded:Wait()
			local distance = (char.PrimaryPart.Position - OneCharacter.PrimaryPart.Position).Magnitude

			if distance < 20 and player.Name ~= plr.Name then
				game.ReplicatedStorage.PlayerPunch:FireServer(OneCharacter)
			end
		end
		animTrack:Play()
		animTrack:AdjustSpeed(animTrack.Length * 1.5)
		task.wait(animTrack.Length * 1.5)
	end
end)

while true do
	if Playing == true then
		task.wait(animTrack.Length * 2)
		Playing = false
	end
	task.wait(0.001)
end

–Here’s The Server Script

game.ReplicatedStorage.PlayerPunch.OnServerEvent:Connect(function (plr, OneChar)
	local hum = OneChar:WaitForChild("Humanoid") or OneChar:FindFirstChild("Humanoid")
	hum.Health -= 10
	print("tookHealth")
end)

–

[How4rdy (Ward)]

i think you dont need to use both waitforchild or findfirstchild at the same time, try just using:

local hum = OneChar:FindFirstChild(“Humanoid”)

if hum then
hum:TakeDamage(10)
end

[WindyTundra]

It still doesn’t seem to work, any other suggestions?

[How4rdy (Ward)]

did it print anything on the server like add a print on the onserverevent

[How4rdy (Ward)]

yeah add a print statement so we would know if the char is passed through the remote event or no

[How4rdy (Ward)]

are you testing against a player or against a dummy/ai bot?

it wont work if your testing against a bot cause bots are not categorized as players

[WindyTundra]

I guess my brain just wasn’t braining

[How4rdy (Ward)]

lol nah its fine i also make this mistake often