Why wont this work?

Help and Feedback Scripting Support
,
#1

game.ReplicatedStorage.ShowMoneyGui.OnClientEvent:Connect(function()

script.Parent.Frame.Visible = true

end)

game.ReplicatedStorage.HideMoneyGui.OnClientEvent:Connect(function()

script.Parent.Frame.Visible = false

end)

while script.Parent.Frame.Visible = true

local player:Humanoid.WalkSpeed = 10

end

I have a GUI that appears while touching a part and I want it to make the player slower when the GUI is visible but the script I tried isn’t working, Can someone tell me what the problem is or fix the script?

image
image1920×1080 283 KB

Btw the first end) worked but when I added on to it stopped.

#2

while == true do
not
while = true

1 Like
#3

also you should never have an while loop without wait()

#4

Ok the GUI appears again but the walkspeed isn’t changed.

#5

you mispelled

it should be

player.Character.Humanoid.WalkSpeed = (number)

#7

I don’t know who told you this, but thats false information. You should almost always change it local side if you can xd.

2 Likes
#8

I agree with you because of the code type thing I forgot what it is called lol

#9

There is an error?

image
image1920×1080 290 KB

#12

do this
local player = game.Players.LocalPlayer
player.Character.Humanoid.WalkSpeed = num

Also you should never loop this if youre just setting it a direct number. You dont even need a remote event to do this. This entire script could be made local and would be much easier and better on performance.

1 Like
#13 
local player = game.Players.LocalPlayer
player.Character.WalkSpeed = num
#14

If the default gui is visible = false, the loop will skip, also this is misspelled

local player = game:GetService("Players").LocalPlayer
while task.wait() do
	if not script.Parent.Frame.Visible then		continue			end
	player.Character.Humanoid.WalkSpeed = 10
1 Like
#15

To the OP, you know when the frame is changing it’s visibility! So instead of doing a loop forever, why not just change the walkspeed whenever the frame is set to visible and reset it after it’s invisible…?

#16

As in, on the event! You set the visibility, so why not just change the walkspeed there instead of wasting resources.

#17

Use this code

 local player = game.Players.LocalPlayer
 local character = player.Character
 if not character or not character.Parent then
character = player.CharacterAdded:wait()
 end

local Humanoid = character:WaitForChild("Humanoid")

game.ReplicatedStorage.ShowMoneyGui.OnClientEvent:Connect(function()
script.Parent.Frame.Visible = true
Humanoid.WalkSpeed = 10
end)

game.ReplicatedStorage.HideMoneyGui.OnClientEvent:Connect(function()
script.Parent.Frame.Visible = false
Humanoid.WalkSpeed = 16
end)
1 Like
#19

Change the walkspeed client side > you practically are never in a situation where you need the server to check the walkspeed of the humanoid. Like literally. Stop giving people bad ideas > its just considered bad programming to change walkspeed server side. You literally never need to check it server side and even if you did > just use fireclient to send a remote from the server. Theres literally 0 top programmers that change it server side. Almost all top games handle effects client side because its 100% better on performance. No one cares about the speed value replicating to server side > all that matters is the actual walkspeed gets changed.

Edit - The only situation that I could logically think of that you would need to check the walkspeed value is an anti exploit script > I also constantly make abilities that involve changing the walkspeed. So again theres literally no reason to do it server side unless youre trying to make anti exploit stuff, but even then you can still do the check client side xd.

2 Likes