Will this AFK detection script degrade performance? If so how can I Improve it

Help and Feedback Code Review
#1

I’m wondering if this AFK detection script that I made will degrade server performance. I wonder this because every second it is loop through each of the players’ tables, AND Constantly adding rbx script events to the same humanoid. Is it going to slow down the performance?
Will this AFK detection script degrade performance? If so how can I Improve it
Heres the script:

local PlayersServ = game:GetService("Players")
local Players = {}
PlayersServ.PlayerAdded:Connect(function(Player)
	local AfkTable = {	}
	AfkTable.Player = Player
	AfkTable.NoMovementTime = 0
	local AfkBool = Player:WaitForChild("Afk")
	local ResetFunction = function()
		repeat
			local Character = Player.Character
			if Character then
				if Character:FindFirstChild("Humanoid") then
					Character.Humanoid.Running:Connect(function()
						if Player:FindFirstChild("Afk") then
							if Player.Afk.Value then
								AfkTable.NoMovementTime = 0
								AfkBool.Value = false
							end
						end
					end)
				end
			end
			wait()
		until not Player.Parent
	end
	local ResetfunctionC = coroutine.wrap(ResetFunction)
	ResetfunctionC()
	Players[Player.Name] = AfkTable
end)
PlayersServ.PlayerRemoving:Connect(function(Player)
	Players[Player.Name] = nil
end)
while true do
	for _, AfkTable in pairs(Players) do
		if AfkTable.NoMovementTime >= 10 then
			if AfkTable.Player:FindFirstChild("Afk") then
				if not AfkTable.Player.Afk.Value then
					AfkTable.Player.Afk.Value = true
				end
			end
		else
			AfkTable.NoMovementTime += 1
		end
		wait()
	end
	wait(1)
end
1 Like
#2

I feel like it might because of the repeat loop you have going. Instead of that you can just create a timer for every player and whenever they move it gets set back to zero.

1 Like
#3

This seems like a huge, inefficent overcomplication; perhaps look into using UserInputService instead?

2 Likes
#4

Thank you, this seems to be a better idea, I knew I was doing something wrong

1 Like