Attempt to index nil with Instance

Scxiptifyz · January 22, 2024, 7:37pm

Heya! i’m trying to make a system where you press a button. And depending on which one you press it will add a value to another value. But its using a module script. I keep getting these errors:

No Boost or info
and
ServerScriptService.Extra.PotionMerchant:10: attempt to index nil with Instance

SevrerStorage Module:

local MerchantHandler = {}


function MerchantHandler.GetItems(player)

	local LeaderstatsFolder = player:WaitForChild("leaderstats")
	local BoostsFolder = player:WaitForChild("Boosts")
	local Items = {

		["Potion1"] = {Potion = BoostsFolder["Gem Potion"].Value, Time = 30, Image = "rbxassetid://15434984615", Title = "Gem Potion", MaxPurchase = 1,  Purchased = 0, Price = 12, Currency = LeaderstatsFolder:WaitForChild("Taps")},
		["Potion2"] = {Potion = BoostsFolder["Super Lucky"].Value, Time = 60, Image = "rbxassetid://15434984615", Title = "Super Luck Potion", MaxPurchase = 2,  Purchased = 0, Price = 24, Currency = LeaderstatsFolder:WaitForChild("Taps")},
		["Potion3"] = {Potion = BoostsFolder["Extra Lucky"].Value, Time = 90, Image = "rbxassetid://15434984615", Title = "Luck Potion", MaxPurchase = 3,  Purchased = 0, Price = 36, Currency = LeaderstatsFolder:WaitForChild("Taps")},

	}

	return Items
end


return MerchantHandler

ServerScript

local mod = require(game:GetService("ServerStorage").MerchantHandler)
local Remote = game:GetService("ReplicatedStorage"):FindFirstChild("Merchant").PotionPurchase


Remote.OnServerEvent:Connect(function(Player, purchaseThis)
	local Items = mod.GetItems(Player)
	local statsValue = Player:WaitForChild("Boosts"):FindFirstChild(purchaseThis)
	local info = Items[purchaseThis]
	if not statsValue or not info then warn("No Boost or info") end
	local price = info[purchaseThis].Price
	local currency = Player:WaitForChild("leaderstats"):FindFirstChild(info[purchaseThis].Currency.Value)

	if currency >= price then
		currency -= price
		statsValue.Value += info[purchaseThis].Time
	end
end)

ReplicatedStorage Module

local MerchantHandler = {}

local Player = game:GetService("Players").LocalPlayer

local LeaderstatsFolder = Player:WaitForChild("leaderstats")
local BoostsFolder = Player:WaitForChild("Boosts")

MerchantHandler.PotionPurchaseCooldown = 3600 -- (3600 = 1 Hour),  (86400 = 1 Day)

MerchantHandler.Items = {
	
	["Potion1"] = {Potion = BoostsFolder["Gem Potion"].Value, Time = 30, Image = "rbxassetid://15434984615", Title = "Gem Potion", MaxPurchase = 1,  Purchased = 0, Price = 12, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	["Potion2"] = {Potion = BoostsFolder["Super Lucky"].Value, Time = 60, Image = "rbxassetid://15434984615", Title = "Super Luck Potion", MaxPurchase = 2,  Purchased = 0, Price = 24, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	["Potion3"] = {Potion = BoostsFolder["Extra Lucky"].Value, Time = 90, Image = "rbxassetid://15434984615", Title = "Luck Potion", MaxPurchase = 3,  Purchased = 0, Price = 36, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	
}

function MerchantHandler.CreatePotionPurchaseFrame(name)
	local Template = script.Parent:WaitForChild("Potion1"):Clone()
	local gui = Player.PlayerGui:WaitForChild("Main"):WaitForChild("PotionMerchant")
	
	Template.Name = MerchantHandler.Items[name].Title
	Template.Icon.Image = MerchantHandler.Items[name].Image
	Template.PotionName.Text = MerchantHandler.Items[name].Title
	Template.Purchased.Text = MerchantHandler.Items[name].Purchased.."/"..MerchantHandler.Items[name].MaxPurchase
	Template.PriceLabel.Text = MerchantHandler.Items[name].Price.." "..MerchantHandler.Items[name].Currency.Name
	
	Template.Parent = gui:WaitForChild("Main"):WaitForChild("Container")
	
	Template.BuyButton.Button.MouseButton1Click:Connect(function()
		game.ReplicatedStorage:WaitForChild("Merchant").PotionPurchase:FireServer(Player, MerchantHandler.Items[name])
	end)
	
	
end

return MerchantHandler

please help
Thanks!

Katrist · January 22, 2024, 10:09pm

You’re not supposed to send the player in :FireServer, as .OnServerEvent automatically receives the player.

Code:

local MerchantHandler = {}

local Player = game:GetService("Players").LocalPlayer

local LeaderstatsFolder = Player:WaitForChild("leaderstats")
local BoostsFolder = Player:WaitForChild("Boosts")

MerchantHandler.PotionPurchaseCooldown = 3600 -- (3600 = 1 Hour),  (86400 = 1 Day)

MerchantHandler.Items = {
	
	["Potion1"] = {Potion = BoostsFolder["Gem Potion"].Value, Time = 30, Image = "rbxassetid://15434984615", Title = "Gem Potion", MaxPurchase = 1,  Purchased = 0, Price = 12, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	["Potion2"] = {Potion = BoostsFolder["Super Lucky"].Value, Time = 60, Image = "rbxassetid://15434984615", Title = "Super Luck Potion", MaxPurchase = 2,  Purchased = 0, Price = 24, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	["Potion3"] = {Potion = BoostsFolder["Extra Lucky"].Value, Time = 90, Image = "rbxassetid://15434984615", Title = "Luck Potion", MaxPurchase = 3,  Purchased = 0, Price = 36, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	
}

function MerchantHandler.CreatePotionPurchaseFrame(name)
	local Template = script.Parent:WaitForChild("Potion1"):Clone()
	local gui = Player.PlayerGui:WaitForChild("Main"):WaitForChild("PotionMerchant")
	
	Template.Name = MerchantHandler.Items[name].Title
	Template.Icon.Image = MerchantHandler.Items[name].Image
	Template.PotionName.Text = MerchantHandler.Items[name].Title
	Template.Purchased.Text = MerchantHandler.Items[name].Purchased.."/"..MerchantHandler.Items[name].MaxPurchase
	Template.PriceLabel.Text = MerchantHandler.Items[name].Price.." "..MerchantHandler.Items[name].Currency.Name
	
	Template.Parent = gui:WaitForChild("Main"):WaitForChild("Container")
	
	Template.BuyButton.Button.MouseButton1Click:Connect(function()
		game.ReplicatedStorage:WaitForChild("Merchant").PotionPurchase:FireServer(name)
	end)
	
	
end

return MerchantHandler

You also can only use a string inside :FindFirstChild, but you’re using a whole instance, which doesn’t work.

Scxiptifyz · January 22, 2024, 10:11pm

Thanks! But in the serverscript im still getting this error:

Katrist · January 22, 2024, 10:20pm

Yeah, I didn’t fix this problem for you:

Because I’m not sure how your layout works.

Scxiptifyz · January 22, 2024, 10:21pm

Can you try and help me out? sorta desperate lol

Where am i using :FindFirstChild(“”)?

Katrist · January 22, 2024, 10:24pm

Could you first off tell me what script is PotionMerchant?

Scxiptifyz · January 22, 2024, 10:25pm

A serverscript which handles the remote event - Checks the currency of the purchased item and price and awards time if price >= currency.Value

Katrist · January 22, 2024, 10:27pm

Can you try printing purchaseThis?

Scxiptifyz · January 22, 2024, 10:31pm

CURRENT ERROR: Serverscriptservice

Scxiptifyz · January 22, 2024, 10:47pm

Hello? Are you there @Katrist

type or paste code here

Katrist · January 22, 2024, 10:54pm

Try my edited client code.

Scxiptifyz · January 22, 2024, 10:55pm

Where?

type or paste code here

Katrist · January 22, 2024, 10:55pm

I edited my client code.

Scxiptifyz · January 22, 2024, 10:57pm

Argument 1 missing or nil:
local statsValue = Player:WaitForChild(“Boosts”):FindFirstChild(purchaseThis.Potion)

Scxiptifyz · January 22, 2024, 11:00pm

I think its using the table, not the boost itself

Yeah “Attempted to index nil with table”

Katrist · January 22, 2024, 11:01pm

That was not the code I sent.

Scxiptifyz · January 22, 2024, 11:02pm

Server script:

local mod = require(game:GetService("ServerStorage").MerchantHandler)
local Remote = game:GetService("ReplicatedStorage"):FindFirstChild("Merchant").PotionPurchase


Remote.OnServerEvent:Connect(function(Player, purchaseThis)
		local Items = mod.GetItems(Player)
		local statsValue = Player:WaitForChild("Boosts"):FindFirstChild(purchaseThis.Potion)
		local info = Items[purchaseThis]
		if not statsValue or not info then warn("No Boost or info") end
		local price = info[purchaseThis].Price
		local currency = Player:WaitForChild("leaderstats"):FindFirstChild(info[purchaseThis].Currency.Value)

		if currency >= price then
			currency -= price
			statsValue.Value += info[purchaseThis].Time
		end
	end)

module replicated


Module Replicated

``` lua
local MerchantHandler = {}

local Player = game:GetService("Players").LocalPlayer

local LeaderstatsFolder = Player:WaitForChild("leaderstats")
local BoostsFolder = Player:WaitForChild("Boosts")

MerchantHandler.PotionPurchaseCooldown = 3600 -- (3600 = 1 Hour),  (86400 = 1 Day)

MerchantHandler.Items = {

	["Potion1"] = {Potion = BoostsFolder["Gem Potion"].Value, Time = 30, Image = "rbxassetid://15434984615", Title = "Gem Potion", MaxPurchase = 1,  Purchased = 0, Price = 12, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	["Potion2"] = {Potion = BoostsFolder["Super Lucky"].Value, Time = 60, Image = "rbxassetid://15434984615", Title = "Super Luck Potion", MaxPurchase = 2,  Purchased = 0, Price = 24, Currency = LeaderstatsFolder:WaitForChild("Taps")},
	["Potion3"] = {Potion = BoostsFolder["Extra Lucky"].Value, Time = 90, Image = "rbxassetid://15434984615", Title = "Luck Potion", MaxPurchase = 3,  Purchased = 0, Price = 36, Currency = LeaderstatsFolder:WaitForChild("Taps")},

}

function MerchantHandler.CreatePotionPurchaseFrame(name)
	local Template = script.Parent:WaitForChild("Potion1"):Clone()
	local gui = Player.PlayerGui:WaitForChild("Main"):WaitForChild("PotionMerchant")

	Template.Name = MerchantHandler.Items[name].Title
	Template.Icon.Image = MerchantHandler.Items[name].Image
	Template.PotionName.Text = MerchantHandler.Items[name].Title
	Template.Purchased.Text = MerchantHandler.Items[name].Purchased.."/"..MerchantHandler.Items[name].MaxPurchase
	Template.PriceLabel.Text = MerchantHandler.Items[name].Price.." "..MerchantHandler.Items[name].Currency.Name

	Template.Parent = gui:WaitForChild("Main"):WaitForChild("Container")

	Template.BuyButton.Button.MouseButton1Click:Connect(function()
		game.ReplicatedStorage:WaitForChild("Merchant").PotionPurchase:FireServer(MerchantHandler.Items[name])
	end)


end

return MerchantHandler

Module ServerStorage

local MerchantHandler = {}


function MerchantHandler.GetItems(player)

	local LeaderstatsFolder = player:WaitForChild("leaderstats")
	local BoostsFolder = player:WaitForChild("Boosts")
	local Items = {

		["Potion1"] = {Potion = BoostsFolder["Gem Potion"].Value, Time = 30, Image = "rbxassetid://15434984615", Title = "Gem Potion", MaxPurchase = 1,  Purchased = 0, Price = 12, Currency = LeaderstatsFolder:WaitForChild("Taps")},
		["Potion2"] = {Potion = BoostsFolder["Super Lucky"].Value, Time = 60, Image = "rbxassetid://15434984615", Title = "Super Luck Potion", MaxPurchase = 2,  Purchased = 0, Price = 24, Currency = LeaderstatsFolder:WaitForChild("Taps")},
		["Potion3"] = {Potion = BoostsFolder["Extra Lucky"].Value, Time = 90, Image = "rbxassetid://15434984615", Title = "Luck Potion", MaxPurchase = 3,  Purchased = 0, Price = 36, Currency = LeaderstatsFolder:WaitForChild("Taps")},

	}

	return Items
end


return MerchantHandler

Katrist · January 22, 2024, 11:03pm

I didn’t tell you to change your Server script.

Scxiptifyz · January 22, 2024, 11:04pm

I found an issue.

“PurchaseThis” was just the contents of the table. It wasn’t referencing the potion Data Type(NumValue)

Now it references the actual potion

Katrist · January 22, 2024, 11:05pm

In my other code, I’m sending over a string, not the table. That’s what my edit was.

Can you please just listen and copy and paste the code I used, keeping your original server script too?