Is this a good way to prevent data loss when the game shuts down?

Help and Feedback Code Review
#1

Sometimes this causes the error " DataStore request was added to queue. If request queue fills, further requests will be dropped. Try sending fewer requests.Key =" but not often, would this be a good way to prevent data loss on game shut down?

game:BindToClose(function()
	for i, player in pairs(game:GetService("Players"):GetChildren()) do
		local save = {}

		table.insert(save, player.leaderstats.Coins.Value)
		table.insert(save, player.leaderstats.Level.Value)
		table.insert(save, player.Times.Stage1.BestTime.Value)
		table.insert(save, player.Times.Stage2.BestTime.Value)
		table.insert(save, player.Times.Stage3.BestTime.Value) 
		table.insert(save, player.Times.Stage4.BestTime.Value)
		table.insert(save, player.Trails.RainbowTrail.Value)
		table.insert(save, player.Trails.RedTrail.Value)
		table.insert(save, player.Trails.GreyTrail.Value)
		table.insert(save, player.Quests.Speedrun.Value)
		table.insert(save, player.BackpackItems.SpeedCoil.Value)
		table.insert(save, player.Times.Stage5.BestTime.Value)
		table.insert(save, player.Times.Stage6.BestTime.Value)
		table.insert(save, player.Times.Stage7.BestTime.Value)
		table.insert(save, player.Times.StageHardmode.BestTime.Value)
		table.insert(save, player.BackpackItems.EpicChatTag.Value)
		table.insert(save, player.Timers.BronzeTimer.Value)
		table.insert(save, player.Timers.SilverTimer.Value)
		table.insert(save, player.Timers.GoldTimer.Value)
		table.insert(save, player.AnimationFolder.Frontflip.Value)
		table.insert(save, player.UserInfo.IsBanned.Value)
		table.insert(save, player.Codes.RELEASE.Value)
		table.insert(save, player.Codes.TIME.Value)
		table.insert(save, player.ReturningPlayer.Value)
		table.insert(save, player.BackpackItems.SnowmanChatTag.Value)
		table.insert(save, player.BackpackItems.SantaChatTag.Value)


		local success, errormessage = pcall(function()
			dataStore:SetAsync(player.UserId, save)
		end)
	end
end)
1 Like
#2

Seems good but might change some things

local save = {
     ["Coins"] = player.leaderstats.Coins.Value
     ["Level"] = player.leaderstats.Level.Value
     --etc..
}

so u can access it easier

print(data.Coins) -- prints player coins

Also if u want to skip the whole queue for DataStore u can use ProfileService

1 Like
#3

Hey, thanks for the response, but i’m so confused, how are you able to put data.Coins, I’ve seen people use it but I’ve never understood it.

#4

I’d recommend using tables only instead of making a new table with values every save, but yeah using BindToClose() to save data on shutdown is a good idea.

1 Like
#5

Use a dictionary instead, what you’re saving is an array. This will make your data structure incredibly confusing when you load it out especially since you have so many values you’re putting into the table and even of different categories.

Data loss can happen in a number of scenarios so it’s not necessarily guaranteed that BindToClose will prevent data loss - queued requests that don’t complete in the time frame will get dropped and thus data loss - so don’t rely solely on the BindToClose. You should have some autosaving as well. Be mindful that BindToClose functions are only called when the server closes, not crashes.

You might also find it much more sane on maintenance purposes to make saving logic once and then apply that to your autosaving, player leaving and BindToClose rather than doing that work by hand in BindToClose itself. This current pattern you have may make saving logic across the board inconsistent.

4 Likes
#6

As mentioned above I would personally use something like ProfileService instead of implementing this saving logic myself, but if you dont want to do that I would recommend using UpdateAsync() instead of SetAsync(). UpdateAsync(callbackFunction) will connect to a callback function that you provide and will give you the most up to date data in that function, so that you can run extra checks and ensure that what you are saving is correct.

1 Like