No it doesn’t?
Shedletsky isn’t giving away free codes for in-game items for buying his NFT’s. He simply using the Roblox engine to create pictures to then turn into NFT’s. Similarly to how making a GFX of a Roblox avatar and selling it isn’t against ToS, taking a screenshot and selling it isn’t against ToS.
As a side note, I seriously doubt John, a Roblox employee for 8(?) years would blatantly break ToS.